Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 13:58:20 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, UNGLinuxDriver@microchip.com,
        Randy Dunlap <rdunlap@infradead.org>,
        Casper Andersson <casper.casan@gmail.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Nathan Huckleberry <nhuck@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Daniel Machon <daniel.machon@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter
 for new rules
Message-ID: <Y7atTB9r07M+ZUC0@kadam>
References: <20230105081335.1261636-1-steen.hegelund@microchip.com>
 <20230105081335.1261636-3-steen.hegelund@microchip.com>
 <Y7aT8xGOCfvC/U0a@kadam>
 <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>
Precedence: bulk

[ Email re-arranged because I screwed up - dan]

On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:

> This series was first sent to net, but the response was that I should go into
> net-next instead, so it is really a first version in net-next.
> 
> What was your question?  I was not able to find it...

Ugh...  Oauth2 code (mutt/msmtp) silently ate my email.  Sorry.

> > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > > ????? ret = vcap_write_rule(ri);
> > > ????? if (ret)
> > > ????????????? pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__,
> > > ret);

There should be a "goto out;" after the pr_err().

> > > +???? /* Set the counter to zero */
> > > +???? ret = vcap_write_counter(ri, &ctr);
> > > ?out:
> > > ????? mutex_unlock(&ri->admin->lock);
> > > ????? return ret;
> > 

regards,
dan carpenter