Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5758ec0ee377aec26440f31d82812aa19dbfba8.camel@microchip.com>
Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter
 for new rules
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     Dan Carpenter <error27@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <UNGLinuxDriver@microchip.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Casper Andersson <casper.casan@gmail.com>,
        "Russell King" <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        "Nathan Huckleberry" <nhuck@google.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        "Daniel Machon" <daniel.machon@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>
Date:   Thu, 5 Jan 2023 13:20:45 +0100
In-Reply-To: <Y7atTB9r07M+ZUC0@kadam>
References: <20230105081335.1261636-1-steen.hegelund@microchip.com>
         <20230105081335.1261636-3-steen.hegelund@microchip.com>
         <Y7aT8xGOCfvC/U0a@kadam>
         <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com>
         <Y7atTB9r07M+ZUC0@kadam>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 
MIME-Version: 1.0
Precedence: bulk

Hi Dan,

On Thu, 2023-01-05 at 13:58 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> [ Email re-arranged because I screwed up - dan]
>=20
> On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote:
>=20
> > This series was first sent to net, but the response was that I should g=
o
> > into
> > net-next instead, so it is really a first version in net-next.
> >=20
> > What was your question?=C2=A0 I was not able to find it...
>=20
> Ugh...=C2=A0 Oauth2 code (mutt/msmtp) silently ate my email.=C2=A0 Sorry.
>=20
> > > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule)
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D vcap_write_rule(ri);
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret)
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 pr_err("%s:%d: rule write error: %d\n", __func__,
> > > > __LINE__,
> > > > ret);
>=20
> There should be a "goto out;" after the pr_err().

Indeed - You are right.  I will add that in the next series.

>=20
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0 /* Set the counter to zero */
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D vcap_write_counter(ri, &ctr);
> > > > =C2=A0out:
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mutex_unlock(&ri->admin->lock);
> > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ret;
> > >=20
>=20
> regards,
> dan carpenter
>=20

Thanks for the feedback.

BR
Steen