Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 15:16:18 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        saeedm@nvidia.com, moshe@nvidia.com, shayd@nvidia.com
Subject: Re: [PATCH -next] net/mlx5: fix missing mutex_unlock in
 mlx5_fw_fatal_reporter_err_work()
Message-ID: <Y7bNot3o3nH/Gxrj@unreal>
References: <20230105114220.466631-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230105114220.466631-1-yangyingliang@huawei.com>
Precedence: bulk

On Thu, Jan 05, 2023 at 07:42:20PM +0800, Yang Yingliang wrote:
> Add missing mutex_unlock() before returning from
> mlx5_fw_fatal_reporter_err_work().
> 
> Fixes: 9078e843efec ("net/mlx5: Avoid recovery in probe flows")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/health.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> index 96417c5feed7..879555ba847d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
> @@ -677,6 +677,7 @@ static void mlx5_fw_fatal_reporter_err_work(struct work_struct *work)
>  	mutex_lock(&dev->intf_state_mutex);
>  	if (test_bit(MLX5_DROP_NEW_HEALTH_WORK, &health->flags)) {
>  		mlx5_core_err(dev, "health works are not permitted at this stage\n");
> +		mutex_unlock(&dev->intf_state_mutex);
>  		return;
>  	}
>  	mutex_unlock(&dev->intf_state_mutex);

Shay is working to rewrite 9078e843efec ("net/mlx5: Avoid recovery in probe flows") completely.

Thanks

> -- 
> 2.25.1
>