Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 21:01:14 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Heiko Carstens <hca@linux.ibm.com>, yang.yang29@zte.com.cn
Cc:     freude@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next v2] s390/zcrypt: use strscpy() to instead of
 strncpy()
Message-ID: <Y7bYKgjYSG09OD0f@debian.me>
References: <202301031002076571212@zte.com.cn>
 <Y7P6mSuYkmP8g8Ot@osiris>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="OpWV2mU/05KOlxs5"
Content-Disposition: inline
In-Reply-To: <Y7P6mSuYkmP8g8Ot@osiris>
Precedence: bulk


--OpWV2mU/05KOlxs5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 03, 2023 at 10:51:21AM +0100, Heiko Carstens wrote:
> On Tue, Jan 03, 2023 at 10:02:07AM +0800, yang.yang29@zte.com.cn wrote:
> > From: Yang Yang <yang.yang29@zte.com>
> >=20
> > The implementation of strscpy() is more robust and safer.
> > That's now the recommended way to copy NUL-terminated strings.
> >=20
> > Signed-off-by: Yang Yang <yang.yang29@zte.com>
> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> > ---
> > chang for v2
> >  - match the FROM with the Email
>=20
> You sent this from yang.yang29@zte.com.cn, but the sign-off is without the
> ".cn" suffix. Can you please make sure that your sign-off chain actually
> follows the rules as outlined in Documentation/process/submitting-patches=
=2Erst?
>=20
> If you read that then the sign-off line from Xu Panda shouldn't be there,
> since the patch was not authored or routed via Xu Panda.

Specifically, the second SoB from Xu should only be included if he was
in From: mail header (that is, he should have sent the patch instead of
Yang).

Ah! Thanks for reminding me of this trivial issue that I always missed
when reviewing ZTE patches.

Xu, are you really transporting Yang's patch?

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--OpWV2mU/05KOlxs5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY7bYJwAKCRD2uYlJVVFO
o5S4AP95j5Jj6Yu5/m76VPdoMVaMFkwkB6k44b5xhsPWdopqBwEAglth7VekCRz5
oOf+gf5FpLY6cLn7z2CRuX/MNzLNnwQ=
=01JV
-----END PGP SIGNATURE-----

--OpWV2mU/05KOlxs5--