Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp1020219rwl; Thu, 5 Jan 2023 07:43:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXso9naSgnXlYsY6zKjIWwisMa91Sf0eZoNMQXJSZlQafGPI/0PTQuPqS0xbImiNwFa76WZA X-Received: by 2002:a17:906:158c:b0:7c4:f752:e959 with SMTP id k12-20020a170906158c00b007c4f752e959mr41987538ejd.33.1672933391285; Thu, 05 Jan 2023 07:43:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672933391; cv=none; d=google.com; s=arc-20160816; b=xWdYW9ErG0EKlTMAgk4HoyKQpQQ2knPTp1AMCmQJVDtMBxtg6N9zXGaoMc28nVLmCT +DDCJy073eANxQ4i45A//+fCFsvOhS++Csd7PfDZ/zBB5HPzndlBZu6AIg0OJkrF5Piu wErK9JZ3EEI4HRzgZYq1B1DMnM+7womECgfOBKD/sbpJ7dFwsWwt5QxmkeWNc3xJaPPj WSIIKU4WT+HcyCCBYxddvYnZ9roMTsTbzhBLngUq5P1KCmwicE5qecV+tnRlmAHv76Nx Ir4vQX744OhgAlhUlGslWrKkCjmvZ82jQQdJFbiYgmILndEmO1owi8p7guD6Ohm4R/G0 mz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=akusGsUZXZtdTDkRZUKw9Nu/DY3f2d9NmRrGUjuJzCA=; b=lF9i3XrT56v6NW0mWYXztLcq0OfvBbllxR+xCWZnaCp6fhimE30LdvzHJtmMpzni5o iGRDEelxCiVZpwV2b+JqKRzYI1aQs8HU6AX8/x8I7/X9zAqB03D2GXQcgqVnJ3ZQ6E1t l7xQB56s5YFNMLC2BCYBxgUTIjZ+9jgCsQdJVzFzxqyQsYcN68u6oI0h+0gsON0PVj6a /JPUpkf6+m9vxcKyaO89aqsaX0Hh6x6MpFfjSx6iORBaGEWYRTsxRQ7xIzFezftSo/LL m8zo3dtl25CajRFm/o4p6kQRDkLtFXEr58uGYl0aiv7OJkG35JmrjMqK57I8bZRJSnDx C9ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ekE8Rde3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa9-20020a170907868900b007c15653692csi35386237ejc.287.2023.01.05.07.42.57; Thu, 05 Jan 2023 07:43:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ekE8Rde3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbjAEPYF (ORCPT + 55 others); Thu, 5 Jan 2023 10:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234694AbjAEPXx (ORCPT ); Thu, 5 Jan 2023 10:23:53 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E5312E7; Thu, 5 Jan 2023 07:23:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 22ED961A8B; Thu, 5 Jan 2023 15:23:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 862E5C433EF; Thu, 5 Jan 2023 15:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672932231; bh=1t+dUPzSA0ksnrUuc8/Bbo1ZUCkWyj4rbPQo9hsDiJ8=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=ekE8Rde3RBggbbEDkhEA60YtQl5GRgO3hi1QwU9aBreHSl7bI3+UCqBNHFNPhuDWo OZwnBLCy/Ttx+tOPXCJf2d4D/+hW9y7bBdQUBv2OOuOFVChia7xIwse1vlRbQKHymC 0jXxVSOvRFqmHz7ddIjpvjnuFx822i/JUP1WKeA9PZb3iqMZApZewGSgVPlo0ujiqo C5u4ux6OfcDnNR69LAriJgAwj4S4d2yWtkx950jmyHPlerjL6LL81Yrjt5RMBE6XD/ m6r0wDcYagxFLnM8xW5rAojK4nVYjWKi5DgQdNksOo+ylZUXfK2NWDAey+c2+btzus YaN8KHkDZuxhw== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 22D145C029A; Thu, 5 Jan 2023 07:23:51 -0800 (PST) Date: Thu, 5 Jan 2023 07:23:51 -0800 From: "Paul E. McKenney" To: John Ogness Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, Petr Mladek Subject: Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU Message-ID: <20230105152351.GP4028633@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1> <20230105003813.1770367-27-paulmck@kernel.org> <87r0w9csqn.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r0w9csqn.fsf@jogness.linutronix.de> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2023 at 09:10:16AM +0106, John Ogness wrote: > On 2023-01-04, "Paul E. McKenney" wrote: > > Now that all references to CONFIG_SRCU have been removed, it is time to > > remove CONFIG_SRCU itself. > > I think "all references" is a bit misleading since there still are > several places in the kernel code that use it: > > $ git grep CONFIG_SRCU > drivers/base/core.c:#ifdef CONFIG_SRCU > drivers/base/core.c:#else /* !CONFIG_SRCU */ > drivers/base/core.c:#endif /* !CONFIG_SRCU */ > fs/locks.c:#if IS_ENABLED(CONFIG_SRCU) > fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */ > fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */ > kernel/notifier.c:#ifdef CONFIG_SRCU > kernel/notifier.c:#endif /* CONFIG_SRCU */ In the -rcu tree, these are removed by these commits: 1798c5b6b0ea ("drivers/base: Remove CONFIG_SRCU") 19aa50512372 ("fs: Remove CONFIG_SRCU") fe0c9bd625ad ("kernel/notifier: Remove CONFIG_SRCU") > Should those be removed before this patch? When I merge the -rcu tree's "dev" branch with current mainline, "git grep CONFIG_SRCU" gives me no output. Am I fat-fingering something here? Thanx, Paul