Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 07:45:58 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Jan Kara <jack@suse.cz>
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, rostedt@goodmis.org, Jan Kara <jack@suse.com>
Subject: Re: [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
Message-ID: <20230105154558.GV4028633@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1>
 <20230105003813.1770367-21-paulmck@kernel.org>
 <20230105113015.6f3ikdgmnhweoish@quack3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230105113015.6f3ikdgmnhweoish@quack3>
Precedence: bulk

On Thu, Jan 05, 2023 at 12:30:15PM +0100, Jan Kara wrote:
> On Wed 04-01-23 16:38:07, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > Kconfig statements.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Jan Kara <jack@suse.com>
> > ---
> >  fs/quota/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Sure. You can add:
> 
> Acked-by: Jan Kara <jack@suse.cz>

Thank you, Jan!  I will apply both on my next rebase.

> 								Honza
> 
> > 
> > diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> > index b59cd172b5f97..d5a85a8062d05 100644
> > --- a/fs/quota/Kconfig
> > +++ b/fs/quota/Kconfig
> > @@ -6,7 +6,6 @@
> >  config QUOTA
> >  	bool "Quota support"
> >  	select QUOTACTL
> > -	select SRCU
> >  	help
> >  	  If you say Y here, you will be able to set per user limits for disk
> >  	  usage (also called disk quotas). Currently, it works for the
> > -- 
> > 2.31.1.189.g2e36527f23
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR