Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6bab266-c87a-0fec-443a-f608714d7e0b@amd.com>
Date:   Thu, 5 Jan 2023 09:48:03 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH 3/3] x86/resctrl: Display the RMID and COSID for
 resctrl groups
To:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>
Cc:     "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "Eranian, Stephane" <eranian@google.com>,
        "peternewman@google.com" <peternewman@google.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
References: <167278351577.34228.12803395505584557101.stgit@bmoger-ubuntu>
 <167278361325.34228.16916982678071203069.stgit@bmoger-ubuntu>
 <IA1PR11MB609764AC3E09E0A1F8A8FF7E9BF59@IA1PR11MB6097.namprd11.prod.outlook.com>
 <58d53ab6-df0c-9e8c-052a-a8b60c9a8258@amd.com>
 <IA1PR11MB6097E141C8C207EA527B992D9BF59@IA1PR11MB6097.namprd11.prod.outlook.com>
Content-Language: en-US
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <IA1PR11MB6097E141C8C207EA527B992D9BF59@IA1PR11MB6097.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWoxenFVM1dHdS9aUG1ITS9sQ3pDSHdmWm9DcSt6Ylhsd2FCbmVWcHd0Rjd1?=
 =?utf-8?B?M2lpc0ZtenpHbTJRVEJzOW16eDMwbEQvYlA2bmFtNFF3ZHN0WXArL1FqMGhG?=
 =?utf-8?B?UlQ1bksxazFSYjQ5cDZVZGVRamJaSWtuaEpBZnQyYUFKRGNuR3ZYWXZXTVg4?=
 =?utf-8?B?ZjJ4WSszcW5XSFozMCtiajhjcXdnbmt2SVNPVVVlMnNKRG0wWjNLT3l2MVJs?=
 =?utf-8?B?MnBJZVIyY3NqcTlHcUxheEo1NzVhQkVJOUE3KzZNTi82cEoxMFp1cG9ITVF1?=
 =?utf-8?B?cVI2U3Zzd3cyMlpJb2VkUVFDek5QclpvYm9WekxTQTM1SzM4YTRJNnVHYzJR?=
 =?utf-8?B?RFFYaHRxUjVXdWo3QkQ5K2h1THovUy9HeHArVDZLOG9UNUczNHllcHNncW40?=
 =?utf-8?B?QWF3SER3V0pqQ2M4T3ZISmpmbDI2QUZjS0swRmN6MkM0aDU4eCtqaXVFaloy?=
 =?utf-8?B?L1phbnlqbVY3RDg4ZEhjMlFBK294anRiMDhBd0N2YXpBOEZ6MVNDZ3NDV3Vt?=
 =?utf-8?B?Y0pDZ0RQWWp3OUVvTVhsb3R6ekdoc0tkYmh6ekd5bytVdjh0SHZjTHBKSjBY?=
 =?utf-8?B?UXpJcG1tU0hrUmxMQTNrNFR0ekg3cDNXS1lpeG9SdE12cGttVTQ3YjhiQXBW?=
 =?utf-8?B?S3Y3TFkwamoxUmJWdlkzT29KbmhIaXR1VGlzWUF1cFd6TlJpYmVNaE04eDhl?=
 =?utf-8?B?b08vWFc3S1ZuaGw0Ui9hRjR2elVsZHhIUWZzcGxWWE5qR1NvdTRaT2t0Wkxa?=
 =?utf-8?B?VkExRUJQNjhSTVVleHE0UmdrOTlUb20yc0N3L1RUeUZJeGZHai83bkR1U21K?=
 =?utf-8?B?NHRKNjh5R1N4UHk0NDN4aHFzRjZBN2E5WVRNQmNISjBUZm9Qc29mbEdYTHgv?=
 =?utf-8?B?b1JXbkRsQjlBVS9hR2Y3M3RsZ3VHOHlVSnFIbEFVVVhWY3BXSkJPOGxvMHFv?=
 =?utf-8?B?cGQzbE1qd29xNkoyY3VoQXh5cWd5aEpzQ1VabWNoQzNSc0hLVVFMK0ZUZkdj?=
 =?utf-8?B?UW1XcWVHK2JyVlI2Q3dyRVh0MVV3ZkdhM1J1L2ZSMEJLOWpsWWd2ZFV0Vkxy?=
 =?utf-8?B?L0p2S3BabUM3VDNzVzRUUTZaYnN5Tk0zYjRZaGUrVFVGZlJQTUVlbDhsU3Qv?=
 =?utf-8?B?TUhTc3cvQnZoRjhiYjVIVVFIdGlXbmVhOEhqM01tUzhxTzJ0d2gva3VQVTVx?=
 =?utf-8?B?ZzVBUnVPaGhqcGdjbjdaRkV6dnNYTGMvdEhZakx0bGxhTTZJKytwa0I1d1Zv?=
 =?utf-8?B?cnpTaXVFT2JTQlVkS3A0OWp2eWszSWFpTFJxQTJxd29UZ0ExWlIxcmpFdEpm?=
 =?utf-8?B?ZUxnajFlYmtpR3hFczc3eHQ4K2VER2Uzc2x6K3QxUSttdlEwYXJ1dUdSckF2?=
 =?utf-8?B?aDdXTXFGS0hUamxXQVg0cGwyUk5zWmFZSHNUNkRMVnhtdnNIRWkydWFUamIr?=
 =?utf-8?B?RzdacndiRTZJemdYUzBlYUNwK1QyczF4OUVaZkdaeGxKdkRtd0g2aG9UMFMv?=
 =?utf-8?B?SllPWlFSeDA1c1F2VFVUOCtXTnIzMmVwcXQ3SG96NEVYMUc1eDZ4M0M0c2x1?=
 =?utf-8?B?RG5MWFlYKzhjTHJmZFRibzZtUHZQcTBzTjc4UkZQMnk5SHFhbnZXbEgvT1p1?=
 =?utf-8?B?d1RndjhQd1ltcmgxSDAzVm1vMDNaejAwUWdHbmI4OXI3TktENGZkdmhzcllM?=
 =?utf-8?B?anZLQTdwTFg5T0Y1c3JRaUVtMXFXZ0lBcUx5blZxY00zZHRNNkpoZ0NOMmJR?=
 =?utf-8?B?UkZySngvZFlqaGFWM2lLbEUwWDhoUDlvOWlJZ241ejUzL3dDeWIrQ2sxZVhP?=
 =?utf-8?B?Nkt3ZHJlNGVoZGg4UkdVTVdBRzBGTGY2K1I3RWRXSkt0NUdnT3IvOVQySWMz?=
 =?utf-8?B?ckNPZ1kzMVZwVzdZME9nUTM1RFlpUEtCZlhjajlJeFVFQ2hKQnNCZVB4dDdS?=
 =?utf-8?B?UVh3UWJjTjRGV3A5cmVJMFh2aXJmTjhJMTJJeVZ1WTBHTzByTHhFM3ZoZXlN?=
 =?utf-8?B?QzVjTk1XZmVJWVMvc2VIaldCQVBvTzVWZko5THdoczVwMkRqSXNycnluUUpO?=
 =?utf-8?B?Q21GaWFwc0s4MHFKZGZrbWhvVk9aU1kwbnVZanlyd0ViUTVCWTU2MnFrOEQ1?=
 =?utf-8?Q?uji4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2649f40a-f802-4fbc-726b-08daef343d53
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 15:48:07.5062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vwsx6HT+OipLWXaL8xJf+reFOE3mKZLSW3175HTA2yIF2MzPwDlhGtc4jo1cLVvd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5601
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fenghua,

On 1/4/23 17:54, Yu, Fenghua wrote:
> Hi, Babu,
>
>>>> When a user creates a control or monitor group, the CLOSID or RMID
>>>> are not visible to the user. These are architecturally defined entities.
>>>> There is no harm in displaying these in resctrl groups. Sometimes it
>>>> can help to debug the issues.
>>> Although "no harm" to show them, it's not useful for generic user
>>> either and may cause confusion sometimes. CLOSID and RMID are supposed
>>> to be invisible to generic users.
>>>
>>> Maybe introduce a new resctrl mount option called "debug" and show the
>>> files and maybe other future debug info only in debug mode?
>> Actually, test team feels very strongly about this. Whenever there is some issue,
>> first question is what is the rmid or closid are you running on? We normally don't
>> have an answer for that.
>>
>> In my opinion, adding debug mode just for these two fields seems way overkill.
> Yes, they are useful for "test team" (quoted from your statement) and developers.
> Not for end users.
>
> A debug mode is useful not just for these two files. I'm working on another resctrl
> project where much more complex hardware info needs to be dumped for debug purpose
> only. It's obvious not to show it in generic use. It's more obvious to just show the info file in
> debug mode in my case.
>
> I think these CLOSID and RMID files and future debug files belong to a new debug mode.
> It would be better to introduce the debug mode now rather than later so that it can be extended
> easily in the future.
>
> Maybe we can enable debug mode in a separate debug mode patch:
> 1. Add RFTYPE_DEBUG as a new file type. Files with this flag are for debug purpose and only be visible in\
>     debug mode.
> 2. Add RFTYPE_INVISIBLE as a new file type. Files with this flag will be invisible/not be added in resctrl fs.
> 3. Add mount parameter "debug" so that ctx->debug=true if mount -o debug is given.
> 4. If ctx->debug is true, in rdt_enable_ctx(), go through RFTYPE_DEBUG files in res_common_files[] and mark
>     fflags with RFTYPE_INVISIBLE.
> 5. In rdtgroup_add_file(), if (rft->fflags & RFTYPE_INVISIBLE) return. So the debug files will be visible only
>     in debug mode.
>
> With the debug mode patch in place, it's simple to extend to any debug files:
> In your case, update this patch by just adding RFTYPE_DEBUG in fflags. Then the debug mode will work
> for this patch automatically.
> In my case or any future debug files, we just simply add RFTYPE_DEBUG in fflags and the debug mode will
> work automatically.
>
> Does it make sense?

Yes. Sure. The debug mode needs to be resctrl mount option. I will take a
look at this further to see what can be done.

Thanks

Babu