Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 07:41:19 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Qu Wenruo <wqu@suse.com>
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, rostedt@goodmis.org,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
Message-ID: <20230105154119.GT4028633@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1>
 <20230105003813.1770367-18-paulmck@kernel.org>
 <ba9a15cd-5d95-d766-19a7-17e0925bc63c@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ba9a15cd-5d95-d766-19a7-17e0925bc63c@suse.com>
Precedence: bulk

On Thu, Jan 05, 2023 at 05:06:09PM +0800, Qu Wenruo wrote:
> 
> 
> On 2023/1/5 08:38, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > Kconfig statements.
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Chris Mason <clm@fb.com>
> > Cc: Josef Bacik <josef@toxicpanda.com>
> > Cc: David Sterba <dsterba@suse.com>
> > Cc: <linux-btrfs@vger.kernel.org>
> 
> In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we can
> completely remove any SRCU related configs and even includes.

$ git grep srcu fs/btrfs/
fs/btrfs/disk-io.h: *   fs_info->subvol_srcu

I know that situation.  ;-)

> Reviewed-by: Qu Wenruo <wqu@suse.com>

Thank you!  I will update on my next rebase.

							Thanx, Paul

> Thanks,
> Qu
> 
> > ---
> >   fs/btrfs/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> > index 183e5c4aed348..37b6bab90c835 100644
> > --- a/fs/btrfs/Kconfig
> > +++ b/fs/btrfs/Kconfig
> > @@ -17,7 +17,6 @@ config BTRFS_FS
> >   	select FS_IOMAP
> >   	select RAID6_PQ
> >   	select XOR_BLOCKS
> > -	select SRCU
> >   	depends on PAGE_SIZE_LESS_THAN_256KB
> >   	help