Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9afd6384-fb1a-933f-7873-eaeec38cc65c@amd.com>
Date:   Thu, 5 Jan 2023 21:33:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v9 09/13] cpufreq: amd-pstate: add driver working mode
 switch support
Content-Language: en-US
To:     Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
        Mario.Limonciello@amd.com, ray.huang@amd.com,
        viresh.kumar@linaro.org
Cc:     Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
        Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
        Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221225163442.2205660-1-perry.yuan@amd.com>
 <20221225163442.2205660-10-perry.yuan@amd.com>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <20221225163442.2205660-10-perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RW9FenJUcytkTWtNNTlkL0tRUnBvQzVMSVFyRW5WcS9pbjJ3T2tTN3lhQ0NR?=
 =?utf-8?B?b0g3aUl0U1o5ajhVcHgrNmdnQitwVUJiSW1EWWlqWHNxWGtUTkRmWmpTdHpZ?=
 =?utf-8?B?YTIxSkk0QlhwdERNc1ZPYzVnM2ErZXQyYWNaU3l3bmxiK2dZUFFTb1VLaVpa?=
 =?utf-8?B?MDlHTFRuUTR4aVBLdDVsQ3ZuZmJBbThoWTRFc2N6cFpkRkdKY2FDZTJQamVj?=
 =?utf-8?B?d3FZNFhKRzRzckF2SHFCemVDZzhqQ0RMM0FHN0N0OUthOFAzRkxNY3VEVjB5?=
 =?utf-8?B?YlFxUTZrcGh3NzVxeExhSzc0d3ltMXRXQzVTcEdCVm1XaE5hVlBiWFVYVG1U?=
 =?utf-8?B?MVAyUFpvalJJaU1Kc1BKL3A4L1l5V2p2bldTNk84UUJsd2p2amNXUHNlVS9W?=
 =?utf-8?B?amF3SXN3NlJsQ2ZLT2hweEpqNEYvM1ltYlEyNjRwMUxJSVgrOHJPa3luS25o?=
 =?utf-8?B?TlFoNVBSWUdScktFUGdXV1phdXQ5Mmd2WDRjcml6dy9pZzUvYS9sbENBNzRU?=
 =?utf-8?B?YUQzMW9qdUw5SzdTMHdlL3VTQ01hVjk2NzZyaUpCZlFyeFFNajZzZ0s5bkM5?=
 =?utf-8?B?WGFzWDc2ZVNOWWZGM2dqQ1JXR3krZnYxZ3M4TnVXOHhweWxZaFdYd1JOWGtO?=
 =?utf-8?B?VDM0bzBQeERCQ1Iva3hSTEtYVzludkZRemMweDJxc1JHbjV6bVF1SG81T1Bz?=
 =?utf-8?B?eC9lK0hGYXQrTnRTTU9pbFVpRzd1RnNKcEVSdS9pM2s3aFNJRFhjY0hmc3Zk?=
 =?utf-8?B?UVcwNmNUNFlJUFRFRlN3clNEdEZxVWZzQ2RzLzZlL0JUMWQ4SFRvUWVUYytx?=
 =?utf-8?B?aXZVdGNkTllGcXpsdWxOdWNPUkxwNmxkREMyRldOK1NaSnNSajgzVkpCKzhQ?=
 =?utf-8?B?dTF1QWI2NTRERkQxc3BaNStMQ1hEcFZuNjZPOUdxT0FzQlJtVEpCa3lDQ2JK?=
 =?utf-8?B?SkRQK0N4Zk55emk3R3hDenpYbkpORTlBbm5aRGJXb2xla3g2QlVrZ1YzSWdm?=
 =?utf-8?B?QlhORkJNOWY2SnozSmNTNE1ZMFltUnFXN29aNEZVeTlncHVDbGFad3hMSWtk?=
 =?utf-8?B?TzVPM1JWMVFkZmRLS3Q1cjdxM1QvTkhZL0lOYlZtNXY0SUtud0FseUVSVEFP?=
 =?utf-8?B?U0dNbXY2ZnJON1RubGdZdE1ySlNiNFplTWxsc2c4Qm4yUjdMWmp6UE9NZE52?=
 =?utf-8?B?Y0x3dnl4ZW1RR04yZFZtc3gvRkNHUlB5NjNGVWdubGZsN0Ezbm1JVEhRMEFR?=
 =?utf-8?B?TVgyNDNJZk1aQzNscTRHeE54V0Y2VlFpZDhKSzBNQVR4U0NrdnFWeTA5K3l4?=
 =?utf-8?B?VTVwc1FKMStlakhqY0JRMjc4WTNLT1NRbkpwaEwxZ2NTakdFMkM3RnFYR2lO?=
 =?utf-8?B?U2FMRkQ4bzM5aEdBeGQvZnc5KzljODVaeHFKb3prUW1vNzV5NWpiMDRzSFZY?=
 =?utf-8?B?M2E4WVVQZXU1MnduOWZndVhGdDVzWVNNMVpjM3JoYkYvY3lQUGlTdFVONmpF?=
 =?utf-8?B?QXZ1R2tBQVVvaU1vbjhRcVM5R0FYczF5czc0aHk1Tmw5bE84Q0FBRnV6SzJz?=
 =?utf-8?B?eWR0YlVmNlJ4dXF5Sjd2ZTFHcjV1ZnE0NFdMTWZYMGFhVFhjTjR0NXg2YU1V?=
 =?utf-8?B?N3A1S1JGd251SWg2cTBPc1Jaa0xqWnJIU2wxcWsxazdMZ0RUUUF3L04wbG9o?=
 =?utf-8?B?dGJmNnh5R3J2ZUo0dTZ4TUJDQ2hoWFB5Und4RXZKd2VJN0ZJMC9Wb3hMZmdp?=
 =?utf-8?B?c2t4U3kwZVQ2Y01qTmNMbzJiSnVGeGF1N21rdklYUzZXazhjS1RoV3V6VUc1?=
 =?utf-8?B?MTh1QVlYNmJOb3B0SnJsNlNlazF2OUFIdkZoMlZzSlV0N0hTWmtVSlFXTHJ6?=
 =?utf-8?B?NTlxWXcvTU9WbmtGc2lxamkyaWZDQ2V3dWY1Y2t5MnBWRFczUWl6dkg2S0hx?=
 =?utf-8?B?anY0MTVGa0pxbVgxNlAvZG9nQnBUWS8yWEk5cUVGUTVVdlNlSVFFOHM3MXhN?=
 =?utf-8?B?QmU2RXlQdHd6VEpqS25vVVQrU3pFbURnYVFwMDJRMkE5dVlZc3JvYVpqSTZI?=
 =?utf-8?B?OVJsa2tJT29uRnpnY2N6ZWp6MDIzTFBINnpxN2xCaUdHRHhpWG54cElRN0Qx?=
 =?utf-8?Q?jNLCGkdo5PoLX59C3BUpsbSvs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a39a8a03-e118-4f9e-00b4-08daef366bed
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:03:45.1187
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2370xOi4IMtRMSa1fkeOzNgW1E0z3sEhbe6XRuPnBxEQXxexHA/Zol9pY02ITCfLDt3zNhaL1LS1arwWUOAw3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7549
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Perry,

On 12/25/2022 10:04 PM, Perry Yuan wrote:
-------------------------------->8--------------------------------
> +
> +static int amd_pstate_update_status(const char *buf, size_t size)
> +{
> +	int ret;
> +	int mode_idx;
> +
> +	if (size > 7 || size < 3)
> +		return -EINVAL;
> +	mode_idx = get_mode_idx_from_str(buf, size);

if (size > 7 || size < 6) right?
because possible strings are: "disable", "passive" and "active".

-- 
Thanks & Regards,
Wyes