Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6bb126b7-1cb4-0c4c-d357-fadc3ffdd3f9@amd.com>
Date:   Thu, 5 Jan 2023 22:34:10 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] ASoC: amd: ps: Fix uninitialized ret in
 create_acp64_platform_devs()
To:     Nathan Chancellor <nathan@kernel.org>, lgirdwood@gmail.com,
        broonie@kernel.org
Cc:     Syed.SabaKareem@amd.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org>
Content-Language: en-US
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjlvZnpVRjhlRFlDMXJ2Nzc1MHZveWptcm9RK2Q0M0hSSXRSOXhmb3owQm40?=
 =?utf-8?B?R0JVRERsTVlOR281VkhEVmJaOE1ZT0RoUGs1TXFOWnhSb3RNL1NiTFVEQW9B?=
 =?utf-8?B?MlhqTHhCQ3NnSkNtZ3JTYzhQRU1vVTB2UHNFdWJpY0pqNE5UZi9HbThSVVFh?=
 =?utf-8?B?UUVmVDNlR01nZXhoMytHQWszZnB6anhmbEk0N3QyWG83dGhSUjdydlNCREpi?=
 =?utf-8?B?Nm9WeHIrMnNsV2kwaThZR29KZ1JTVG5hZU9xT2xMbFVnZFpKZDRxaXJidkZv?=
 =?utf-8?B?QXRmbkVZYXJ6bTVCL1ArRzlJeUhURU80OEI5OU0vNlBVTmdOWWtqTG5BRU1U?=
 =?utf-8?B?OFVNdE1NQjlPUFdOaHVZTHJ4VThYTDRpWDNwdm5sUktvdFBWQUFGRG1kQ2xX?=
 =?utf-8?B?Zld3VCtBRkg1aEpyZmM1UlNFVDJHR25GUmFJdkNlc0prSDByV0E5L1N3RG5S?=
 =?utf-8?B?OG0weEF4VG9qS2RiL0xRVjBtMDNEQUx3WXFvYTJuMXJMN2ZzZDQrZytKU3Bi?=
 =?utf-8?B?YUluT1IyNmQya0pvOHR6ZDJyTWNqOWJWMGpFSWRMYnBSQk5rNGxyWGI3R3Az?=
 =?utf-8?B?V1BBcUowVlNGYk05Nlo2ckpXZi80Z3dHVU0reUwwR2RWV3lRQlVqWXZBcUJK?=
 =?utf-8?B?YVNRbW5yNVFpM0docXd4SThTUmxDQkRORjNIL3JnM3dOTXhYc25PdTY2akFZ?=
 =?utf-8?B?d1F4V2hjZEhrL2FzVURzSUhMb2tDckhuVGd2Q1Z3V3JDazcvdlhLZ1NRdUdI?=
 =?utf-8?B?YnJrRGYxTGdwUXB3VjQ1eUJHazVXK0lOaUVrVnRQd0F2cThCSEJOajBEaVpq?=
 =?utf-8?B?a3RGbCtxZmFXcnNJd3Z6Q2FwL2lCNi90WTB1ckNVNlpCOFZEMG13ejlMRm5h?=
 =?utf-8?B?TWFtR0xrK2F1VDBSRHg0cXdQdWVBaFkxeExUaTM1MkNFeEFHbjg3NTlmN2RV?=
 =?utf-8?B?ZjRydWEyQWZJWU90Q1Q5ZjF1bDZUZnMzVG1VT00zZnQxcjdlc1pDR2lFTXZr?=
 =?utf-8?B?UDBPNzVaWmVRSkNqOW1RWTdzOFFHZEN6QTZ5ZTdQbHVva1FDRjFod3RWQlJ5?=
 =?utf-8?B?QXh2ZjBmc1JlaDgrb2dpVDNWeW9VQzdVL2lWSXhkUGpFdHpZQUhsRXJtUDZj?=
 =?utf-8?B?UHZGQnhNREFTT1Nacmo5Qy8zVXQrdURRam9ENDJtb2RLUHJ4b1FYbW9XTW5i?=
 =?utf-8?B?Nk13SXBoak5yTFBQenZCOUVDQ21oOWxweVB4TDVTZU0vL2pSVm9ISVNRTFZF?=
 =?utf-8?B?SHJXSlBaS0l3QUZiZS96UkZtZHJiVVNsZ3AzM2hHOG1lUTFyMWNJNU44VHdh?=
 =?utf-8?B?TEdndWlRS1pZdmErOStYV2p6c2srcFVqN2Mxbi9ZZFR6VnBMaWpkWGE4dW1O?=
 =?utf-8?B?clpjOWRtVmErZHdxMUlRL1I2Tm5pSzhnQnpzV1k3MnZPQzRRNEoxUFQxRDZr?=
 =?utf-8?B?SUpIam53RGpiZlM4NDBITGFnaVhQSktzdmVrajhJYU5UblorT0sxV3B4Tkpl?=
 =?utf-8?B?bDgzVEtSZGVoZHlCVWZCZElxdEU0WjdZbTZKTTNIQStFWnFEY295ZTV3NUtJ?=
 =?utf-8?B?UFVjQnI0ZDU3LzV0Si9lMHdteDBoR3I0VkdkdUVkb3Q1STIwSFRwd2I0WjlH?=
 =?utf-8?B?OWRWZkZCVmlxQzhuSHFwUFFoNlN3UndLSHRLdnV5RktzOUl5bWFoczdBLzNj?=
 =?utf-8?B?SUNMcGcxeEZZTHM1OVF5dzY4eWgzTWJ6YUFScEkwWWJvNWRWTmxpZUJZQzlp?=
 =?utf-8?B?b1RaUyt3TDlSSysvcHlGN0lmTzM2YXRtV1pqUFhwSjFuQjZUU0J5MWh6bmND?=
 =?utf-8?B?MjEvdjFGU0RMRW9GQWk3UWlydDdCMXVlSDlPS250NkR0UEYwOHlZL2w5R0sw?=
 =?utf-8?B?NjJuTmxQVlpHem9lZFBTQ1RsRFhZVWVISU5nSzZqMjc3MzlrS0NsNER0V0Zm?=
 =?utf-8?B?TjJEZWRNb2tGV1pGck5IZzM1cTZ0VDFpcEl2dEN6VGlQK3dpT09kUHl4bWZY?=
 =?utf-8?B?MHM4VHFiMGRZRStPRTZJZzQ1QWhEaDF1aDV1QlN0K2IrNUJGT3FLRWVsdlZ6?=
 =?utf-8?B?NHBHZXE1akRFWDl2WkFBUjhMekQwcVBrc01RUXJDSmVUNnY5OFBLb2J0SUJu?=
 =?utf-8?Q?RiBYFf/6sDAF4KX0L8Rbbk75V?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dfc6c28-7d90-4c07-a55d-08daef3e6e4c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 17:01:04.4811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /rAm5OM0HeS2vpausXs96ySSNewvizO9Qkvk7oJT6AIW8UzwZtiSnrnMr5AAQrwe+aEIJXy9is1b5OZ7OTCS7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7795
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/01/23 21:23, Nathan Chancellor wrote:
> Clang warns:
>
>   sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
>           default:
>           ^~~~~~~
>   sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here
>           return ret;
>                  ^~~
>   sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning
>           int ret;
>                  ^
>                   = 0
>   1 error generated.
>
> Return -ENODEV, which matches the debug message's description of this block.
>
> Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic")
> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClangBuiltLinux%2Flinux%2Fissues%2F1779&data=05%7C01%7CVijendar.Mukunda%40amd.com%7Cad26656c3d2f4c75d00208daef350528%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085308267581104%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eeHVStOIOcy%2FdDISOKlGNeyEwx4i5AtJZmQ5dcNB7XQ%3D&reserved=0
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  sound/soc/amd/ps/pci-ps.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
> index 401cfd0036be..f54b9fd9c3ce 100644
> --- a/sound/soc/amd/ps/pci-ps.c
> +++ b/sound/soc/amd/ps/pci-ps.c
> @@ -217,6 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data
>  		break;
>  	default:
>  		dev_dbg(&pci->dev, "No PDM devices found\n");
> +		ret = -ENODEV;
ACP PCI driver supports different configurations. As per design , even  when no child dev
nodes are created , ACP driver probe should be successful. ACP PCI driver probe failure
causes power state transition failures when no child device nodes are created.
We should not return -ENODEV in this case.
return 0 is enough in this case. No need to de-init the ACP.


>  		goto de_init;
>  	}
>  
>
> ---
> base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46
> change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31
>
> Best regards,