Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp1289430rwl; Thu, 5 Jan 2023 11:17:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXv9OREQ9t7CGorwiw8dKj26n9yssm1GukP3RBmLX9Z6AQ4fJz7MrOML4sNkhjTeifGiyBUN X-Received: by 2002:a05:6a21:3a45:b0:9d:efbe:e607 with SMTP id zu5-20020a056a213a4500b0009defbee607mr62934401pzb.35.1672946249760; Thu, 05 Jan 2023 11:17:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672946249; cv=none; d=google.com; s=arc-20160816; b=yt3Yczkh6+ID98SqYDU+OmVXUF8xMJUXER6gkfyEJYt/f4RVP1+/wotadRwB2Kv4yF 6O4wJkAAPD6xZt3mIgW7R4fdcH1l1yEGLqc7m+cjtnMs/Ff4l9vDroz5SjM3UN8Qn8uh CT82GXwLlX/DpP5nzeSySNbqqCawqAvrsv0cna61qirG90om++qOdQVuu51wGb0WPB+O 7c9NU80mFn3d/Tp1FcD6oQS0i3LAa3erCgt0uju+lYxzkFuWFHkPzDFbsrxkLrWIvbuz 219saSFdZfLxp3HOSOPZrtgbU5FFiizzgxV28xky/Vb0v4E8pVzx8FuOQ5SvOqqPs1Iz Z9HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=poY51Fs8P479lkT26gVFN7NUe7X5yb9RO5F+VCbJlSs=; b=EjI3WrPrgG/+j9Rgb93p1wWr3fN4DhQijh8Ccg76ljrmhPoFk/EIUQXlfAJoDbvSA4 JKT4c666OxFQkKatoRDf23l4MySqYEQ9HOo1mZIR46uAGDc14VFr9kvHkepbtUU0EfZU sqmrev+xjw5XVI+u+cLr0EDlo4NnyxczReAwhSPgmjWPFdtnq3IYu0FNt56EcPLwLNib YNyO1s/62+il/XPJIA8cd3kW5xMONRXY7N2A2H+dI50DDq7rwkGpL1CPGl+1y8X/M9Vn kxTM5NO2+M71j2agb1C3xfZS6qNAIoF7wKyapqVfvxwJoRjBW7kzPa6v/fh4DbBUEqqB SCWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=lZJPOBYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f188-20020a636ac5000000b00461b7568ad2si39832538pgc.527.2023.01.05.11.17.22; Thu, 05 Jan 2023 11:17:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=lZJPOBYr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234866AbjAESzx (ORCPT + 55 others); Thu, 5 Jan 2023 13:55:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231165AbjAESzv (ORCPT ); Thu, 5 Jan 2023 13:55:51 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A729532EBF; Thu, 5 Jan 2023 10:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=poY51Fs8P479lkT26gVFN7NUe7X5yb9RO5F+VCbJlSs=; b=lZJPOBYr+39k4yQuD/8zEVwmbh cVQ7/9e7B4iUPz/lHPTlmVNuMy4Pw/qertSlqdUTTqrIfu2MrmqDA6MoY+KFtBtestvCdvCeAkou6 5HnGbl6NzkjoEp4zcnSbpUjpw00K9xhr7K57Yzfszlma6+MD/VuBYEi6+Z+BeoVLVfdhbaFj6x1G+ 0U2TFHIIY8Hx4oqBKR4zv9YnRAvy6Go/aMGeXtgAWzswVD5OZxGTAHp761oTYGuon00m4NQy7iXKo D3soMt5oa3+omRYiUTGF9E5HBr+pfRRT3KvBSjvonYDK/23bXnJS2OTIv3arrFGZYWtQ2Dg6w3BRm HgZ2Qcng==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35986) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDVP2-0007Rh-Qt; Thu, 05 Jan 2023 18:55:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pDVP1-0004Cv-LR; Thu, 05 Jan 2023 18:55:47 +0000 Date: Thu, 5 Jan 2023 18:55:47 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Sean Anderson , Andrew Lunn , Heiner Kallweit , netdev@vger.kernel.org, "David S . Miller" , Paolo Abeni , linux-kernel@vger.kernel.org, Jakub Kicinski , Eric Dumazet , Tim Harvey Subject: Re: [PATCH net-next v5 4/4] phy: aquantia: Determine rate adaptation support from registers Message-ID: References: <20230103220511.3378316-1-sean.anderson@seco.com> <20230103220511.3378316-5-sean.anderson@seco.com> <20230105140421.bqd2aed6du5mtxn4@skbuf> <6ffe6719-648c-36aa-74be-467c8db40531@seco.com> <20230105173445.72rvdt4etvteageq@skbuf> <3919acb9-04bb-0ca0-07b9-45e96c4dad10@seco.com> <20230105175206.h3nmvccnzml2xa5d@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105175206.h3nmvccnzml2xa5d@skbuf> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2023 at 07:52:06PM +0200, Vladimir Oltean wrote: > On Thu, Jan 05, 2023 at 12:43:47PM -0500, Sean Anderson wrote: > > Again, this is to comply with the existing API assumptions. The current > > code is buggy. Of course, another way around this is to modify the API. > > I have chosen this route because I don't have a situation like you > > described. But if support for that is important to you, I encourage you > > to refactor things. > > I don't think I'm aware of a practical situation like that either. > I remember seeing some S32G boards with Aquantia PHYs which use 2500BASE-X > for 2.5G and SGMII for <=1G, but that's about it in terms of protocol switching. 88x3310 can dynamically switch between 10GBASE-R, 5GBASE-R, 2500BASE-X and SGMII if rate adaption is not being used (and the rate adaption method it supports in non-MACSEC PHYs is only via increasing the IPG on the MAC... which currently no MAC driver supports.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!