Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bdd84dcd-3f3c-4ed6-2694-bb8252a9a266@seco.com>
Date:   Thu, 5 Jan 2023 14:10:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH net-next v5 4/4] phy: aquantia: Determine rate adaptation
 support from registers
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        "David S . Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Tim Harvey <tharvey@gateworks.com>
References: <20230103220511.3378316-1-sean.anderson@seco.com>
 <20230103220511.3378316-5-sean.anderson@seco.com>
 <20230105140421.bqd2aed6du5mtxn4@skbuf>
 <6ffe6719-648c-36aa-74be-467c8db40531@seco.com>
 <20230105173445.72rvdt4etvteageq@skbuf>
 <3919acb9-04bb-0ca0-07b9-45e96c4dad10@seco.com>
 <20230105175206.h3nmvccnzml2xa5d@skbuf>
 <Y7cdMyxap2hdPTec@shell.armlinux.org.uk>
 <18453c4e-484d-5131-36fe-77d3e55d6ac7@seco.com>
 <Y7cfqdVzrCNX6VqE@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <Y7cfqdVzrCNX6VqE@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTJYQ3g2MVFhSHpLTlgwNWpLbkh5SEVGQ3IxVzZmQURYN2lNNFZ3RDA5R2hs?=
 =?utf-8?B?SGRqTkR4TUhXOTlvS1IxSEVKYUl4akhGY2VyR1EvK1VDYUk3eURuWW1sbXQy?=
 =?utf-8?B?OGdVRnFlOWYzQTRSNXFxK0lCZi9KZms2S0RKenBtenRxNnFWeDYyRC91ZCt4?=
 =?utf-8?B?aHQ0RWpmbXhUQzdLRXY3T1IzT1IyZTRYMlBqcVgzQXFuSzFyU09CSE5qWjZl?=
 =?utf-8?B?ZlZzamdwbnZOM3NYMjBUV01BbEIwRThkMjgyK2M2SlpFNGRxNXVWTTBPNE5R?=
 =?utf-8?B?NDYxVGkwbENnTUlnOThlMG1EU3paTGF2YUhzNjN6R3VJRmdCL1ZyeWhqRldr?=
 =?utf-8?B?aW0wK240c1huSS9HUkZLbmt4RmhMSnN2OTUwUjVyV0h6eHhsM1BzUnBoVGM4?=
 =?utf-8?B?Q0g0dW9JT1htL0l1ZVN2dDE3NWR4RkZjNWh5Wm9tVTF4OGF5cUUxZXdqSFZU?=
 =?utf-8?B?Z3hLdVhCcHZ0SkkzcmFobHI4elcvTThWQ0FhMmI4dXI2OW01K250WlZZUjZz?=
 =?utf-8?B?TC9tblZKUGczNTdiV09IM1BCZmY0SithbmFTODM4Q0JpWU9XYkdnQ0lJTnBk?=
 =?utf-8?B?dHErV2xVd1lWTEFxYWJraktTang1UlVlQjllRFFpaWpUekZJQTN6QXR1NVhE?=
 =?utf-8?B?bXdremZ4aGx2NG92dkp3a2ZMVmwxZXdwVEtUYnp4MGlUZ1dwT2hLT0RlQ25Y?=
 =?utf-8?B?ejR6VFZ2bDN6OWJWTVVuUVo3UGMrN1hzNUpsYVozSCtEaytKT1dleWNsQlQ2?=
 =?utf-8?B?UnJKR2xrYWp1cVhDVmxjeFBCNUR3dk5iOVFXOEVTTlA5NWlLSWNKc21raHR6?=
 =?utf-8?B?ZDJrd3lrc1JUSDdtdkhJV1dtcSthRCt1amcyZEEyTWNNZi85bEtuMjYzSjgw?=
 =?utf-8?B?Q3VxbEVLRmhQeVZQLy9vQVV1ZDZEeXhEenU5OThoeUc2b2pLdm8wVDEzNEJl?=
 =?utf-8?B?NFBMSjBveWRpM3g1QnNFTDBhOW9SMy8zdWpkWXg0Z0UwUzVXekRrbGJzbng0?=
 =?utf-8?B?VjEvc01rUkhCU1JsWkc3emJvdkllb3ZqSHNaTnpLRnZVNmFzY0tLekZJdFUv?=
 =?utf-8?B?V3hYbzdNTGFRUkNLNGZRK2xPRE1DNytLZ3d6alFqQlhyc3BrL01NcVcwQ3Vo?=
 =?utf-8?B?SUNUVmthOCtPcmlvbmdGRlZ2dm1vY2tJVmVEL3BXUm41b3JOdzFHWXNkdDlZ?=
 =?utf-8?B?VWpkQ1V6akc4OXE4M281b3VraDdiVUtoLzVKdkZVeTJRNFdXQ0ZLTkxMZWxC?=
 =?utf-8?B?M1pCRnJNQ085U3VOV29XcjFDUXdXNTllNVlBZDg3b004dnFWWmZmdXMvUThP?=
 =?utf-8?B?aGlwTDlXWlcxcjh0eDFnTlN2aVU1TWxOVHB5MjRSZWU3N2ovanlqWUc5S3dx?=
 =?utf-8?B?dlJFM2xCUTNyR0JnMTJ5WkMyaXRJcU9JZnVHV09pdis5UzFpdzBoRzNIVVNS?=
 =?utf-8?B?cFlTK0JOT0dUYTRDOGJhOXRpOFpSRE8zK1lPTGdiQ1hISTQ5dXhNbFlQNFZy?=
 =?utf-8?B?L3VBYytZdjQ0QmlidU4wT2pmQ3hXTmNDcGhqRW9GSy9zL3FNZnZmbVVWMVNU?=
 =?utf-8?B?L3BqMUhnYUFaUEJzTWxidEJRakpJQVVseGl5ZE5jSFN4VmZNVmdjdVhDYjFh?=
 =?utf-8?B?RWFxMWlrT29nMVFZL0kzVndyV24rQ3h4RXJqeWExdGxDeGJlSFlOTXJRWURB?=
 =?utf-8?B?WS9kVlYzaTA5cUpzMEgxM0pJcnJNU25pS0tmTS9peGdQVUhFTWc2ZVBoTUd5?=
 =?utf-8?B?K0lYS0x5WkxScFY4TGVXTWVTc29iRVlQUjB1aThCcWR6dHQ5RWFHUkV3Y3Ax?=
 =?utf-8?B?VlBFTHY0STFpOFVzRktxVFlQY21vK29YL3p5Uytwbkw5N1lxR2xBYkxzTnRt?=
 =?utf-8?B?THJUWHVCTFR4cmF6aVd5UjJyNUg0UlUvbisxWlZNZ29IS2tycWltVVd4cGhk?=
 =?utf-8?B?UDlJLzZKdkR4UWV5anV5ZFlid0tQZWRGalZMZU92Z05KdlE2cXRkdkhHakll?=
 =?utf-8?B?ZnliTG5CT2dOaG1TMGxYM204SDlmMGJFUmF2SGFlZWtFd25QaFZzYkQ3VnRE?=
 =?utf-8?B?ZnJpSEx4VlYwTDN2NjQrY0dUMDBYLzl0N3Jyc3hyQTFWR2htM0hOVWxVTFMz?=
 =?utf-8?B?RnJMV3hEUk5uUFhXZUhUTW1LeE9MWmJTeWFDKzYyV1VDTWFYeDNzL25vMW83?=
 =?utf-8?B?RFE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45f93091-63ad-4f7b-e558-08daef507988
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 19:10:14.3189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GXIqXaAH8BtkobDEztl6eFC+wdbzw4yxN3Fp7K6EwjJ+0Q/kqQQa3ciqKIFxihtuJ3Pcwo+JrAcr080dfxRMxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR03MB6551
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/5/23 14:06, Russell King (Oracle) wrote:
> On Thu, Jan 05, 2023 at 01:59:27PM -0500, Sean Anderson wrote:
>> On 1/5/23 13:55, Russell King (Oracle) wrote:
>> > On Thu, Jan 05, 2023 at 07:52:06PM +0200, Vladimir Oltean wrote:
>> >> On Thu, Jan 05, 2023 at 12:43:47PM -0500, Sean Anderson wrote:
>> >> > Again, this is to comply with the existing API assumptions. The current
>> >> > code is buggy. Of course, another way around this is to modify the API.
>> >> > I have chosen this route because I don't have a situation like you
>> >> > described. But if support for that is important to you, I encourage you
>> >> > to refactor things.
>> >> 
>> >> I don't think I'm aware of a practical situation like that either.
>> >> I remember seeing some S32G boards with Aquantia PHYs which use 2500BASE-X
>> >> for 2.5G and SGMII for <=1G, but that's about it in terms of protocol switching.
>> > 
>> > 88x3310 can dynamically switch between 10GBASE-R, 5GBASE-R, 2500BASE-X
>> > and SGMII if rate adaption is not being used (and the rate adaption
>> > method it supports in non-MACSEC PHYs is only via increasing the IPG on
>> > the MAC... which currently no MAC driver supports.)
>> > 
>> 
>> As an aside, do you know of any MACs which support open-loop rate
>> matching to below ~95% of the line rate (the amount necessary for
>> 10GBASE-W)?
> 
> I'm afraid I haven't paid too much attention to BASE-W, and I'm not
> aware of anything within the realms of phylink/phylib supporting MAC
> drivers having anything for it. I don't even remember mention of it
> in any SoC datasheets.

The mEMAC supports "WAN mode" which does open-loop rate matching, but
it can really only adapt down to 9.5 GBit/s or so.

> Are you aware of a 10GBASE-W setup?

No.

--Sean