Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp1349101rwl; Thu, 5 Jan 2023 12:13:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXt8X/2ISLgJ2z61GuYef9lx3ugtIAu0OkY2gP+XPsXM+rFNT9x2aZPLT8gokS9SZfG71+Lf X-Received: by 2002:a50:d616:0:b0:47c:6ed2:43d1 with SMTP id x22-20020a50d616000000b0047c6ed243d1mr48091112edi.30.1672949628302; Thu, 05 Jan 2023 12:13:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672949628; cv=none; d=google.com; s=arc-20160816; b=t1xSJNWPkoxr3HJGdsGgDYwFj4IBFgdTj8V/WL5MK5zXmdO4KT8zt5m9nEuerrIDLe iYFgwm6Wctlvyky4Ld8Jo6gVF8+GFw4IxkplKXkSZNbgVtwipdcVb47qL47QJ8ADRqSQ frlDUpLj7gDyXqdaufY6H/WCS0VlG7oaEhKwzvT/5mKiggloR5kgyfuknFH61ALjRnym TkM7pMXCIDGXLQTS2v4cNN1vHa6FcCTzDFjuu+v2HGddtbcSadbTfiSjuPvr6lJHpz3+ DCa2QvBVEsQ4R7vm598fydgFoTsrts8OK4J46QCv9ofTcFXkJHYfGAVnG86Yzi3weBYJ 1UFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ixGY7io/rE5K6EAUf3CTJ6PelTCXFqcbJYe+h11qlvs=; b=thWgGXUs8gk9Vc8wnYoYotp1dkgjpARfm7kYL7vbvLPRqRn4vnmNNgDFxNtGgZjJ3T GAJ4js6lyzvUvD8hf1/GtviA7J5CoOzsp79zMEihwvJPvQ0I6J3sBuVbvqc8/Inx9YJI vDZtjnstGJOmoHOOmRvm7sK107X4ai8qPSe5+Bm7SH/q+sDQyfZzD9wnyJw625GNBhgN BYCm2cdlDGVVkhH3cf2cdL4pFwpPdWyfCzJviI7hThMgeebwatyk2Smo+o9l4JT5MA7w MqXTTZ+TFRJjBu8uYVOc8/Dc4B6S046i9K5I+zDOtXnz6mZl+MLda+pi+15yPdfWtvKj 3ZIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="HX8w/kUt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h14-20020a05640250ce00b004841a568226si33181782edb.476.2023.01.05.12.13.35; Thu, 05 Jan 2023 12:13:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="HX8w/kUt"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235337AbjAETG2 (ORCPT + 55 others); Thu, 5 Jan 2023 14:06:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235437AbjAETGX (ORCPT ); Thu, 5 Jan 2023 14:06:23 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D4311B; Thu, 5 Jan 2023 11:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ixGY7io/rE5K6EAUf3CTJ6PelTCXFqcbJYe+h11qlvs=; b=HX8w/kUto03BZlvL5JJrZfMEVo PW0Hpcy/xdauC8tMOg2C9pcBM1XxQDdf5CWRQhrEn0o9q6NY9CYhWHH17IuOyQSROIs76ZgDCt0TI vOPnL5BUXO4XqtS4Y8SzLqz6gUtzgvXTHmTZV7pjOGL8JiNgmuNjJAwr26iRbqRWD96mDGa7GQMes tSlmJs52ReE8yfjCP4bd+hysHn5WRTUbkyjPvNNetEH97zvalJHE1nJMj0zH251DNjzlfSLvAincy GvppPWra6aXfhu19vCQgZsSy7qCnI4U0PX/cZEoCXQX5WCQbjui2qAoWBgnBWYm5mXtLCgLEYVgtp rxjRwVeA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35992) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDVZD-0007TX-Ou; Thu, 05 Jan 2023 19:06:19 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pDVZB-0004DV-VE; Thu, 05 Jan 2023 19:06:17 +0000 Date: Thu, 5 Jan 2023 19:06:17 +0000 From: "Russell King (Oracle)" To: Sean Anderson Cc: Vladimir Oltean , Andrew Lunn , Heiner Kallweit , netdev@vger.kernel.org, "David S . Miller" , Paolo Abeni , linux-kernel@vger.kernel.org, Jakub Kicinski , Eric Dumazet , Tim Harvey Subject: Re: [PATCH net-next v5 4/4] phy: aquantia: Determine rate adaptation support from registers Message-ID: References: <20230103220511.3378316-1-sean.anderson@seco.com> <20230103220511.3378316-5-sean.anderson@seco.com> <20230105140421.bqd2aed6du5mtxn4@skbuf> <6ffe6719-648c-36aa-74be-467c8db40531@seco.com> <20230105173445.72rvdt4etvteageq@skbuf> <3919acb9-04bb-0ca0-07b9-45e96c4dad10@seco.com> <20230105175206.h3nmvccnzml2xa5d@skbuf> <18453c4e-484d-5131-36fe-77d3e55d6ac7@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18453c4e-484d-5131-36fe-77d3e55d6ac7@seco.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2023 at 01:59:27PM -0500, Sean Anderson wrote: > On 1/5/23 13:55, Russell King (Oracle) wrote: > > On Thu, Jan 05, 2023 at 07:52:06PM +0200, Vladimir Oltean wrote: > >> On Thu, Jan 05, 2023 at 12:43:47PM -0500, Sean Anderson wrote: > >> > Again, this is to comply with the existing API assumptions. The current > >> > code is buggy. Of course, another way around this is to modify the API. > >> > I have chosen this route because I don't have a situation like you > >> > described. But if support for that is important to you, I encourage you > >> > to refactor things. > >> > >> I don't think I'm aware of a practical situation like that either. > >> I remember seeing some S32G boards with Aquantia PHYs which use 2500BASE-X > >> for 2.5G and SGMII for <=1G, but that's about it in terms of protocol switching. > > > > 88x3310 can dynamically switch between 10GBASE-R, 5GBASE-R, 2500BASE-X > > and SGMII if rate adaption is not being used (and the rate adaption > > method it supports in non-MACSEC PHYs is only via increasing the IPG on > > the MAC... which currently no MAC driver supports.) > > > > As an aside, do you know of any MACs which support open-loop rate > matching to below ~95% of the line rate (the amount necessary for > 10GBASE-W)? I'm afraid I haven't paid too much attention to BASE-W, and I'm not aware of anything within the realms of phylink/phylib supporting MAC drivers having anything for it. I don't even remember mention of it in any SoC datasheets. Are you aware of a 10GBASE-W setup? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!