Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 11:44:28 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "Luck, Tony" <tony.luck@intel.com>
CC:     "Liang, Kan" <kan.liang@linux.intel.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "kernelorg@undead.fr" <kernelorg@undead.fr>,
        "kjhambrick@gmail.com" <kjhambrick@gmail.com>,
        "2lprbe78@duck.com" <2lprbe78@duck.com>,
        "nicholas.johnson-opensource@outlook.com.au" 
        <nicholas.johnson-opensource@outlook.com.au>,
        "benoitg@coeus.ca" <benoitg@coeus.ca>,
        "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "wse@tuxedocomputers.com" <wse@tuxedocomputers.com>,
        "mumblingdrunkard@protonmail.com" <mumblingdrunkard@protonmail.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Box, David E" <david.e.box@intel.com>,
        "Sun, Yunying" <yunying.sun@intel.com>
Subject: Re: Bug report: the extended PCI config space is missed with 6.2-rc2
Message-ID: <63b7289cb7439_5174129445@dwillia2-xfh.jf.intel.com.notmuch>
References: <SJ1PR11MB6083C504335B2DE1B31C440CFCFA9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20230105182950.GA1158496@bhelgaas>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230105182950.GA1158496@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aah7PS6aJXLGNgof43wV+mn15/vcQ/s5afhUQbnjFIKtEB++x1AkL/KHvPaK?=
 =?us-ascii?Q?KrTH1tpP/tty5voQeWz6N//yt6/2SC0G5UMf9c5LuhKcyonhYg+qP0/kUjAe?=
 =?us-ascii?Q?KLuKFEerBv8DdXMZIyUOGqJ/CRDJidDBvjzZ/lYP19j7LivZEggvtp3Nil43?=
 =?us-ascii?Q?vP1klhSvAD2dEMHo2BJfU1Kks9ryowKhs9lDfyvdUJGOJrgqj83yR21EwMXQ?=
 =?us-ascii?Q?T0BFFb6Mc9fkLYbfb65kiFNuMkiojnq+jOOkmnQlC6g94rs3iv3UNLrxPllN?=
 =?us-ascii?Q?zRmSbSM0X1KdTFp7SdvaoEOqGigDOAU8lZH7GQTfFEHKdlvnPVFzVQmk5vOw?=
 =?us-ascii?Q?WLRYDONHz/fUt0fcYzhAC3E4AyY47vteta7P7X5/XU/be/0pxdtJ9+KlmpJ9?=
 =?us-ascii?Q?vXKfg5tKxkX56Mrt87T/L05Kk+Vzs1Im3+/yAtWQczbZY99qVwzl02g4umEm?=
 =?us-ascii?Q?f69t+ZBWE3f8/qgxoLTfn2U3UPEFzQLtFUsCMulgCfxcysZDXneCxVYLZ7nu?=
 =?us-ascii?Q?LxRR2c4J+zdNhLYt/no3Cujc6pFOF+xQhD7yIDdf2NR8Kos9qK2pmuPgsikh?=
 =?us-ascii?Q?as7tiPvpKUjvGEJ8Bpio+dAj0PYsXoofKNWFKDwAvqvy/VApAz3gU5+9BU4j?=
 =?us-ascii?Q?4QJU7c0fzZBvtJPv26PBBEZLpDg7S9C3R0U3L8QHcozd6Wst3UwNYrSJ0zit?=
 =?us-ascii?Q?QTkDYeuxlUhXBGgnrCOa8HV5k1loeSnLn7LL74BwExQuPM+HGpW5srj+1pX+?=
 =?us-ascii?Q?Xypp+MRTXwxr+25x1X57lRZGez2VRJ0ZTNHimnG8FO+F91xaV2QnpJaGXONC?=
 =?us-ascii?Q?6Yy9iL7QniPClMwx6cHMgoRg3Np3fowqEn/tIMXC0RoD6clgCvK8+BtCKDgM?=
 =?us-ascii?Q?4maVDx/2i3K0X+OFCJHZK3LcUf6TZgv6Dw+XG8UsO7DYne1ewBLXYn8+KOCI?=
 =?us-ascii?Q?5PGB7ujFUuSPBK2Ks/B2/iM+HvPZMU0bIVdvguD5KW+oOD+Et6QcOr6XMYQI?=
 =?us-ascii?Q?YtKExATnH9qXlq9K07oglqSkDOfhWHWoBB5W6KNeWmwNFN5rbZ/qRQF0vK8n?=
 =?us-ascii?Q?a6P3ksKsejKYc2ed+yAWmGLt3I8HRN2pREbpP2rg5XL8Z0Kx2asI4ru8yFBn?=
 =?us-ascii?Q?GuCT6T3OT/shf2kVazQCHJKoXBnGSIhTYNJwfp55Xd1pG01YNrxyoU5uHF0Q?=
 =?us-ascii?Q?t6dLHBXEgPBT/bYImRBNFEW/k3rPw9irjrUYl39ty09a3ue+wYSHRzLVUk5C?=
 =?us-ascii?Q?KXAvz8LD4tcIKnXl+ZkX4h4FNXP6rrvuLqTE1y1nXx0E2Wer7fxyCZ/axrra?=
 =?us-ascii?Q?xNGrDGdYFLTafsDy4nCwvjMXsk6fb+Vxa7ScJXcxmC9ZpXW+D9HXrn8tT8K6?=
 =?us-ascii?Q?nZm9sFMxEAoNjNaFcX58BsH7msceff6YUt04ZPit+LKPm2UsX7Z4guxuoB3R?=
 =?us-ascii?Q?WgRgH5vH2NHNZCCmlJLNE6EAMLGwCdgqDS53uMvfa49ldroeajJXotILu6oP?=
 =?us-ascii?Q?fujYMRXDurCghhDqjKa91yhpSUW+AuDM7ut+TJlo8/N3Om/ATE4y9xhkYLse?=
 =?us-ascii?Q?Rie9xLBPEnE65pIMbOF+nmw6RB6DPSITQFthH1Py5x6A1VfD+jDUSSS9xrx+?=
 =?us-ascii?Q?7A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07f74010-0172-4373-8c1b-08daef5543ed
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 19:44:31.9902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 54ONQkSPaf3MVjfcxx6cLLlNJIIOlh20Fb4aRFZFnPpU+c4cy0aXvzbGDnBY/JTdSMEjGvo5ynm6YB5+mHDTO++J5tFj5bXsC8h1MHf5qNg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5544
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Bjorn Helgaas wrote:
> On Thu, Jan 05, 2023 at 06:04:52PM +0000, Luck, Tony wrote:
> > > Hi Tony, can you share a dmesg log?  Does it look like the same thing
> > > Kan reported, where the ECAM space is reported only via an
> > > EfiMemoryMappedIO region and is not otherwise reserved by firmware?
> > 
> > Attached are serial logs. "broken" is the one from v6.2-rc2, "revert" is the
> > one with your commit reverted.
> > 
> > I don't see the string "ECAM" in either of them.
> 
> Yeah, "ECAM" is what the PCIe spec calls it, but Linux logging uses
> "MMCONFIG".  Probably should change that.
> 
> Anyway, your dmesg log shows the same problem:
> 
>   DMI: Intel Corporation BRICKLAND/BRICKLAND, BIOS BRBDXSD1.86B.0338.V01.1603162127 03/16/2016
>   efi: Remove mem48: MMIO range=[0x80000000-0x8fffffff] (256MB) from e820 map
>   PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000)
>   [Firmware Info]: PCI: MMCONFIG at [mem 0x80000000-0x8fffffff] not reserved in ACPI motherboard resources
>   PCI: not using MMCONFIG
>   acpi PNP0A03:00: fail to add MMCONFIG information, can't access extended configuration space under this bridge
> 
> Apparently the only mention of [mem 0x80000000-0x8fffffff] in the
> firmware/kernel interface is as an EfiMemoryMappedIO region.
> 
> I think this is a firmware bug, but obviously we're going to have to
> figure out a way around it.

Definitely an ambiguity / conflict, but not sure it is a bug when you
look at from the perspective of how would an EFI runtime service use
ECAM/MMCONFIG space? 

Would it be enough to add this clarification in "EFI 2.9 Table 7-6
Memory Type Usage after ExitBootServices()"?

s/This memory is not used by the OS./This memory is not used by the OS,
unless ACPI declares it for another puporse./