Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9841589c-757e-ea01-0c55-abe4a38fae03@intel.com>
Date:   Thu, 5 Jan 2023 23:31:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
From:   Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH V6 22/24] mmc: sdhci-uhs2: add post-mmc_attach_sd hook
To:     Victor Shih <victorshihgli@gmail.com>, ulf.hansson@linaro.org
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw,
        Greg.tu@genesyslogic.com.tw, takahiro.akashi@linaro.org,
        dlunev@chromium.org, Victor Shih <victor.shih@genesyslogic.com.tw>,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>
References: <20221213090047.3805-1-victor.shih@genesyslogic.com.tw>
 <20221213090047.3805-23-victor.shih@genesyslogic.com.tw>
Content-Language: en-US
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20221213090047.3805-23-victor.shih@genesyslogic.com.tw>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/12/22 11:00, Victor Shih wrote:
> From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> 
> This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required
> to enable UHS-II support, at least, on GL9755.
> 
> Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  drivers/mmc/host/sdhci.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index e5f64b38e339..4aac22b58d79 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -728,6 +728,7 @@ struct sdhci_ops {
>  	void    (*dump_vendor_regs)(struct sdhci_host *host);
>  	void	(*dump_uhs2_regs)(struct sdhci_host *host);
>  	void    (*uhs2_pre_detect_init)(struct sdhci_host *host);
> +	void    (*uhs2_post_attach_sd)(struct sdhci_host *host);

This gets called already in "mmc: sdhci-uhs2: add uhs2_control()
to initialise the interface"

Either move that line to this patch or vice versa.

Please check compiling after each patch is applied.

>  };
>  
>  #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS