Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 Jan 2023 14:14:52 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Kees Cook <keescook@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     Kees Cook <keescook@chromium.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Alex Sierra <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Shiyang Ruan <ruansy.fnst@fujitsu.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        <linux-mm@kvack.org>, Alistair Popple <apopple@nvidia.com>,
        Joao Martins <joao.m.martins@oracle.com>,
        Mike Rapoport <rppt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
Subject: RE: [PATCH] memremap: Replace 0-length array with flexible array
Message-ID: <63b74bdc9a6e0_c81f029445@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230105220151.never.343-kees@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230105220151.never.343-kees@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z06wMsH8OMCV12rjL6iTOEvgy3eUWLUZD5hP6ejr3viexLTpJzsTjfxcp9lU?=
 =?us-ascii?Q?mGcLNfkyjFiQaIt9pJFPZ+7KLlvc7Ay6Ya5ogQwPex8C3sIu0ZEcH/QG8tlV?=
 =?us-ascii?Q?aXf8OwCTBPYLy6S9lWgax+CU9uRte2Q8trvDML1iw4lzsNHutzwWSXQCgQ24?=
 =?us-ascii?Q?mbwQTrd+pRb8fdvtynRP9M8nsjjizpkSEWu42br0Dt5+J1dlUFkfnm9u3eUR?=
 =?us-ascii?Q?UJ4m7z/r3o3maWaeVNDcGvXqwI4hXWe7BDdIpZuS9dH+sjXWAT0QvPaD9oJ9?=
 =?us-ascii?Q?j5SMpPQUv4yRSiJ8/iffAF/y3Hg79SR0rRtAxGb3xdr6ONZTRPyzRtqnpZLO?=
 =?us-ascii?Q?w6hNjiLHKiCyI3UGyTXTkMwjAisq9iA03p4pDp7yog1I0dw661+rrkRD7LXF?=
 =?us-ascii?Q?B0/9trXXp1iSUnia+4nPDj5GEri+LcklHGh2q+nl/GrvPtKAC+gx7+ru1RC1?=
 =?us-ascii?Q?Zk2Tysa8yoRFXTzDJ9wRpt5NW9PmZpONrDBDsdNzEhPxEuiXRYUuaiVWDFjG?=
 =?us-ascii?Q?XRFAJ/SqvfF6y+xgIN7AFWlYvxMmolaECWXWEyaH+r4O9UKlWO6apXo36GyX?=
 =?us-ascii?Q?7IVvJWWXDzbUuO9m3Ppnj1Ieo1yl7ePRMHS7lGKd6OVD9gu0Pc/pFIWRilO1?=
 =?us-ascii?Q?bn8hfh/VFrO8MSF68jZmA9/AvzLv2E4erOeWOJdR2MaVrSBEzU6JBkBj9ZEn?=
 =?us-ascii?Q?5zoG7dSL7woO1NoEGHGYCRVwiqGG/Bqe8ucSbUZwNY50dzWbRSaAg7YR3Am3?=
 =?us-ascii?Q?8muRdqrs+KvXgZsWvfFNX0pOUVr1Md18onZWDeq+fukWjGNrpM/SgeWJoPi+?=
 =?us-ascii?Q?lUZ8EVILPQXIqyaS/DTcRNfEayVgUoOig5r+BGf0e5PgPutEB5CM6c0kn61A?=
 =?us-ascii?Q?X01wvTkiXk0vBN9EsFEnTgstUTau3hBGEqTYb4jTgrYVZbCu8/TzPUBQcYtd?=
 =?us-ascii?Q?M13wasOrGbZ6yZLC25hQpD9Y+gRwaCXm+ZF3n5aCw7K4t1hWNP0O7s/QgaBi?=
 =?us-ascii?Q?hxjWCGL7Vjx5IYipJQxZzfQySycmYqElUA3kSkLyWvu+31HDqK/cABLuU3ad?=
 =?us-ascii?Q?CVN1eWcyhab/1oJpcpM9sYB+MKlfBKAS/nfEsKCWjxmae/c8t8Wwx1z4/QJG?=
 =?us-ascii?Q?nCM1ogGm+Rd1/lht3WrJ5dG1UUAzJqlPTwov8bplEolD+mrg9MNpuEhRLozD?=
 =?us-ascii?Q?e8T1AnfCcm+MoePJZBdYnWoET04JDMHj13YtUnMof3RtuiKHTuA4WQWPfL3G?=
 =?us-ascii?Q?D9CrklVp21HSuq9j65fIVcIOj1ILIE9uIChkV8oij3aDyb3RdvumjsHtMv+c?=
 =?us-ascii?Q?x6gZMVDoQ7+CJeYhIZilfuEyQi/teUrCHeB9gdNi+loLNseM5hDxqTNTVdJc?=
 =?us-ascii?Q?sU2QNpXqn8D2vfWisg9bq7pZ87LjlH55kKXAvHSFCDdsiUnm4/laRn6wTSrZ?=
 =?us-ascii?Q?Xwc62pEeEHjXgQeCKufECPxgfKiog6W7F/R4OlAn8c1D+I/FXo2eYYEg4mtR?=
 =?us-ascii?Q?zU3YLBQttrFgpcT9WnnqHyvM6ToM4rluDT+SRTaXVVDFHTlgMCBBI1AjxdF1?=
 =?us-ascii?Q?UN+aiJnyDjdjDRHCnf48OAtOj4uUc84khDwpIyk+d61m8CvjMLtLNQ3OG3Cf?=
 =?us-ascii?Q?iQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85e6504b-7263-4d87-bfc6-08daef6a4654
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 22:14:55.3752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fh1gxPEErSKpVuSxsBhaw5/0DoKQtmHeRUbioRXyzzpwB7OVJIPy7x6su2qnJ8Vr2ZzGmu94d+hCNyF1T1nY3AY1A/M06xFDg+xJlTnRCTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct ethtool_rxnfc's
> "rule_locs" 0-length array with a flexible array. Detected with GCC 13,
> using -fstrict-flex-arrays=3:
> 
> In file included from include/asm-generic/memory_model.h:5,
>                  from arch/x86/include/asm/page.h:86,
>                  from arch/x86/include/asm/thread_info.h:12,
>                  from include/linux/thread_info.h:60,
>                  from arch/x86/include/asm/preempt.h:9,
>                  from include/linux/preempt.h:78,
>                  from include/linux/spinlock.h:56,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:7,
>                  from include/linux/mm.h:7,
>                  from mm/sparse-vmemmap.c:21:
> In function 'reuse_compound_section',
>     inlined from 'vmemmap_populate_compound_pages' at mm/sparse-vmemmap.c:407:6,
>     inlined from '__populate_section_memmap' at mm/sparse-vmemmap.c:463:7:
> mm/sparse-vmemmap.c:376:39: warning: array subscript <unknown> is outside array bounds of 'struct range[0]' [-Warray-bounds=]
>   376 |                 PHYS_PFN(pgmap->ranges[pgmap->nr_range].start);
>       |                          ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
> include/linux/pfn.h:22:43: note: in definition of macro 'PHYS_PFN'
>    22 | #define PHYS_PFN(x)     ((unsigned long)((x) >> PAGE_SHIFT))
>       |                                           ^
> In file included from include/linux/mm.h:31:
> include/linux/memremap.h: In function '__populate_section_memmap':
> include/linux/memremap.h:138:30: note: while referencing 'ranges'
>   138 |                 struct range ranges[0];
>       |                              ^~~~~~
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Alex Sierra <alex.sierra@amd.com>
> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> Cc: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: linux-mm@kvack.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Looks good to me:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

> ---
>  include/linux/memremap.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
> index 7fcaf3180a5b..1314d9c5f05b 100644
> --- a/include/linux/memremap.h
> +++ b/include/linux/memremap.h
> @@ -135,7 +135,7 @@ struct dev_pagemap {
>  	int nr_range;
>  	union {
>  		struct range range;
> -		struct range ranges[0];
> +		DECLARE_FLEX_ARRAY(struct range, ranges);
>  	};
>  };
>  
> -- 
> 2.34.1
>