Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e57369d9-e4ab-365e-2d59-4a5f46d65283@amd.com>
Date:   Fri, 6 Jan 2023 05:09:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] ASoC: amd: ps: Fix uninitialized ret in
 create_acp64_platform_devs()
Content-Language: en-US
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, Syed.SabaKareem@amd.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
References: <20230105-wsometimes-uninitialized-pci-ps-c-v1-1-4022fd077959@kernel.org>
 <6bb126b7-1cb4-0c4c-d357-fadc3ffdd3f9@amd.com>
 <Y7cEra00F9PeFFcx@dev-arch.thelio-3990X>
 <Y7cKHZL8e+rfR66a@dev-arch.thelio-3990X>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <Y7cKHZL8e+rfR66a@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE8wdmw3cG4yVE5SRkVTa0RGa3lRdmNsOUs4eVA2OGJkZE82VUZpakE4U1Yz?=
 =?utf-8?B?di9yMHI0bjI0MmtXZG12aGZScE5kUVI1em0yVk1lWEw1QmxhdnhjL3pqT2o2?=
 =?utf-8?B?dVdwaDdpMkRjMXRuQjNTRVN0OC8yTHhZL1RjVVFVUmlqTkVOZmd0TkZ6UWx2?=
 =?utf-8?B?ckRObXBDYmd5Vk14Tm9FQ1FDVTZ1b1E2cDJ6Z0gvRENnbDcrQXhkTFBrSXlP?=
 =?utf-8?B?TitXcE0weDZwa1VPVkthS0o3NWVqOXlSRHp4VnNhdXhxRVlEZ1FkQ0YzWW80?=
 =?utf-8?B?dmVFTlV5Qk9NVExJSXQzMGxmRjI2dUhtT0o1azlTTzNmWlRrams5OHFRN0VD?=
 =?utf-8?B?eFIwUDAvNnZmS3V1QllBYlJCbFQ4cFNSdmRpNjNtOGlySG5nSkFRUnN0b2tr?=
 =?utf-8?B?TVk5UTZMVWRJWU0rZCs5dnBXcDNMR3RId0F6MGpwd3dTUm9sTisrN1lZSHA1?=
 =?utf-8?B?UndzOFc3UytsbVV2VWx3TVNabGhXejlxcnc1UFNGeUczNEszV1FlUUZZSlB4?=
 =?utf-8?B?K0xoYzdBZzN6V2hZT0R2b1ltaUI3RURDUzVtUEVIOUVGbFFyRW9lRm15bHIr?=
 =?utf-8?B?UzVOR0FqNUYybUIrblhRa203d3hvMmVKcnpVZ2JpcUNZWUdudmJBUnV0K1J6?=
 =?utf-8?B?UzIrNXZUeEdOYkhWZWcvVXJLbW1QaTY2U0VlK2xHRndnNHhEV3BIb3ozL3dz?=
 =?utf-8?B?NWVnS1E2OHBiNjV1YVc3WlZEejF2bmROektQSGdCM2hEZFNZMlcxNUFIK2V3?=
 =?utf-8?B?bTlPdEZwVVZ1eE9VVTMxOVRCeFZSU0k1K1ZPKzJwb0I3Nlk3VzVkNUs0Um5v?=
 =?utf-8?B?Qmk5Y1Fwc1VHMUxWTzVVSFNSK2dNQjFERjduQ2t5eXFVMmpLbVQ5czhXMXdC?=
 =?utf-8?B?ZGhENUNzc2x0bUJPZ21UbEk3MmhCdW9GNEhITTN6MFZmOW8zOFBCellyUnBp?=
 =?utf-8?B?RU03MmFSTERJOWZsOUluaUtJMVo2QVVUTVR4YlovLzRaOUQ1SG5YdmtBeDZn?=
 =?utf-8?B?T1c5WFNZUVlhMG1VY0hadWY5MTVpR0NrNlpIdFgwOU85Tm9mQkUxd2dSZ3h3?=
 =?utf-8?B?QWY2MFRNWGRiSldjeVFxMEUrdTgrYlhLSDVtNG1aVHlHd1VmK2gvbDYwYjd1?=
 =?utf-8?B?cXBoWG41NklpL0EwdWVqeVI4aHFGZ3JEMEZmNmFZbzdlNEpaOFFnRTMrYjlx?=
 =?utf-8?B?SzRqbE85a2pUYUh6ZG5NNGZ2aWljUWpkVElhQnVMU0xDMWZsWHN1bllxYS83?=
 =?utf-8?B?cHBITDdvU0NHbTlvMTNHOVZhejJpbFNzb1pyZXZaeUU1Unh6YnJ3WS9SU2Y2?=
 =?utf-8?B?Q1gycXpxaG5SNUNnT0FUVW8wOUg1aDBPVHhreXdVQWIrZXp2N1dQblplTFE0?=
 =?utf-8?B?cUxxWHlrdmlxM3hOWW9RQnVLbUVLZUxZYWtUL1kzUFpzZ2NGcmx2UUtPd053?=
 =?utf-8?B?RVpGb0RKN2t1V3JYYis4VHZISDdkeDUzbTQ2MlBGYVljb2h4S25wM1hWMjFZ?=
 =?utf-8?B?TS9jRDdySGFSRzNsVS81VU9CamxwR2tHWHhBMXUxcnpwZGhDVlZlcTFtdnpB?=
 =?utf-8?B?WjFqbG9DNHBoa0Ixb1JkTGovTE81ZGwwQnh5dXZZTlRWWmtUdkxEeERTZ0dh?=
 =?utf-8?B?RmM4Y0FWVnBsRmlQOStueWE5djRPd0pSc3R3ZW4vdnN4cThBS3ZPNmJLR0FH?=
 =?utf-8?B?ZlFrVFhRSisrTWFod0c0eFdCbXRrTDFHYW80VVJ6ejN2Q0s4cDRiR0dUMlJE?=
 =?utf-8?B?YnFSMGVoQ3R3eUdpZFNuUVo2M0pPY3llUC9tT044YmI5cmNRRGF6TkFTTlht?=
 =?utf-8?B?eFd3VklwT3VuUDU4UlU0S01pY0Q1RzBZcGdBMHJRN0dETHBMMkZLT2pTL2t5?=
 =?utf-8?B?bk5FNERPMXdwTXc5Rkl0U1JtNENpY3BkMk1NV0ExY3U2MG9xcDVJQWJxRVps?=
 =?utf-8?B?d2ExK2dZNGN1VVBGUEtENnhwQ2pPOW9mdkIyUWtPaUcyQ2dXUUlmYW1DNGhV?=
 =?utf-8?B?V0QxdmFyZkpIMUR2RkRDK1FTR3pHak95a1Y0MUxhT3BVb0Z0dERqOS9zRkZC?=
 =?utf-8?B?UmlOYzdNVWlzYVNGVWV1K21JUE54ajQzUmdFSnIxQ2U0dEs2Wk5sT0g2WnBP?=
 =?utf-8?Q?l1Lr7/Qc+O4f5fzSwVop3EoZx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a4b54e-c371-4f07-4e62-08daef75aed8
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 23:36:35.4500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E14jIJPcZPzeFfBaWDbB9z9dg7nSY5N9fSz9ecdRcIzVFZlMN6v8EkY1SR6/nNtoja9RgHUnX59kPJvWUaHgEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5823
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/01/23 23:04, Nathan Chancellor wrote:
> On Thu, Jan 05, 2023 at 10:11:09AM -0700, Nathan Chancellor wrote:
>> On Thu, Jan 05, 2023 at 10:34:10PM +0530, Mukunda,Vijendar wrote:
>>> On 05/01/23 21:23, Nathan Chancellor wrote:
>>>> Clang warns:
>>>>
>>>>   sound/soc/amd/ps/pci-ps.c:218:2: error: variable 'ret' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
>>>>           default:
>>>>           ^~~~~~~
>>>>   sound/soc/amd/ps/pci-ps.c:239:9: note: uninitialized use occurs here
>>>>           return ret;
>>>>                  ^~~
>>>>   sound/soc/amd/ps/pci-ps.c:190:9: note: initialize the variable 'ret' to silence this warning
>>>>           int ret;
>>>>                  ^
>>>>                   = 0
>>>>   1 error generated.
>>>>
>>>> Return -ENODEV, which matches the debug message's description of this block.
>>>>
>>>> Fixes: 1d325cdaf7a2 ("ASoC: amd: ps: refactor platform device creation logic")
>>>> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FClangBuiltLinux%2Flinux%2Fissues%2F1779&data=05%7C01%7Cvijendar.mukunda%40amd.com%7Ce9133748553c4463824d08daef4317c1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638085368693977265%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nDmZXCJR%2Fwt%2FautwTwcZostLvRtUrEbYV2l7M2W%2FTD0%3D&reserved=0
>>>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>>>> ---
>>>>  sound/soc/amd/ps/pci-ps.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
>>>> index 401cfd0036be..f54b9fd9c3ce 100644
>>>> --- a/sound/soc/amd/ps/pci-ps.c
>>>> +++ b/sound/soc/amd/ps/pci-ps.c
>>>> @@ -217,6 +217,7 @@ static int create_acp63_platform_devs(struct pci_dev *pci, struct acp63_dev_data
>>>>  		break;
>>>>  	default:
>>>>  		dev_dbg(&pci->dev, "No PDM devices found\n");
>>>> +		ret = -ENODEV;
>>> ACP PCI driver supports different configurations. As per design , even  when no child dev
>>> nodes are created , ACP driver probe should be successful. ACP PCI driver probe failure
>>> causes power state transition failures when no child device nodes are created.
>>> We should not return -ENODEV in this case.
>>> return 0 is enough in this case. No need to de-init the ACP.
>> Thank you for the review and input and sorry for getting it wrong! I
>> will send a v2 replacing 'break;' with 'return 0;' shortly.
> Actually, I re-read your message and looked at the code now that I am
> back in front of my keyboard and I am a little confused by your message.
> Should 'goto de_init' be replaced with 'return 0' to avoid the call to
> acp63_deinit() or should ret just be initialized to 0 in this block so
> that the call to acp63_deinit() still happens?
>
> Thanks again for your input!
> Nathan
'goto de-init' should be replaced with 'return 0' for default case.

-
Vijendar
>
>>>>  		goto de_init;
>>>>  	}
>>>>  
>>>>
>>>> ---
>>>> base-commit: 03178b4f7e2c59ead102e5ab5acb82ce1eaefe46
>>>> change-id: 20230105-wsometimes-uninitialized-pci-ps-c-3b5725c6ed31
>>>>
>>>> Best regards,