Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH] scsi: ufs: core: fix devfreq deadlocks
Reply-To: j-young.choi@samsung.com
Sender: Jinyoung CHOI <j-young.choi@samsung.com>
From:   Jinyoung CHOI <j-young.choi@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Asutosh Das <quic_asutoshd@quicinc.com>
CC:     Johan Hovold <johan+linaro@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Can Guo <quic_cang@quicinc.com>
In-Reply-To: <DM6PR04MB65750DE015FA51FDC08D994BFCFA9@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <20230106022456epcms2p784b3cf9115f6b170bdef0732258381ba@epcms2p7>
Date:   Fri, 06 Jan 2023 11:24:56 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <DM6PR04MB65750DE015FA51FDC08D994BFCFA9@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20221222102121.18682-1-johan+linaro@kernel.org>
        <85e91255-1e6f-f428-5376-08416d2107a2@acm.org>
        <20230104141045.GB8114@asutoshd-linux1.qualcomm.com>
        <3db8c140-2e4e-0d75-4d81-b2c1f22f68d1@acm.org>
        <CGME20230105072134epcas2p47a72da1ee48e341295575770d3eb573c@epcms2p7>
Precedence: bulk

>> On 1/4/23 06:10, Asutosh Das wrote:
>> > Load based toggling of WB seemed fine to me then.
>> > I haven't thought about another method to toggle WriteBooster yet.
>> > Let me see if I can come up with something.
>> > IMT if you have a mechanism in mind, please let me know.
>> 
>> Hi Asutosh,
>> 
>> Which UFS devices need this mechanism? All UFS devices I'm familiar with can
>> achieve wire speed for large write requests without enabling the WriteBooster.
>This feature assures SLC-performance for writes to the WriteBooster buffer.
>So enabling it is advantageous as far as write performance.

I agree with you. Also, it can be used in various ways.

>As for the toggling functionality, compared to e.g. enabling it on init and leave it on,
>some flash vendors require it because of device health considerations.
>This is not the case for us, so let others to comment.

In our case, it does not matter whether to toggle or not.
To make the code simple, it seems to be a good way to enable it on init and leave it on.
Considering device health, WB can be disabled through lifetime check.

Thanks,
Jinyoung.

>
>Thanks,
>Avri
>> 
>> Thanks,
>> 
>> Bart.