Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d699a5dd-438e-2bae-b0ec-6820d9860a26@huawei.com>
Date:   Fri, 6 Jan 2023 14:23:25 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v2] mm: huge_memory: convert split_huge_pages_all() to use
 a folio
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <willy@infradead.org>
References: <20221230093020.9664-1-wangkefeng.wang@huawei.com>
 <20221230134535.240f49e0ad8bf6d82f8cc393@linux-foundation.org>
 <fcc4116a-e4cd-9542-60a6-905a4968e6ca@huawei.com>
 <20230105190658.f5d9a4bc9619ad6bec91a973@linux-foundation.org>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20230105190658.f5d9a4bc9619ad6bec91a973@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/1/6 11:06, Andrew Morton wrote:
> On Tue, 3 Jan 2023 09:58:36 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> 
>>
>>
>> On 2022/12/31 5:45, Andrew Morton wrote:
>>> On Fri, 30 Dec 2022 17:30:20 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>>
>>>> Straightforwardly convert split_huge_pages_all() to use a folio.
>>>>
>>>> ...
>>>>
>>>> --- a/mm/huge_memory.c
>>>> +++ b/mm/huge_memory.c
>>>> @@ -2932,6 +2932,7 @@ static void split_huge_pages_all(void)
>>>>    {
>>>>    	struct zone *zone;
>>>>    	struct page *page;
>>>> +	struct folio *folio;
>>>>    	unsigned long pfn, max_zone_pfn;
>>>>    	unsigned long total = 0, split = 0;
>>>>    
>>>> @@ -2944,24 +2945,32 @@ static void split_huge_pages_all(void)
>>>>    			int nr_pages;
>>>>    
>>>>    			page = pfn_to_online_page(pfn);
>>>> -			if (!page || !get_page_unless_zero(page))
>>>> +			if (!page || PageTail(page))
>>>> +				continue;
>>>> +			folio = page_folio(page);
>>>> +			if (!folio_try_get(folio))
>>>>    				continue;
>>>>    
>>>> -			if (zone != page_zone(page))
>>>> +			if (unlikely(page_folio(page) != folio))
>>>> +				goto next;
>>>> +
>>>> +			if (zone != folio_zone(folio))
>>>>    				goto next;
>>>
>>> I'm still not understanding the above hunk.  Why is the
>>> "page_folio(page) != folio" check added?  Should it be commented?
>>
>> There is a comment in try_get_folio(), is it enough?
> 
> Nobody would think to look at a private function in gup.c.

Sorry，I mean that comment is to explain why adding a new recheck.

> 
> I suggest this folio_try_get() rule be documented at the
> folio_try_get() implementation site.
> 
> Most callers do perform this check, but not the ones in vmscan.c ?

Hope Matthew could give some advise, thanks