Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Paul Durrant <xadimgnik@gmail.com>
Message-ID: <4aba7537-7c70-4965-46e2-ac36d389ef0a@xen.org>
Date:   Fri, 6 Jan 2023 09:20:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v6 1/2] KVM: x86/cpuid: generalize
 kvm_update_kvm_cpuid_base() and also capture limit
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paul Durrant <pdurrant@amazon.com>, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        David Woodhouse <dwmw2@infradead.org>
References: <20221220134053.15591-1-pdurrant@amazon.com>
 <20221220134053.15591-2-pdurrant@amazon.com> <Y7XU2R0f3pCYF9uz@google.com>
 <82fbc53e-be3e-b516-2420-dc27e5b811e8@gmail.com>
 <Y7cSdYWX8e3FqlrO@google.com>
Reply-To: paul@xen.org
Organization: Xen Project
In-Reply-To: <Y7cSdYWX8e3FqlrO@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/01/2023 18:09, Sean Christopherson wrote:
> On Thu, Jan 05, 2023, Paul Durrant wrote:
>> On 04/01/2023 19:34, Sean Christopherson wrote:
>>> Since the struct is a 64-bit value, what about making this a pure getter that
>>> returns a copy?
>>>
>>> static struct kvm_hypervisor_cpuid kvm_get_hypervisor_cpuid(struct kvm_vcpu *vcpu,
>>> 							    const char *sig)
>>> {
>>> 	struct kvm_hypervisor_cpuid cpuid = {};
>>> 	struct kvm_cpuid_entry2 *entry;
>>> 	u32 function;
>>>
>>> 	for_each_possible_hypervisor_cpuid_base(cpuid.base) {
>>> 		entry = kvm_find_cpuid_entry(vcpu, function);
>>>
>>> 		if (entry) {
>>> 			u32 signature[3];
>>>
>>> 			signature[0] = entry->ebx;
>>> 			signature[1] = entry->ecx;
>>> 			signature[2] = entry->edx;
>>>
>>> 			if (!memcmp(signature, sig, sizeof(signature))) {
>>> 				cpuid.base = function;
>>> 				cpuid.limit = entry->eax;
>>> 				break;
>>> 			}
>>> 		}
>>> 	}
>>>
>>> 	return cpuid;
>>> }
>>>
>>>
>>> 	vcpu->arch.kvm_cpuid = kvm_get_hypervisor_cpuid(vcpu, KVM_SIGNATURE);
>>> 	vcpu->arch.xen.cpuid = kvm_get_hypervisor_cpuid(vcpu, XEN_SIGNATURE);
>>
>> Yes, if that's preferable then no problem.
> 
> I like it (obviously), but it's probably worth waiting a few days to see what
> others think before posting a new version.

I think it's cleaner too, and I already did the typing so I may as well 
post. I don't think anyone else has expressed any strong opinions on the 
code either way.

Paul