Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liwei Song <liwei.song@windriver.com>
To:     AlexDeucher <alexander.deucher@amd.com>,
        =?UTF-8?q?ChristianK=C3=B6nig?= <christian.koenig@amd.com>,
        PanXinhui <Xinhui.Pan@amd.com>, DavidAirlie <airlied@gmail.com>,
        DanielVetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        liwei.song@windriver.com
Subject: [PATCH] drm/radeon: free iio for atombios when driver shutdown
Date:   Fri,  6 Jan 2023 17:47:29 +0800
Message-Id: <20230106094729.38598-1-liwei.song@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BFPh19migVdJRW6yzpCR8FqWtgn5qwDNuZeisyYkjplB2DF089WczIYbCuPZ?=
 =?us-ascii?Q?EQFfqn0QXtCLNQCapP2MVcfmWPnk+PhHQMkLN4mD4+ZvRnFn0H81vEQGhex0?=
 =?us-ascii?Q?ddPUx2x8lbP/ZHXq2DiPIFOXkXNSpGl4tZFQ6bDu5bCm0MxNcZQ5hrZht2o/?=
 =?us-ascii?Q?0PvDbsomskZoY+3prFLq9eR8cfl6rtq5nJe/+8WKrnGeiptdVahsDL078cuW?=
 =?us-ascii?Q?EWR3darWsLAjmpFdCn5Zp+B+zXkP2c7XoOjD6AF1UGSdrZiR1CUx3C5ENJ1i?=
 =?us-ascii?Q?j1AaCRatEEtOQAjF2itbz92DTVTUkWf1IYySQm7dmTottUIsIu9bZrqMx3TC?=
 =?us-ascii?Q?Iq2KnHU1aqEVb67ykL864gEI2GmLnRzcPeBA5gEQT3+BfCI6Boe+oNEfQcGL?=
 =?us-ascii?Q?O9QpDNYbUhQOxYH4DuZ9tEE2GI+c/t5kMFUVRbRwKLDTrDdlbkxaJzmlZkdm?=
 =?us-ascii?Q?TK4pQDceItfJbZ8h4f9TZREAT+DBZh9gWTh17KPU+zK8W9VHHIST5gwJLGnH?=
 =?us-ascii?Q?10Q/Sg1IEB/9HNtRWzNnSJNOaWHIjMdOtvwOcxs8iojE0vNeuYPc3cARGh/o?=
 =?us-ascii?Q?aWswD6Nuy0/IOpalq5ODUrRCS1qaX8+a8p8DmOUXNesy7oOdaPZYVfoqYX06?=
 =?us-ascii?Q?LWY7937oolDS44jeDoJCJdr/eZXRom9X+LSDfCiQAPfH0IqX3MgHw9POl1As?=
 =?us-ascii?Q?iixQe6/OHVkmXh+lXKAqfUGHFQBy+dMUl58h6L1eHlxSqOXsy3hmkAqJv8w3?=
 =?us-ascii?Q?v9yNQINpsNbG04IKfC1cmusvwZlnd2Z5g60+4uzN0xa/k0OZaHHmsDFi4ssu?=
 =?us-ascii?Q?b9+WZZXwrvgH3tbTWkCH7x3AYOOnDyiR9vz9pBYRr74dwYH1i8CGkvgcZlxG?=
 =?us-ascii?Q?5F9qEx6D1iDkluBaUGv4Nuv0Y+DBxCCezD1rGl0tNGrRe0jp5FmZCj5jPw1U?=
 =?us-ascii?Q?ULqbdbz62cqs8yfEE1GgAYctaoLZSymvGF+Vu7isEE1n+Qz0hC6lUl5LidBy?=
 =?us-ascii?Q?n+bqKHqGyVeWdC+wIXQBi8zgwc9Y3Zn8UmSkiLjhf6JeH9GHeCxdUCesd8VS?=
 =?us-ascii?Q?hTsRd0H0bLft5m6tj8nIiBTwHxHOhmg5DrmjHUmHw1B3wB3zK90AMYz7frux?=
 =?us-ascii?Q?lk/GnwPg5o3r1Q6A9pC1jTgN7argz00Kf1GLYeVGXHahI+3ysoxXRfaQ6U1t?=
 =?us-ascii?Q?ZJliJ2pTAoheZvJJXpwhAHk6o7aApHMEpq6Rc8mjOH0ca0VSeTc9D1T97Un8?=
 =?us-ascii?Q?hU/8uMGbd9P4orj1prgWg4jrhPomIgNbyQ1SvJ29iNgzcav7W92ai7AfnWsw?=
 =?us-ascii?Q?sCKvk1Kx+fsBTlmbtcFEWwiely4FLtHkPH8KjrYaUAXs/IjmnAS2r7P5luTo?=
 =?us-ascii?Q?8nDjT9XjZTUWoNYYRTciSE3Q/hzG1tkr1alUTWVKiL7w18myGYoDbSfNGccC?=
 =?us-ascii?Q?RikOMiH18u59WNFGiPutvgonK/l1e2qXTTYE4yzIdoaRgHYSdUkztzu4qOGc?=
 =?us-ascii?Q?lrDJ8FEqF21e9ca/Dhd8Wf5BT917C+GCQaISpdbaLKzaQXds5eEyXw1LMElO?=
 =?us-ascii?Q?XlOULsdvUk884BX1BTwb5W2p2hFPJ03Hhr0QH4sSUMhvygLXNHnz1wyjKoD8?=
 =?us-ascii?Q?0Q=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e47c395-c5e3-4944-b6dc-08daefcb1319
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5348.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 09:47:50.5916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bq2TNa5ib0FLW64gB8ZDbVAW5Eio9ar46KCPc0/W4c1HjAdk7xf94rHePjasEFocLJw/26sjw9Yk+hizfsxqkIDluXZZX9XB/S5RTfj1cLw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7850
X-Proofpoint-ORIG-GUID: u5Ss8DMAsqRCEZXdzHssshWPOZr7o9Y3
X-Proofpoint-GUID: u5Ss8DMAsqRCEZXdzHssshWPOZr7o9Y3
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-06_05,2023-01-05_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 bulkscore=0 clxscore=1011 spamscore=0 suspectscore=0 malwarescore=0
 impostorscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301060077
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix below kmemleak when unload radeon driver:

unreferenced object 0xffff9f8608ede200 (size 512):
  comm "systemd-udevd", pid 326, jiffies 4294682822 (age 716.338s)
  hex dump (first 32 bytes):
    00 00 00 00 c4 aa ec aa 14 ab 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000062fadebe>] kmem_cache_alloc_trace+0x2f1/0x500
    [<00000000b6883cea>] atom_parse+0x117/0x230 [radeon]
    [<00000000158c23fd>] radeon_atombios_init+0xab/0x170 [radeon]
    [<00000000683f672e>] si_init+0x57/0x750 [radeon]
    [<00000000566cc31f>] radeon_device_init+0x559/0x9c0 [radeon]
    [<0000000046efabb3>] radeon_driver_load_kms+0xc1/0x1a0 [radeon]
    [<00000000b5155064>] drm_dev_register+0xdd/0x1d0
    [<0000000045fec835>] radeon_pci_probe+0xbd/0x100 [radeon]
    [<00000000e69ecca3>] pci_device_probe+0xe1/0x160
    [<0000000019484b76>] really_probe.part.0+0xc1/0x2c0
    [<000000003f2649da>] __driver_probe_device+0x96/0x130
    [<00000000231c5bb1>] driver_probe_device+0x24/0xf0
    [<0000000000a42377>] __driver_attach+0x77/0x190
    [<00000000d7574da6>] bus_for_each_dev+0x7f/0xd0
    [<00000000633166d2>] driver_attach+0x1e/0x30
    [<00000000313b05b8>] bus_add_driver+0x12c/0x1e0

iio was allocated in atom_index_iio() called by atom_parse(),
but it doesn't got released when the dirver is shutdown.
Fix this kmemleak by free it in radeon_atombios_fini().

Signed-off-by: Liwei Song <liwei.song@windriver.com>
---
 drivers/gpu/drm/radeon/radeon_device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index 92905ebb7b45..1c005e0ddd38 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -1022,6 +1022,7 @@ void radeon_atombios_fini(struct radeon_device *rdev)
 {
 	if (rdev->mode_info.atom_context) {
 		kfree(rdev->mode_info.atom_context->scratch);
+		kfree(rdev->mode_info.atom_context->iio);
 	}
 	kfree(rdev->mode_info.atom_context);
 	rdev->mode_info.atom_context = NULL;
-- 
2.33.1