Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 12:10:57 +0200
From:   Ido Schimmel <idosch@nvidia.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Petr Machata <petrm@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_router: Replace 0-length array with
 flexible array
Message-ID: <Y7fzsd7aH/tCAMyf@shredder>
References: <20230105232224.never.150-kees@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230105232224.never.150-kees@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y6qpmSSZ5HhAHyhwbQ0KhL3muU4WfzdZcvAkyzbIvUpzULJcGjz8t/MxhWAw?=
 =?us-ascii?Q?PtNYE7GF2BCUiZW3nc4IDhMvtjL8j1hal1Zd04mude6aYrB9EWNVS1QGUNMV?=
 =?us-ascii?Q?x0GkjxZSmHiSkMyVihNb7KAPMuZcnYRV24OYPMIZNxf4cO3Cf+D9wDwLoGyl?=
 =?us-ascii?Q?N3O03lBXbxr3FUNxsuOcDNfsL2VM0CmSsa9+5ECwVqG46J0EUXPzHK5Gjcm/?=
 =?us-ascii?Q?Akur7CKYZEYjtjTLJ5Ylxc9xCqVunW7hp6qsuh8j1ANwYM4QlijLbHwbfOiR?=
 =?us-ascii?Q?1qcMhtVIdpaBT/kK3gFsxpLjylRW6fTdCTOT/JWt9nCZZPXO1Zqddpuiv9cR?=
 =?us-ascii?Q?9+G+N0kkgHcY9pZexnZhe4+rmDIn/O0GZixLYfs/uWsGe3PXZ5DoDCIk/bKW?=
 =?us-ascii?Q?BvSJlg3ZFl/fjO6iPn8h0b+cI/TjE2aFUqWpknU+RzSxlq7YvtK5zgRXks8P?=
 =?us-ascii?Q?p+GnkpW+rHJl2ptwSp5Z9fhiANrkrLhxOMBWV8thu5+/Q4M32pA6h3HqMUZX?=
 =?us-ascii?Q?tUD6D/nN3mQePzcQe2Fm1LKt5SvXp4tudN99KYY0wBOaIw1jMuTDqpjqGwN8?=
 =?us-ascii?Q?fPWjyQ4vbFOYHTCtNHc5cYIMZbMgJRDwCa5rklUIG3PoJWhjSrXjiHIWEf6z?=
 =?us-ascii?Q?6Q2wv5bBDJvRgWYZNe4oigTltCq8urQfoW54KOPRAlE/U6Z8RGdewsgsArtu?=
 =?us-ascii?Q?ezZ+Lt0WJYLPged23sjxxaOubyVsLw+y7NwyxxZ2AF+Qx8LbLlUflnHQN8xF?=
 =?us-ascii?Q?1V9bIT1ixALIJjYcCanINXwWWpP6MVZuoAr5ZRq8PV1iC+xE9BcokyTaLjC4?=
 =?us-ascii?Q?opo33RCcTSBJtPGVvI94QfQYKYPrzHEQxjz3sWq2k/xVMK1dO2qSBpvwtev5?=
 =?us-ascii?Q?mmFqcyiL68hbyzH1ILiDlVxQ115hjBlr5VS0aPlBqS5Wetim6Lj6+0Bij7uv?=
 =?us-ascii?Q?Y7sMK6j0QW82D/l5rb/KxyIpVNHQVogt+WC33CHvVHO/zqUmYPB4221A2nRV?=
 =?us-ascii?Q?JN8tgVhf8mGC2i4wq6JQCR91hjh2hhJRl1UfI8DzDcLVQ8kzk83d8/KTmLRM?=
 =?us-ascii?Q?spyeQZjD1tiHZOpcL6cUlkbDYClwStJf210KlbdqHxmm3K64kx6OnctDwGMA?=
 =?us-ascii?Q?lHgIkWNchgyjrOMZHQwZInlMEUBoguJE1lbpip0CDcP7eXXrTWkcJwDF9q+K?=
 =?us-ascii?Q?f29HVekdQ4y0yIplExKD1UsJlYnPT7GtqbSNk64jv+MbMm8kjFBPkVE5E111?=
 =?us-ascii?Q?MQTQXnplOoplRLlsJrkdS+WIZBLY2hGMmZm45lRjK+fZdRipoqVTQ5f7Izkp?=
 =?us-ascii?Q?48CzvI16XtMMI/gNDsgoKm4Jq+8EJpG5XrKrS+3Khk9Py7ativd0a7nvThfJ?=
 =?us-ascii?Q?lpTGoE+jy5oorqmR0fgDb4OoyQFNU35dzf7C2cGABdfVSj4YYclzbzTRMDbk?=
 =?us-ascii?Q?CrLIpTZH1c5xu9zDHfPgyLRDYjEn30LrziZIAPUCUmyzOEojk94S+HFLMwcc?=
 =?us-ascii?Q?tADIK5/d86rbtNPbjUJn0ddOQ1bBgC5fFGsW4KeVL1Au5I7+erSWh2g4DDDl?=
 =?us-ascii?Q?QwvqjJ96lcTbtYPhhm/5sEXmkEYX7+zsYBrBTtaO?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4df2247-b577-4d27-f4bd-08daefce50d2
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 10:11:02.6680
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7kREhydDK6umth2koU+OkFcyv/tig3BmTZEz9GU0GPjc/uW4mZYmooO5z2zWL+vUjbomUI7BASwNCZh9qHZChg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7970
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 05, 2023 at 03:22:29PM -0800, Kees Cook wrote:
> Zero-length arrays are deprecated[1]. Replace struct
> mlxsw_sp_nexthop_group_info's "nexthops" 0-length array with a flexible
> array. Detected with GCC 13, using -fstrict-flex-arrays=3:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_nexthop_group_hash_obj':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:3278:38: warning: array subscript i is outside array bounds of 'struct mlxsw_sp_nexthop[0]' [-Warray-bounds=]
>  3278 |                         val ^= jhash(&nh->ifindex, sizeof(nh->ifindex), seed);
>       |                                      ^~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:2954:33: note: while referencing 'nexthops'
>  2954 |         struct mlxsw_sp_nexthop nexthops[0];
>       |                                 ^~~~~~~~
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
> 
> Cc: Ido Schimmel <idosch@nvidia.com>
> Cc: Petr Machata <petrm@nvidia.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks