Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: jXZ9zb/weTMyeA8XFC+SsEJ5pXRRCcbBtb7gganr4X9OCEa4ZIokj5a7sUEoSZ5KucVJdDX7Fu
 EScjoyobNXG51OUkYoHJh3a6urLT/AQqhK4OAnzzjWKL0IJ6lMz9veeUHjhXsVPfp6SSeinRFk
 vbiJZyLAP9vM15qSS6Z5ZEC1JUYAnX/mCBV5+MUV6pzuAWZ+5HkbbZ9zwrLiNHmcCGo1LbEoXT
 zquoAHNUzJ/37KuBWq9SzVKdNw1MrR9SZSgLLtSJWLk0mrd/0s6HhkbC/8uiSARcCYKhBDoGvg
 Q/M=
IronPort-SDR: F2npbCBETYWb06hnwW2AfxpNr6FJC0qFJGXXdR5VAs68LONffKubxNPAlH1Xp1gGsi7BqB9R19
 8MWNJz8hzf9y+yBuuKqfSYgB0OQffia21SrBeT1XfuinzrDjfd0EVi6JiEp6RTVNgQ67728bKd
 slr1Ptz5CdyCuLuAPsHn2uBZAK5OGjjCqfWI23J38gxBjOH9+0t4CAmED7libP+2LoY4Rw4FIY
 PTVUld3r13+teydKdoXzhUNUCIwVKgFtOKtOxgLNO4FQqQEyBaaGjbDaFxqV/jUrEjjLk9UBfB
 K70=
WDCIronportException: Internal
Message-ID: <22e12d95-d00d-270d-8119-8587672976a7@opensource.wdc.com>
Date:   Fri, 6 Jan 2023 20:01:06 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 1/7] block: remove superfluous check for request queue in
 bdev_is_zoned
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, axboe@kernel.dk
Cc:     kernel@pankajraghav.com, linux-kernel@vger.kernel.org,
        hare@suse.de, bvanassche@acm.org, snitzer@kernel.org,
        dm-devel@redhat.com, linux-nvme@lists.infradead.org, hch@lst.de,
        linux-block@vger.kernel.org, gost.dev@samsung.com
References: <20230106083317.93938-1-p.raghav@samsung.com>
 <CGME20230106083319eucas1p1e58f4ab0d3ff59a328a2da2922d76038@eucas1p1.samsung.com>
 <20230106083317.93938-2-p.raghav@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230106083317.93938-2-p.raghav@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/6/23 17:33, Pankaj Raghav wrote:
> Remove the superfluous request queue check in bdev_is_zoned() as the
> bdev_get_queue can never return NULL.
> 
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
>  include/linux/blkdev.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 43d4e073b111..0e40b014c40b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1283,12 +1283,7 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)
>  
>  static inline bool bdev_is_zoned(struct block_device *bdev)
>  {
> -	struct request_queue *q = bdev_get_queue(bdev);
> -
> -	if (q)
> -		return blk_queue_is_zoned(q);
> -
> -	return false;
> +	return blk_queue_is_zoned(bdev_get_queue(bdev));
>  }
>  
>  static inline bool bdev_op_is_zoned_write(struct block_device *bdev,

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

-- 
Damien Le Moal
Western Digital Research