Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759458AbXHUGJm (ORCPT ); Tue, 21 Aug 2007 02:09:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756114AbXHUGJf (ORCPT ); Tue, 21 Aug 2007 02:09:35 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35672 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867AbXHUGJe (ORCPT ); Tue, 21 Aug 2007 02:09:34 -0400 Subject: Re: [linux-usb-devel] [4/4] 2.6.23-rc3: known regressions From: Arjan van de Ven To: Linus Torvalds Cc: David Brownell , Michal Piotrowski , linux-usb-devel@lists.sourceforge.net, Greg KH , LKML , "Stuart_Hayes@Dell.com" , Andrew Morton , Daniel Exner In-Reply-To: <1187675488.2676.3.camel@laptopd505.fenrus.org> References: <46C098FD.1030601@googlemail.com> <200708202102.58508.david-b@pacbell.net> <200708202148.45575.david-b@pacbell.net> <1187675488.2676.3.camel@laptopd505.fenrus.org> Content-Type: text/plain Organization: Intel International BV Date: Mon, 20 Aug 2007 23:04:14 -0700 Message-Id: <1187676254.2676.6.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.11.90 (2.11.90-1.fc8) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 32 On Mon, 2007-08-20 at 22:51 -0700, Arjan van de Ven wrote: > and the C-state code will honor it. CPUFREQ doesn't honor it yet but > that's easy to add.. untested patch to add this to cpufreq; this is probably a good idea in general even if using the latency framework doesn't end up being used for fixing this regression... --- linux-2.6.23-rc2/drivers/cpufreq/cpufreq.c.org 2007-08-20 22:58:32.000000000 -0700 +++ linux-2.6.23-rc2/drivers/cpufreq/cpufreq.c 2007-08-20 23:02:21.000000000 -0700 @@ -1604,6 +1604,12 @@ static int __cpufreq_set_policy(struct c if (ret) goto error_out; + + if (system_latency_constraint() < policy->cpuinfo.transition_latency) { + ret = -EINVAL; + goto error_out; + } + /* notification of the new policy */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_NOTIFY, policy); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/