Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-fc462dbe-05a4-4a4f-b79a-7d79a2922dd8-1673007511120@3c-app-gmx-bap25>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     netdev@vger.kernel.org, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Aw: Re:  Re: Re: [PATCH net v3 4/5] net: ethernet: mtk_eth_soc:
 drop generic vlan rx offload, only use DSA untagging
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 6 Jan 2023 13:18:31 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <904dfc35-ecae-97dc-e9d9-a7df83ff89d4@nbd.name>
References: <20221230073145.53386-1-nbd@nbd.name>
 <20221230073145.53386-4-nbd@nbd.name>
 <trinity-a07d48f4-11cf-4a24-a797-03ad4b1150d9-1672400818371@3c-app-gmx-bap18>
 <82821d48-9259-9508-cc80-fc07f4d3ba14@nbd.name>
 <trinity-ace28b50-2929-4af3-9dd2-765f848c4d99-1672408565903@3c-app-gmx-bap18>
 <fc09b981-282e-26cd-661e-86fdc72bedf9@nbd.name>
 <trinity-01eda9f9-b989-4554-ba35-a7f7a18da786-1672414711074@3c-app-gmx-bap18>
 <904dfc35-ecae-97dc-e9d9-a7df83ff89d4@nbd.name>
UI-OutboundReport: notjunk:1;M01:P0:DEJSVC2G+f0=;rh71YAevLudKgvM9rQblLL1yIxQ
 9SFChwyb8SyDCesVz6Eh1VcxQxNpKe6aZY17Ay7jnAGzs5pXYqxv7xjD3o/5Vw3L87VTxir0c
 3WqewLy4Mqwi53T3lkBG1Qe+BNxkJdWZ3HTJ7DiFe99TLCaCHPRHbomVS4eyLku+zMjQjRcTS
 NWZs58qObuzkVt3NNDWVNJQJDa5hD95Rixm2tbUSffTIkmCkd5qi2N9v3VJF55eRbiarquGeM
 cWENablThdhIAvphje7ROaIGp947SEr46dvivwZKl6FNkTiAEVDyfLbCltvr6e4Fmx/xmIqct
 fnNVjPnnKY8paimmHTmiqDe3U75L8K18XItRyhY6mkniWRjfgESm58j0zCCOWh938Zlt4+YpE
 fGrh9nyEYKOicHYLAaVdMFzMdm/HMMbqkFXVI7XAbO+FR5+qHWjJki6Go0QjchjMtWSRHk3DW
 EDf5rbB7S0F7pygakjc+HYKUbBsixRvG15uLvELM+Lr0vKHuQvFuPzjUS1MPg1O0p58iRhIjL
 A2DTzhTwvsM/ONU2QVyu2lQ9z6ItjeTCzU1o6NNUkU7yDHTMbrMLXRTQ+qPc/7WrM1nqtESZW
 9PHknm5PBkbXVtGP4VANptIrQrPPcWrU1Rzb0MsthTTjfG1pL6F8kJz2UbVaWaRpKHYMInsqm
 ONFQyuMZELBraSzCwNNW6I/trJza9IPwWvSWSf1UJGBwoGqwSeFviBkJ47tq3YDD8rNl+yJgp
 2e53n0B4egC7dmW3aq75ZGv5aauDqe/1oFTvzP2KOftOCw/K+qIoCGhFl9JAi5ibRzJYlcxd6
 y819OgqIJ9xczkAjm1IZicIg==
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

update on my tests...something in my systemd-networkd breaks vlan on dsa-p=
ort.

if i boot with this disabled vlan added manually works on dsa-port and gma=
c too. so felix you can keep my tested-by.

if vlan is working and i activate networkd afterwards vlans are still work=
ing...i guess systemd puts the wan-interface into some kind of non-vlan-mo=
de (vlan-filtering?).

this is my basic systemd-config:

/etc/systemd/network/15-wan.network
[Match]
Name=3Dwan

[Network]
BindCarrier=3Deth0

#static setup
Address=3D192.168.0.19/24
Gateway=3D192.168.0.10
DNS=3D192.168.0.10

IPForward=3Dyes

/etc/systemd/network/20-lanbr.netdev
[NetDev]
Name=3Dlanbr0
Kind=3Dbridge

[Bridge]
DefaultPVID=3D1
VLANFiltering=3D1
/etc/systemd/network/22-lanbr.network

[Match]
Name=3Dlanbr0

[Network]
BindCarrier=3Deth0
ConfigureWithoutCarrier=3Dtrue

Address=3D192.168.1.1/24
Address=3Dfd00:A::10/64

[DHCPServer]
PoolOffset=3D100
PoolSize=3D150

/etc/systemd/network/05-eth0.network
[Match]
Name=3Deth0

[Network]
DHCP=3Dno
LinkLocalAddressing=3Dno
ConfigureWithoutCarrier=3Dtrue

/etc/systemd/network/21-lanbr-bind.network
[Match]
Name=3Dlan0 lan1 lan2 lan3

[Network]
Bridge=3Dlanbr0

/etc/systemd/network/10-wan.link
[Match]
OriginalName=3Dwan

[Link]
Name=3Dwan
#MACAddressPolicy=3Dnone
#MACAddress=3D08:22:33:44:55:77


regards Frank


> Gesendet: Freitag, 30. Dezember 2022 um 17:13 Uhr
> Von: "Felix Fietkau" <nbd@nbd.name>
> An: "Frank Wunderlich" <frank-w@public-files.de>
> Cc: netdev@vger.kernel.org, "John Crispin" <john@phrozen.org>, "Sean Wan=
g" <sean.wang@mediatek.com>, "Mark Lee" <Mark-MC.Lee@mediatek.com>, "Loren=
zo Bianconi" <lorenzo@kernel.org>, "David S. Miller" <davem@davemloft.net>=
, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>=
, "Paolo Abeni" <pabeni@redhat.com>, "Matthias Brugger" <matthias.bgg@gmai=
l.com>, "Russell King" <linux@armlinux.org.uk>, linux-arm-kernel@lists.inf=
radead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.o=
rg
> Betreff: Re: Aw: Re: Re: [PATCH net v3 4/5] net: ethernet: mtk_eth_soc: =
drop generic vlan rx offload, only use DSA untagging
>
> On 30.12.22 16:38, Frank Wunderlich wrote:
> > seems only tx is affected on r3, as i see packets on the vlan from my =
laptop
> >
> > tcpdump on R3 (e4:b9:7a:f7:c4:8b is mac from laptop):
> >
> > 13:47:05.265508 e4:b9:7a:f7:c4:8b > ff:ff:ff:ff:ff:ff, ethertype 802.1=
Q (0x8100), length 577: vlan 500, p 0, ethertype IPv4 (0x0800), 192.168.50=
.2.59389 > 192.168.50.255.21027: UDP, length 531
> > 13:47:05.265548 e4:b9:7a:f7:c4:8b > ff:ff:ff:ff:ff:ff, ethertype 802.1=
Q (0x8100), length 577: vlan 600, p 0, ethertype IPv4 (0x0800), 192.168.60=
.2.59389 > 192.168.60.255.21027: UDP, length 531
> >
> > regards Frank
> I don't have a setup to test 6.2 on my MT7986 board right now, but I did
> test latest OpenWrt with my changes and couldn't reproduce the issue the=
re.
> I checked the diff between my tree and upstream and didn't find any
> relevant differences in mtk_eth_soc.c
> Not sure what's going on or how to narrow it down further.
>
> - Felix
>