Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d141edb-c72c-8889-112b-71ce5699dc35@linaro.org>
Date:   Fri, 6 Jan 2023 14:19:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 2/3] thermal/drivers/intel: Use generic trip points for
 intel_pch
Content-Language: en-US
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "srinivas.pandruvada@linux.intel.com" 
        <srinivas.pandruvada@linux.intel.com>,
        "rafael@kernel.org" <rafael@kernel.org>
Cc:     "Brown, Len" <len.brown@intel.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "amitk@kernel.org" <amitk@kernel.org>,
        "ricardo.neri-calderon@linux.intel.com" 
        <ricardo.neri-calderon@linux.intel.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
References: <20230104222127.2364396-1-daniel.lezcano@kernel.org>
 <20230104222127.2364396-3-daniel.lezcano@kernel.org>
 <ff0b001a0b7c7beb17e007219414a39ba6d953ef.camel@intel.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <ff0b001a0b7c7beb17e007219414a39ba6d953ef.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Rui,

On 06/01/2023 09:32, Zhang, Rui wrote:
> On Wed, 2023-01-04 at 23:21 +0100, Daniel Lezcano wrote:
>> From: Daniel Lezcano <daniel.lezcano@linaro.org>
>>
>> The thermal framework gives the possibility to register the trip
>> points with the thermal zone. When that is done, no get_trip_* ops
>> are
>> needed and they can be removed.
>>
>> Convert the ops content logic into generic trip points and register
>> them with the thermal zone.
>>
>> In order to consolidate the code, use the ACPI thermal framework API
>> to fill the generic trip point from the ACPI tables.
>>
>> It has been tested on a Intel i7-8650U - x280 with the INT3400, the
>> PCH, ACPITZ, and x86_pkg_temp. No regression observed so far.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
>> ---
>>      V3:
>>        - The driver Kconfig option selects CONFIG_THERMAL_ACPI
>> ---
>>   drivers/thermal/intel/Kconfig             |  1 +
>>   drivers/thermal/intel/intel_pch_thermal.c | 88 +++++--------------
>> ----
>>   2 files changed, 20 insertions(+), 69 deletions(-)
>>
>> diff --git a/drivers/thermal/intel/Kconfig
>> b/drivers/thermal/intel/Kconfig
>> index f0c845679250..738b88b290f4 100644
>> --- a/drivers/thermal/intel/Kconfig
>> +++ b/drivers/thermal/intel/Kconfig
>> @@ -75,6 +75,7 @@ config INTEL_BXT_PMIC_THERMAL
>>   config INTEL_PCH_THERMAL
>>   	tristate "Intel PCH Thermal Reporting Driver"
>>   	depends on X86 && PCI
>> +	select THERMAL_ACPI
> 
> THERMAL_ACPI depends on ACPI but the PCH thermal driver does not.
> So we will run into "unmet dependencies" issue when CONFIG_ACPI is
> cleared like below
> 
> WARNING: unmet direct dependencies detected for THERMAL_ACPI
>    Depends on [n]: THERMAL [=y] && ACPI [=n]
>    Selected by [m]:
>    - INTEL_PCH_THERMAL [=m] && THERMAL [=y] && (X86 [=y] ||
> X86_INTEL_QUARK [=n] || COMPILE_TEST [=n]) && X86 [=y] && PCI [=y]
> 

Ah yes, indeed. Thanks for spotting this.

Given the code, I think we should do:

	select THERMAL_ACPI if ACPI

it is from my POV semantically correct.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog