Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9feeb96d-f5d6-d903-91bc-4fa54d0e0744@linaro.org>
Date:   Fri, 6 Jan 2023 14:25:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 0/3] Thermal ACPI APIs for generic trip points
Content-Language: en-US
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "srinivas.pandruvada@linux.intel.com" 
        <srinivas.pandruvada@linux.intel.com>,
        "rafael@kernel.org" <rafael@kernel.org>
Cc:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
References: <20230104222127.2364396-1-daniel.lezcano@kernel.org>
 <cef493c6d918565d1b8c16aedadf5a19edd48b48.camel@intel.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <cef493c6d918565d1b8c16aedadf5a19edd48b48.camel@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/01/2023 09:25, Zhang, Rui wrote:
> Hi,  Daniel,
> 
> On Wed, 2023-01-04 at 23:21 +0100, Daniel Lezcano wrote:
>> Recently sent as a RFC, the thermal ACPI for generic trip points is a
>> set of
>> functions to fill the generic trip points structure which will become
>> the
>> standard structure for the thermal framework and its users.
>>
>> Different Intel drivers and the ACPI thermal driver are using the
>> ACPI tables to
>> get the thermal zone information. As those are getting the same
>> information,
>> providing this set of ACPI function with the generic trip points will
>> consolidate the code.
> 
> My understanding is that the ACPI thermal driver
> (drivers/acpi/thermal.c) should be one of the top users of these APIs.

Yes, correct.

> Is there any specific reason that it is not included in this patch
> series? or is it just that you don't have ACPI thermal driver running
> on your test platform?

The generic trip point handling in the acpi thermal driver is another 
story. Some code reorg and cleanup should be done before. I have a 
series for that but I need to test it more. That is the reason why it 
will be submitted after this series is reviewed, so the changes will be 
focused on the acpi thermal driver only.

I have a laptop with acpitz but only the critical trip temp.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog