Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d8624ea-306c-2ab4-882a-f543c316c539@gmail.com>
Date:   Fri, 6 Jan 2023 15:47:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3 7/7] ufs: core: Add advanced RPMB support in ufs_bsg
To:     Bart Van Assche <bvanassche@acm.org>, Bean Huo <beanhuo@iokpp.de>,
        alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com, tomas.winkler@intel.com,
        daejun7.park@samsung.com, quic_cang@quicinc.com,
        quic_nguyenb@quicinc.com, quic_xiaosenh@quicinc.com,
        quic_richardp@quicinc.com, quic_asutoshd@quicinc.com, hare@suse.de
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221201140437.549272-1-beanhuo@iokpp.de>
 <20221201140437.549272-8-beanhuo@iokpp.de>
 <81a10cd9-7b0b-e982-5d24-5f0438e37b63@acm.org>
Content-Language: en-US
From:   Bean Huo <huobean@gmail.com>
In-Reply-To: <81a10cd9-7b0b-e982-5d24-5f0438e37b63@acm.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Bart,

Thanks for your report, I will fix it along with cleanup patch. Sorry 
for this issue!!


Kind regards,

Bean


On 05.01.23 11:37 PM, Bart Van Assche wrote:
> Hi Bean,
>
> I think this patch is the first patch that adds a declaration in 
> ufshcd.h that uses the enum dma_data_direction data type. That leads 
> to the following compiler warning:
>
> In file included from drivers/ufs/host/tc-dwc-g210-pci.c:10:
> ./include/ufs/ufshcd.h:1282:72: warning: ‘enum dma_data_direction’ 
> declared inside parameter list will not be visible outside of this 
> definition or declaration
>  1282 |                                      struct scatterlist 
> *sg_list, enum dma_data_direction dir);
>       |        ^~~~~~~~~~~~~~~~~~
>
> Can you please post a patch to fix this? Adding the following line is 
> probably sufficient:
>
> #include <linux/dma-direction.h>
>
> This has been detected with the following script:
> https://github.com/bvanassche/build-scsi-drivers/blob/main/build-scsi-drivers 
>
>
> Thanks,
>
> Bart.