Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221216102318.197994-1-yiyang13@huawei.com> <1800775a-5788-b60b-87cb-9b09c7e7c177@amd.com>
In-Reply-To: <1800775a-5788-b60b-87cb-9b09c7e7c177@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 6 Jan 2023 10:28:07 -0500
Message-ID: <CADnq5_N5hpnu27Q_XgJ2D-ZnVMFsvX3fzapH3yU7R8ynSdZ2vA@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: Remove redundant assignment to
 variable dc
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     Yi Yang <yiyang13@huawei.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Jan 5, 2023 at 2:20 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 12/16/22 05:23, Yi Yang wrote:
> > Smatch report warning as follows:
> >
> > Line 53679: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:402
> > dc_stream_set_cursor_position() warn: variable dereferenced before
> > check 'stream'
> >
> > The value of 'dc' has been assigned after check whether 'stream' is
> > NULL. Fix it by remove redundant assignment.
> >
> > Signed-off-by: Yi Yang <yiyang13@huawei.com>
>
> If this didn't blow up until now we might not even need
> the NULL check below, but either way this is correct and
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> > index 20e534f73513..78d31bb875d1 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> > @@ -408,7 +408,7 @@ bool dc_stream_set_cursor_position(
> >       struct dc_stream_state *stream,
> >       const struct dc_cursor_position *position)
> >  {
> > -     struct dc  *dc = stream->ctx->dc;
> > +     struct dc *dc;
> >       bool reset_idle_optimizations = false;
> >
> >       if (NULL == stream) {
>