Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230106045327.never.413-kees@kernel.org>
In-Reply-To: <20230106045327.never.413-kees@kernel.org>
From:   Julius Werner <jwerner@chromium.org>
Date:   Fri, 6 Jan 2023 16:03:35 +0100
Message-ID: <CAODwPW8kXZ107kMuVGya9Y=i+8QwQzQHokXCpybzMBjd_w_83w@mail.gmail.com>
Subject: Re: [PATCH] firmware: coreboot: Check size of table entry and split memcpy
To:     Kees Cook <keescook@chromium.org>
Cc:     Jack Rosenthal <jrosenth@chromium.org>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Guenter Roeck <groeck@chromium.org>,
        Julius Werner <jwerner@chromium.org>,
        Brian Norris <briannorris@chromium.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Have you considered adding the flexible array member directly to the
union in struct coreboot_device instead? I think that would make this
a bit simpler by not having to copy header and data portion
separately.