Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a9371e6-6516-5966-f92c-10bb228c8db3@marcan.st>
Date:   Sat, 7 Jan 2023 01:40:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 3/5] spi: Use a 32-bit DT property for
 spi-cs-setup-delay-ns
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Janne Grunau <j@jannau.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        asahi@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20230104093631.15611-4-marcan@marcan.st>
 <Y7hLrxQO9GbgpW1h@sirena.org.uk>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <Y7hLrxQO9GbgpW1h@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 07/01/2023 01.26, Mark Brown wrote:
> On Wed, Jan 04, 2023 at 06:36:29PM +0900, Janne Grunau wrote:
> 
>> 65us is not a reasonable maximum for this property, as some devices
>> might need a much longer setup time (e.g. those driven by firmware on
>> the other end). Plus, device tree property values are in 32-bit cells
>> and smaller widths should not be used without good reason.
> 
> This breaks allmodconfig builds (I tested x86 but this should happen
> for anything with -Werror):
> 
> /build/stage/linux/drivers/spi/spi.c: In function ‘of_spi_parse_dt’:
> /build/stage/linux/drivers/spi/spi.c:2243:13: error: unused variable ‘cs_setup’ [-Werror=unused-variable]
>  2243 |         u16 cs_setup;
>       |             ^~~~~~~~
> cc1: all warnings being treated as errors

Yeah, the kernel test robot caught this one too. Sorry for missing it
(it got buried in warning noise in a rather large rebuild on my side).
That line should've been removed in #3 :(

I see two patches got applied already. Do you want me to just respin #3-#5?

- Hector