Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2692953rwl; Fri, 6 Jan 2023 09:41:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXucHzDXR9L/ChId4o35eFrWCxhPuO4vAIuNfxHHkRRYAXEfB0IkCw+p0/3ooUu8u2fSoAkA X-Received: by 2002:a05:6402:550e:b0:45c:835b:ac64 with SMTP id fi14-20020a056402550e00b0045c835bac64mr49006216edb.31.1673026896529; Fri, 06 Jan 2023 09:41:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673026896; cv=none; d=google.com; s=arc-20160816; b=D3P1yXafg+WUD4fFY2889FC5RSOdBwLJSMGiwf8zdEyUiwWCGBLg3aQyeAkIP34sfM 5F3Tjh/cW5/mQzXVaYz2uounE4hiWxBsgu0LhfSfOLiymf6z8RWhNyVOVEgvKOx7xrc3 PDvWe509TUcHlCR5QAwwne+5Qa6QoMV7nZc3NT3TqzodhZpHemIMrOjEHc+Fk2VtsdF+ XVVYD+TfM+gGjd1i0PtL4OqCtd1HIEG5mzo7Sm7TOiK5ez7FBqaBQ0r7lvlo6Un7U+ig sT3aRC1z/EQeYUngAPHV03d9ewhqs6E93mbNoj/fzX8Q9Pih8NZDIi7kmY/7n9M/sMHd Ys8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3x1ChIU8b+v0wuj181ep4fqO8ApTtfDqjntuZWOTc8U=; b=IF2xaqmkpnBNgR0aLtlVCt7DnGcQiEe/5nEw/Is6vfZOkaQaPe68zd0PTzP2h0AMBf iwcf2FT5jrHbRgS/wbjb/TdblmsiChrEugTmrTWPYMRIg0Lzt/0YfppboNa9gEXoBMdU XAD/pjuVL3VdO2agei49ePU0ogcABmsrZOz47mDfDTaY4pIa33CtAF97ZDefoP+UXOpG FtVYAEfwDBfLnfv7Gf1Tzh7KyZwHYO0liu+RSId7SZi3OCb/PdnC+E9V0aJPao+f+qiY Rs37e/jcCZnaC1DtckXsxX9nZM/lTZaqf3aYeoJYe/Wv7vMklBQAxm+CosNA1siQ7rMf sRzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aADRfMLQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f9-20020a0564021e8900b00467960d3013si2766789edf.43.2023.01.06.09.41.23; Fri, 06 Jan 2023 09:41:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aADRfMLQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233787AbjAFRXx (ORCPT + 54 others); Fri, 6 Jan 2023 12:23:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235885AbjAFRXt (ORCPT ); Fri, 6 Jan 2023 12:23:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689517D9C3 for ; Fri, 6 Jan 2023 09:23:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04C3861EBA for ; Fri, 6 Jan 2023 17:23:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03D60C433D2; Fri, 6 Jan 2023 17:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673025827; bh=AwyUBMt2K+2WekTeSn6jMv9BpnWBDC8Aaa/wrQ3tyK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aADRfMLQVEdU+XpDI4eDbnxHsiw+h9BZU9DKWnob3lhB8dRHQfQxlHP0RNw49yl6S tdhvKJvtT5NoSqUSbjFFY9TeFLb341BM2pEZliR9H+WzbSZ3E1mbBILjKDXWB0lKCg vsUY9K1my06hUR70qsABNLlv7/3h4duZyhRtMA1srXjh8V+kRMSG0W9vtNt6et3Zd/ RI2aQdsLz5/acP8vXACyB3Xw1q5dDE3NhGwLULXRPUEdE69GcGa5Rq5h+N2tJdilYj ujDsq7W3fMj2OypO+qk6aYrNjZaUCnGzJ8Foz3wWlPxPH69gZHsTJFrrLWvt3yh9fk abuwGEO6FiZrA== From: SeongJae Park To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH v2 25/44] mm: Switch vma_merge(), split_vma(), and __split_vma to vma iterator Date: Fri, 6 Jan 2023 17:23:45 +0000 Message-Id: <20230106172345.149991-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230105191517.3099082-26-Liam.Howlett@oracle.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Liam, On Thu, 5 Jan 2023 19:15:59 +0000 Liam Howlett wrote: > From: "Liam R. Howlett" > > Drop the vmi_* functions and transition all users to use the vma > iterator directly. > > Signed-off-by: Liam R. Howlett > --- > fs/userfaultfd.c | 14 ++++---- > include/linux/mm.h | 16 +++------- > mm/madvise.c | 6 ++-- > mm/mempolicy.c | 6 ++-- > mm/mlock.c | 6 ++-- > mm/mmap.c | 79 +++++++++++++--------------------------------- > mm/mprotect.c | 6 ++-- > mm/mremap.c | 2 +- > 8 files changed, 47 insertions(+), 88 deletions(-) [...] > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2830,22 +2830,16 @@ static inline int vma_adjust(struct vm_area_struct *vma, unsigned long start, [...] > -extern int vmi__split_vma(struct vma_iterator *vmi, struct mm_struct *, > - struct vm_area_struct *, unsigned long addr, int new_below); > -extern int split_vma(struct mm_struct *, struct vm_area_struct *, > - unsigned long addr, int new_below); > -extern int vmi_split_vma(struct vma_iterator *vmi, struct mm_struct *, > - struct vm_area_struct *, unsigned long addr, int new_below); > +extern int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *, > + unsigned long addr, int new_below); > +extern int split_vma(struct vma_iterator *vmi, struct vm_area_struct *, > + unsigned long addr, int new_below); I just found this change for split_vma() is applied to !CONFIG_MMU, which the definition of split_vma() is not changed, so cause a build error. I posted a simple fix for that: https://lore.kernel.org/linux-mm/20230106171857.149918-1-sj@kernel.org/ Thanks, SJ [...]