Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] bpf: skip invalid kfunc call in backtrack_insn
From:   patchwork-bot+netdevbpf@kernel.org
Message-Id: <167302801577.16346.8234283027258741479.git-patchwork-notify@kernel.org>
Date:   Fri, 06 Jan 2023 18:00:15 +0000
References: <20230104014709.9375-1-sunhao.th@gmail.com>
In-Reply-To: <20230104014709.9375-1-sunhao.th@gmail.com>
To:     Hao Sun <sunhao.th@gmail.com>
Cc:     bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
        john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev,
        song@kernel.org, yhs@fb.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, davem@davemloft.net,
        linux-kernel@vger.kernel.org
Precedence: bulk

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Wed,  4 Jan 2023 09:47:09 +0800 you wrote:
> The verifier skips invalid kfunc call in check_kfunc_call(), which
> would be captured in fixup_kfunc_call() if such insn is not
> eliminated by dead code elimination. However, this can lead to the
> following warning in backtrack_insn(), alse see [1]:
> 
> ------------[ cut here ]------------
> verifier backtracking bug
> WARNING: CPU: 6 PID: 8646 at kernel/bpf/verifier.c:2756 backtrack_insn
> kernel/bpf/verifier.c:2756
> 	__mark_chain_precision kernel/bpf/verifier.c:3065
> 	mark_chain_precision kernel/bpf/verifier.c:3165
> 	adjust_reg_min_max_vals kernel/bpf/verifier.c:10715
> 	check_alu_op kernel/bpf/verifier.c:10928
> 	do_check kernel/bpf/verifier.c:13821 [inline]
> 	do_check_common kernel/bpf/verifier.c:16289
> ...
> 
> [...]

Here is the summary with links:
  - bpf: skip invalid kfunc call in backtrack_insn
    https://git.kernel.org/bpf/bpf/c/d3178e8a434b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html