Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     SeongJae Park <sj@kernel.org>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 25/44] mm: Switch vma_merge(), split_vma(), and
 __split_vma to vma iterator
Thread-Topic: [PATCH v2 25/44] mm: Switch vma_merge(), split_vma(), and
 __split_vma to vma iterator
Thread-Index: AQHZITolqDVQ6iqu60KRVDrk/+ixaq6RpM6AgAAgt4A=
Date:   Fri, 6 Jan 2023 19:20:54 +0000
Message-ID: <20230106192051.2dwszdsitguzxlxh@revolver>
References: <20230105191517.3099082-26-Liam.Howlett@oracle.com>
 <20230106172345.149991-1-sj@kernel.org>
In-Reply-To: <20230106172345.149991-1-sj@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?be7u3/7C7EvbCBuX56tPPa7fXtD590bn4rpmvcgi5FCcDxG3ne9H2YsUiqNA?=
 =?us-ascii?Q?iEkmQcUsTbklYnr4uvX9xKjAHROfWYnpUGp6QyR4ugG2Fp9TOwqlstz4PTEM?=
 =?us-ascii?Q?WjnQpt/ngs5UwfDF7d0NeQHEGGy6m9BPYhHDU3xPkQV70vYpUX5DggqR9Xqf?=
 =?us-ascii?Q?qJ6AziEeEICAhtpylFoZsjtD/7AujDnLtVBScdC0IRTSeIU+ZbCyBxtVT4Eh?=
 =?us-ascii?Q?W+Yi4PuYyxOif1de3CUOV+e7C2qzixIcYiAsUdokWQsEqpoOL+J3YQN5Axn9?=
 =?us-ascii?Q?7/8yAAash7jeELR6Vq7LHXuHPXogOZShcT/faONnoo7l11oTrOb3EJfCdD4M?=
 =?us-ascii?Q?EaSl3Q8+fpPMygyjvT9fkRi26qGlrTwJ2UOUJXUM6CrSs6aOltbI2Gwi9g1I?=
 =?us-ascii?Q?gHdFpTRWJPtwtZgINF0e5XTeinUXqY6HVVjbcrMNCs4sYNDWKe4pvZBWLc+V?=
 =?us-ascii?Q?dk2yYko093pAEj7dqmaquafgz6+1zgKP050SMxMNBhAHFYey89Qgo3N65fHN?=
 =?us-ascii?Q?MuADxot9bTYXKwZDLLLREYuEa7PFMoqBRv2amW0sWQNyPHV0hwYDhQGtIQ/s?=
 =?us-ascii?Q?1WxK5AC1/74OS5RR8J1UtZ9G30el1zx/ovQH8J38fONJOFYnXPXjORabMNPB?=
 =?us-ascii?Q?SSQVwNzlnzzrZ8wKYklfJrhHXcgg7UMKyVpuL2i6um80QQ1ZMMMAY/83lAJU?=
 =?us-ascii?Q?nmXnb6By3Yi56p9nrb81TT+Cz6XwUVS73ttHFGETyZqUUauXo5Vm1JDLU2Dn?=
 =?us-ascii?Q?+6wSFL15cc5C198svLX/j47dw0PM2FOoarj4In/WGfXgO8nkpNqQ4izX6OVg?=
 =?us-ascii?Q?Ns56cf9kw+SZIKrzWkPH01r2M/2E+QaDsPm7dJ+T42vGoEuC6JCfrWMJ0mjf?=
 =?us-ascii?Q?aOqWuDDTgWlOJMmnYrR48HLDbUA8Wlum2EzBJjm5KwUbhH3rawhEJGKP4hcV?=
 =?us-ascii?Q?vLT4VR0Xzeokrwawz6F4a4yfr9Agl0BGzZg1wE4LKzpFYww+dwTSuSvqPmC/?=
 =?us-ascii?Q?sqj0hM7s2gWrlCeGulrGL+TNlOYH5b6WWV5/xJbeRHABsHpwdpO0mOFTbqBu?=
 =?us-ascii?Q?igL+vT/xVQFt2cPnvwrzh2exUI55YZbgZm0P4oVOmr5hGrncXGihDCVNZnU0?=
 =?us-ascii?Q?UeDflv5v5D7ton9IhQlR3ALtZeKpisQBAiu4sPLA6xjQntns2ry4KskxWq0T?=
 =?us-ascii?Q?y+EBiLzgpIPR2k570PlftlZ4Id8gznDKGNckLaY71EECGx7Bb2Teur2O1EGB?=
 =?us-ascii?Q?gcAW92i5Icak+4YtTvPFvd+NUwP2T9Expuk9uRxKvT/gPygU8Bd+CHG5Dv4j?=
 =?us-ascii?Q?Y951DXazDDRBeE2k1+ZW35z9eCz2P5+h9uRt7ndQ1O6JBFLInXyM9IwRcKcr?=
 =?us-ascii?Q?DXFNI5mf65UxybPEukm2LpiKwrus08bLA6r14M/ASt8/AJlu0l6eBfIfT2cJ?=
 =?us-ascii?Q?x4f2hW3CTZuDIfDzybiSiLrO1LZul5v6FHIgMBavGmZZHNBhdSHdqmkUmvMI?=
 =?us-ascii?Q?kRVu1e8MXxhZuElo408tuetXM/l6ueWU3Qopz1bUOG+7VCOhfkssvLNM3gEq?=
 =?us-ascii?Q?dbpMKx78iZC+YH+wxLpBDT3ID6USw2p6M75HxGwpl21nq9kj1wwP+YuidlLK?=
 =?us-ascii?Q?VQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9962353C4793F14087FCAB477A58A58D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kHnSelPQJ0VcmWmsf+fnFxmq08Y1mpnbQ8zJ+/F4iIV+a3SCBeqywjm5Mv467H7xpfza2FHrsn3afFoHGq3+Yy0C8yoDUoh9h4wXG8PfEVCIjX31Gh1HtZenj9EzhwexwYQUOrCeVY103q9vRYGluUMw8/+ubPoho1UrOOursXW8OGVFcBvfR1Ut63sILJwvcA4rSocCDPU3OaHmSSJxET+xf0pwvav+Cffa6dpOGwwYcTsaOBrcO3xW3YE+e54lrP9Act38NkUfcQQQxQvhCX9+uMlTsP/xzLXicea1ODxWwdwAI2WipNliVOe6avOR+6X+ksuEuvIbXwmJJf1sclTiSqJYAcjLwVjPRi/D9hk1uGNRX64sT3u/Akld2OWvCmWwxYKhMP3XZYP+Rs3Gf5L0CEt7hIeS3A7J0IUmoIIghUJahuXHLtCxiyu4qJc8RnGwQ7dB4Mmy/ME5Gg+MYu81yWzafNG5iZoTc/LQ68tLADAhZZdIX2Q7xPHk8YlWh1s4UVvN1PQ/Qy2OdNqevhRyikWAOgdWz18Aev2BdfSCWvGQ+eWgiDrZ/XtDAoVdbaDvkwdtp30iU2NrHbRxslsiFqYX9m7Zt9MOo/l7LydIZ0a0pRUB96HbuerDhybeS86t1+0AmKe6MG134OAzvfmRBpU4oEgOaTiG2gEnjJkENL/DN7xYtzq205xh7/x89rQe0TLM3g4SezOXwLHNtWX77J0MAfsvhfhtDr4X4jJUIpaGJTuicMaDNWyGPVtuArWrEB12ppyNULsYjMKlUfRG984czIkHoQckr1hRLFTdk08sGGSvUqJJ7Y2M8EoZRmHQCZdyRvBe0NHJm8SgZt/XvzMtZikz17Pr5+xnsTaehmGeNyQVN/BJwjpi3YqGBmcH2SewqkzKsHQ0CnYkS6l37TJp68rCNmVS+VxsN/M=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cc0239e-7090-4e49-08d1-08daf01b218e
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 19:20:54.3929
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L+99Wfz/CggCfhjtm5zjy27CWM+XVMRWtG1LYZpJJLfe6i078Kgi1ACnTmM1MBV49IRABN+SUuE3gYaBfGKdUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5294
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-06_13,2023-01-06_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301060149
X-Proofpoint-GUID: _w2uzOgkAOJPnubFEaxsq7fLDyBMU2ro
X-Proofpoint-ORIG-GUID: _w2uzOgkAOJPnubFEaxsq7fLDyBMU2ro
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* SeongJae Park <sj@kernel.org> [230106 12:23]:
> Hello Liam,
>=20
> On Thu, 5 Jan 2023 19:15:59 +0000 Liam Howlett <liam.howlett@oracle.com> =
wrote:
>=20
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >=20
> > Drop the vmi_* functions and transition all users to use the vma
> > iterator directly.
> >=20
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > ---
> >  fs/userfaultfd.c   | 14 ++++----
> >  include/linux/mm.h | 16 +++-------
> >  mm/madvise.c       |  6 ++--
> >  mm/mempolicy.c     |  6 ++--
> >  mm/mlock.c         |  6 ++--
> >  mm/mmap.c          | 79 +++++++++++++---------------------------------
> >  mm/mprotect.c      |  6 ++--
> >  mm/mremap.c        |  2 +-
> >  8 files changed, 47 insertions(+), 88 deletions(-)
> [...]
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -2830,22 +2830,16 @@ static inline int vma_adjust(struct vm_area_str=
uct *vma, unsigned long start,
> [...]
> > -extern int vmi__split_vma(struct vma_iterator *vmi, struct mm_struct *=
,
> > -	struct vm_area_struct *, unsigned long addr, int new_below);
> > -extern int split_vma(struct mm_struct *, struct vm_area_struct *,
> > -	unsigned long addr, int new_below);
> > -extern int vmi_split_vma(struct vma_iterator *vmi, struct mm_struct *,
> > -		struct vm_area_struct *, unsigned long addr, int new_below);
> > +extern int __split_vma(struct vma_iterator *vmi, struct vm_area_struct=
 *,
> > +		       unsigned long addr, int new_below);
> > +extern int split_vma(struct vma_iterator *vmi, struct vm_area_struct *=
,
> > +			 unsigned long addr, int new_below);
>=20
> I just found this change for split_vma() is applied to !CONFIG_MMU, which=
 the
> definition of split_vma() is not changed, so cause a build error.  I post=
ed a
> simple fix for that:
> https://lore.kernel.org/linux-mm/20230106171857.149918-1-sj@kernel.org/
>=20

Thanks.  I think I need revisit the nommu side of things with this
change as well.  I was hoping to avoid that, but it seems to be more
necessary than I had thought.