Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Fri, 06 Jan 2023 20:15:39 +0100
From:   =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     INAGAKI Hiroshi <musashino.open@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values
In-Reply-To: <57f10c5d-2a71-7f8d-e2ab-6e868d8ba79b@linaro.org>
References: <20221012155133.287-1-musashino.open@gmail.com>
 <57f10c5d-2a71-7f8d-e2ab-6e868d8ba79b@linaro.org>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <e8932e3eaf1bd9a690e2f41aad8faf3a@milecki.pl>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Srinivas,

On 2022-11-11 18:41, Srinivas Kandagatla wrote:
> On 12/10/2022 16:51, INAGAKI Hiroshi wrote:
>> This patch fixes crc32 error on Big-Endianness system by conversion of
>> calculated crc32 value.
>> 
>> Little-Endianness system:
>> 
>>    obtained crc32: Little
>> calculated crc32: Little
>> 
>> Big-Endianness system:
>> 
>>    obtained crc32: Little
>> calculated crc32: Big
>> 
>> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
>> 
>> [    8.570000] u_boot_env 
>> 18001200.spi:flash@0:partitions:partition@c0000: Invalid calculated 
>> CRC32: 0x88cd6f09 (expected: 0x096fcd88)
>> [    8.580000] u_boot_env: probe of 
>> 18001200.spi:flash@0:partitions:partition@c0000 failed with error -22
>> 
>> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment 
>> variables")
>> 
>> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
>> ---
> 
> Applied thanks,

has this patch been lost somewhere in the process?

I'm quite sure I saw it in linux-next.git and probably in nvmem.git. Now
it seems to be gone.