Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2885532rwl; Fri, 6 Jan 2023 12:13:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuF7ZZnZZjyTkuCQZl5cl7LhZFGtyHwBNHP6/jLQ7E5ZE6OfxxAsYaSdwiKq26JYvkcCGhS X-Received: by 2002:aa7:c616:0:b0:48e:f12a:2999 with SMTP id h22-20020aa7c616000000b0048ef12a2999mr13416125edq.24.1673035999947; Fri, 06 Jan 2023 12:13:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673035999; cv=none; d=google.com; s=arc-20160816; b=nHDowhFVaPgcdwHxdBF6ymRcfw5pxmlle1o3Sf9jHpakrvNhz78WOHgYnJYhGpL5KO 4vxPyM2Qv2BO/9ChdZbriurf33qFT07WNIHCM3jeVj9VVWRYmpNYqA1UO+39sSegsG0Y zt0DU9in3P9GQ1GSDZzSAgCSRJNLrMCcE07+x1ioDF7c0B8m8AkprPD97kJKDzcuBS2w faws6rS8jExe6kIuWwEe0l2uUEYeiVoX+f+GZLeA1TVQlDMqhDsVTRcTuCVRleS2eFMd kU2+Da//vx+Jvhb5M9Rmb4Adf2vXSdz1Q6MKv4Ddw+FLESeZb4micFhOHSTVv8NnP3LW klYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WDav2tQX4GhlHIZvFHwLD5Ta1F0x4Q4mp0gqLMjRTLo=; b=sa89Fk2lKX3tE1ghUgJ9KvlwjBlTD0pZE+izf6f5SjACwvZiAgBuNOpvNN1RoYS6n/ 8250q2F4Dj9ho8DhsVTB9T/sQh+tQ/cXG46vOCQTJXZLREdh5faO2JVJAfRqZCJkeYvj dT7wi7angjJDO+kbzwnA3b8aeY8s4pSPrsFOhqK+JitKw4pTIjGZTs6mpUt+GJI/dfnD gpM4VZKc6RJ4SuOnqXhtyadLiyKtwNC1kxlJWsJZE7nTm3VVWETomXD/8NKQn0fh4z4m ngAGeY+CjvWbfKZAJwEExD581GUz3IaGSaEk4ZzF7AVPdvhu7TF0uzq0AbvoyxKdZkbq aiHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DyFswvBo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds13-20020a0564021ccd00b004775e6e0511si2433116edb.445.2023.01.06.12.13.06; Fri, 06 Jan 2023 12:13:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=DyFswvBo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235821AbjAFTjM (ORCPT + 56 others); Fri, 6 Jan 2023 14:39:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235652AbjAFTjC (ORCPT ); Fri, 6 Jan 2023 14:39:02 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C6A371897; Fri, 6 Jan 2023 11:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WDav2tQX4GhlHIZvFHwLD5Ta1F0x4Q4mp0gqLMjRTLo=; b=DyFswvBoG8itxv4n8cpLJSuvb3 SdDsVEJOuVuUZmwrvH2iU6foOX8Kn1l+a6FhCSCsUn16wMh7pgQpd7mPvhkitb71EgIHiai5jBAuN 102TfGSJqbJ0VpijiCJAeiI2Mxkb9BiS5z95vTaeBXfiMv+QgQ0hKo3dDrMmwzicEWY7QQv1IH/Iz rzLxBt4HXWG0iuB2zPULiFFdxjNZw3LQMTOT8i2cFuO+OwNYWQKBctv3I5qtYePxkKMbpFQD4AAqN F1J1aneU3inO7/S+WYFDaLQmNQeCv8sQ9NgM7LfWH+lYPjcHcevgoMeFzCCu+OytAynieJkGjYBha Zy/Al2Ow==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDsYV-00HRmd-C8; Fri, 06 Jan 2023 19:39:07 +0000 Date: Fri, 6 Jan 2023 19:39:07 +0000 From: Matthew Wilcox To: SeongJae Park Cc: Andrew Morton , Xiubo Li , Ilya Dryomov , Jeff Layton , ceph-devel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] fs/ceph/addr: use folio_headpage() instead of folio_page() Message-ID: References: <20230106174028.151384-1-sj@kernel.org> <20230106174028.151384-4-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106174028.151384-4-sj@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 05:40:28PM +0000, SeongJae Park wrote: > - snapc = ceph_find_incompatible(folio_page(*foliop, 0)); > + snapc = ceph_find_incompatible(folio_headpage(*foliop)); ceph_find_incompatible() should take a folio.