Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 12:29:00 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
        "LKML Mailing List" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v3 3/6] x86/microcode: Display revisions only when update
 is successful
Message-ID: <Y7iEjDrXLRlwoz0W@a4bf019067fa.jf.intel.com>
References: <20230103180212.333496-1-ashok.raj@intel.com>
 <20230103180212.333496-4-ashok.raj@intel.com>
 <Y7XMtWqSrs0uGkD7@zn.tnic>
 <Y7h5qD43kdPeEgQ7@a4bf019067fa.jf.intel.com>
 <Y7h8dpIQHnL93RdC@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y7h8dpIQHnL93RdC@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LLDpdUcPrtPbqA40JdWVFdkqGzxCBgQuEqKHqnRdzjsZWSdOfuF9cjiR7b/r?=
 =?us-ascii?Q?z1OGXQg6aIAKRczg7FJICyxXKRGMjRcaSiBKv0gH+VnD1YuRinGbHGNTXw3s?=
 =?us-ascii?Q?jaGLYLZIqrmo2SS+PrLU2/W9R80ODg+vXvT8u0q9vBzJ/a6Ux31FWvPaaxwY?=
 =?us-ascii?Q?Ou2Nmhi6S869/Z6B/seDX1WqGAt+E64lO8spwYVp5G4TLxK3sSyskdo0VjHN?=
 =?us-ascii?Q?aup5Rou2kqvsMNKOnFSP5KOZaKyjEK0+xTfh0Kcud6tI178Uo4oOinyAeaxg?=
 =?us-ascii?Q?HJj0y8TsI4GqY70+AIX4+QGVhRgR85Np3Xaj4Yn+lT3RKyuVh5Rcme7fJNmZ?=
 =?us-ascii?Q?I/yD3wXpPlZX5KVt3NyNIErtJ4bVxaUnIVIPojX3JaUXpqsAveTRvDT8h1dt?=
 =?us-ascii?Q?xE9EeTj1E2OWrPRj7giI6hA7GWmvfZTmRWbcuTW+HwTwly1HJJnrsQttDtdB?=
 =?us-ascii?Q?wrZ4wgYwaieZhavahkCmU+tVoiRqyYlJhbA5RyfLfY1QQFIw5tgf1A/XGCJe?=
 =?us-ascii?Q?0ttYWMXVCFMYWQLdTj9g6iZqbDe7MbE4x0kBUm57HLbuduAK+lVM1fy2NEtR?=
 =?us-ascii?Q?+76k3Kh2coXnWvv+eJQKRvUxOh4pw8DJJ1rQEM1z/tAf7Ixk+d5EilhjT1cC?=
 =?us-ascii?Q?Vfx33EdhZhdlwyzybBYq/IPwoXtrcMqan94wkQ8bKOAXuGB4m5FzTBVNOl1g?=
 =?us-ascii?Q?5GeeK5m3kMfY9duA/dBuP6zdHun8+RNxS8/Vnuj5bqtDcOg4nmtbnJy7NC3e?=
 =?us-ascii?Q?SUA0hsYoO09a+PA6CWHd/kAonZUXvEqLjZos5mh0Fx5lqBhNzNVH1M3Il+uM?=
 =?us-ascii?Q?fa1cv52t66SMaY9bxEHNikfv3VAvuKvdzR66jHixnKj/70PDqdnDwzhEuCBT?=
 =?us-ascii?Q?kl8UcJmFX6qitmKftoPDyxMiJ8HXpiiT81p33Y6npQnvAWV1KSQPLUu+/GB3?=
 =?us-ascii?Q?5RQ6rYuGv6wG6OKxhQsQ3STnvOzV0q35woS3ALAfuK8M6lH58yY6NQ38NJMU?=
 =?us-ascii?Q?eAQYTPZblZz0fM7EuWLrO3MeuWaGHrkTDY9vW8IGK6VkSTri9vVZ3PFpHFwJ?=
 =?us-ascii?Q?o6N3aV00mYUJi8nvqcR5g9L+i6uDU2/e8pKvoyHoTOcAxg8mR+0zK8WBmHv3?=
 =?us-ascii?Q?eTiKQHwjsrYp4Qj+ZadnAz7k4js0WIwVkt1YQSrz7rZSvFl+kg+JVbnieQ8G?=
 =?us-ascii?Q?POfNvLoyXHUqTLDhztEvnz9IiTq7NB9Bb2Ke37b7HPo3k0W/sF8uMhaksS4X?=
 =?us-ascii?Q?77kQQsE+3mMUK//XwzMyb53fge1j0eH9cnJK3jtZB8ld2IyzfiYEyItBHc6C?=
 =?us-ascii?Q?l9RGBAxjeNE8D4QrMQn6+bTQsaoF3OmbTzCK1ymnC/281U7ICbBLR0WSPJcG?=
 =?us-ascii?Q?SEb86TlrAYxYzYP/Vz1Kd/8T5irXfX33pHjN+qepV88gL28XXFedhyaFhcGc?=
 =?us-ascii?Q?V4cAXgDVIEb1Kj/e4dCqhMUWXux52Ut93fIsBCWUnFf+n9VkW2wDfxwtGpPN?=
 =?us-ascii?Q?+L5yJDEdAfYX82Vnl398bYq2oN/P62Tep2b7rJCp6VAHLLl+tZZLA224RXuI?=
 =?us-ascii?Q?kmTn9WBlA2wDQqS+jCfyy5S/zlKiK19JdTXoOyeQQtSxvpb3iYXH9FCICO0J?=
 =?us-ascii?Q?hA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd76cec4-bc64-4099-357a-08daf024a7b2
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 20:29:05.0871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZyVEHt6xdvN025Tf1oWe87ylUWjbqLHYI1c/7vmLLu8g9BM+/+cjdizuOIASneVvTIRoW/dxxA9Cy8c+4USMzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6674
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 06, 2023 at 08:54:30PM +0100, Borislav Petkov wrote:
> On Fri, Jan 06, 2023 at 11:42:32AM -0800, Ashok Raj wrote:
> > > 9bd681251b7c ("x86/microcode: Announce reload operation's completion")
> > 
> > Thanks.. yes I can add when I resent the series.
> 
> No, you should read the commit message:
> 
> "issue a single line to dmesg after the reload ... to let the user know that a
> reload has at least been attempted."
> 
> and drop your patch.
> 
> We issue that line unconditionally to give feedback to the user that the attempt
> was actually tried. Otherwise, you don't get any feedback and you wonder whether
> it is doing anything.
> 
> The prev and next revision:
> 
> 	"microcode revision: 0x%x -> 0x%x\n",
> 
> will tell you whether something got loaded or not.

Yes, that makes sense, Do you think we can add a note that the loading
failed? since the old -> new, new is coming from new microcode rev.

Reload failed/completed ?