Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230106220016.172303-1-nphamcs@gmail.com>
In-Reply-To: <20230106220016.172303-1-nphamcs@gmail.com>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Fri, 6 Jan 2023 14:03:40 -0800
Message-ID: <CAKEwX=Me4JUhqmNa8k2SOmipNF6+dD5V50_mMmjWjYH0-rYwEw@mail.gmail.com>
Subject: Re: [PATCH] Docs/admin-guide/mm/zswap: remove zsmalloc's lack of
 writeback warning
To:     corbet@lwn.net
Cc:     hannes@cmpxchg.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        kernel-team@meta.com, akpm@linux-foundation.org,
        linux@weissschuh.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 6, 2023 at 2:00 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> Writeback has been implemented for zsmalloc, so this warning no longer
> holds.
>
> Suggested-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ---
>  Documentation/admin-guide/mm/zswap.rst | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin=
-guide/mm/zswap.rst
> index f67de481c7f6..6dd74a18268b 100644
> --- a/Documentation/admin-guide/mm/zswap.rst
> +++ b/Documentation/admin-guide/mm/zswap.rst
> @@ -70,9 +70,7 @@ e.g. ``zswap.zpool=3Dzbud``. It can also be changed at =
runtime using the sysfs
>  The zbud type zpool allocates exactly 1 page to store 2 compressed pages=
, which
>  means the compression ratio will always be 2:1 or worse (because of half=
-full
>  zbud pages).  The zsmalloc type zpool has a more complex compressed page
> -storage method, and it can achieve greater storage densities.  However,
> -zsmalloc does not implement compressed page eviction, so once zswap fill=
s it
> -cannot evict the oldest page, it can only reject new pages.
> +storage method, and it can achieve greater storage densities.
>
>  When a swap page is passed from frontswap to zswap, zswap maintains a ma=
pping
>  of the swap entry, a combination of the swap type and swap offset, to th=
e zpool
> --
> 2.30.2
>

Link to the patch series:
https://lkml.org/lkml/2022/11/28/1140

And the suggestion:
https://lkml.org/lkml/2023/1/2/823