Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 21:47:11 +0000
From:   Mark Brown <broonie@kernel.org>
To:     William Zhang <william.zhang@broadcom.com>
Cc:     Linux SPI List <linux-spi@vger.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        anand.gore@broadcom.com, tomer.yacoby@broadcom.com,
        dan.beygelman@broadcom.com, joel.peshkin@broadcom.com,
        f.fainelli@gmail.com, jonas.gorski@gmail.com,
        kursad.oney@broadcom.com, dregan@mail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/16] spi: bcm63xx-hsspi: Add polling mode support
Message-ID: <Y7iW38Fsj0nIewDm@sirena.org.uk>
References: <20230106200809.330769-1-william.zhang@broadcom.com>
 <20230106200809.330769-8-william.zhang@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BZ9YTddyDyFA6Ziq"
Content-Disposition: inline
In-Reply-To: <20230106200809.330769-8-william.zhang@broadcom.com>
Precedence: bulk


--BZ9YTddyDyFA6Ziq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 06, 2023 at 12:07:59PM -0800, William Zhang wrote:

> Polling mode provides better throughput in general by avoiding the
> interrupt overhead as the maximum data size one interrupt can handle is
> only 512 bytes.

> When interrupt is not defined in the HSSPI dts node, driver switches to
> polling mode for controller SPI message processing.  Also add driver
> banner message when the driver is loaded successfully.

This should not be something the user selects via the DT, if the polling
mode is better then the driver should just use it regardless of there
being an interrupt wired up.  Generally there's some point at which the
benefits of polling become minimal (and the costs more impactful) but if
the DMA setup is as bad as it sounds then the driver should just ignore
the interrupt.

--BZ9YTddyDyFA6Ziq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmO4lt8ACgkQJNaLcl1U
h9BtSwf9EDCxIB7GCjjTZUo4CcwKhiubo8/b3JnQ1i23/YpKRG3de6GCFJ1NFJKw
DhOMbnblhK1hc9JJCAkK0CcDC4wkCrdXYicBxkTNCUBibzkdKwNHkjvfM8WrP9dJ
uFO3J1hFO4F0E/MQ9E5DSeIuVXXw6QXKtYmteT11umGjZhmRX1xUWH++9S2T4zse
c4c/HqoPWEElISgDKe7hyVnWmLpO1vQhPb1gkGd8NtLEv+QS3l4yV3k+qJQvHF85
bWCrWA+YT3UNag+lUlh4LfyOD8o+4i3VxcDabATMNg47nrdk/rMu3EOPXc2YIr3H
peG2shfjq2Z6KLbMf/hbqeN695vbgg==
=eHcH
-----END PGP SIGNATURE-----

--BZ9YTddyDyFA6Ziq--