Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp3056876rwl; Fri, 6 Jan 2023 15:04:08 -0800 (PST) X-Google-Smtp-Source: AMrXdXuLf1oOvFzhEER0DIeqjeb0iTuYz4adSrQ7JP1p9w7ThQqNFTkcm1S0RZmQrvvMI5GXfrP5 X-Received: by 2002:a05:6a20:8341:b0:ad:a5fd:b659 with SMTP id z1-20020a056a20834100b000ada5fdb659mr52791141pzc.7.1673046248252; Fri, 06 Jan 2023 15:04:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673046248; cv=none; d=google.com; s=arc-20160816; b=rbTjzaJgaQDi4tlpLGoceZRxi/x+eV4Ayi5h2N95mJVeTv6Ano1mee0x57QRhIHHtn PedUB0T61z/o1VgiJtNyFRZ2cz7hOWH4CpClt5ZtYPsKuh7LKC/uWzsE08/3yF7MuNlH J0DEYn+dO7LP2QmyYQ4G/r1P+2jZHGxiLzkSA66NPYHB4B/5HAEx37NKyED7c1jizmb2 9rktWn7/9UP6yXzCgkUCXQ5yjKDTELA5LgIVA47pmYH99QKnEQrbNSkjPDJK8JdeaO9X Brx3klfFsNxvQjDDUYD3zXyWfWc9FrV5Hqm7AGV+brHb/FEK/2XBJeeGiOjyPi3lvqHC 9D+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=QXQOUJjcoX1hrsbbTN+Z+gwuy5Yx5WlxprMyzhgXuL0=; b=Xm3ELMt/LABGh511Hwu5A3rhC5H0lvmwLcrQ4PeGYueV5yTB3gi9DvBbe13IeFYI1B HCox1XVs+AQZnftjPZNYZ+GmO1vPwnyRU9Mw5oC/215te/u+7eL/EhiSF1IRbSH2YYR2 FM+qnEJfqCufeenAeXQZeRyH/NtYNw2crZ4cnrAyUr2Wi1emLXy8tuETPgChsEkUmdJB VGR0kLECswHW4BBo6mWPVAscoZIaJy7iU265xB1gVb5WyUAMbUdaFLHDwz97zoVC6DAb /J4d4grqZUUQ43RZypAMkQ6zNPUm8WlivOW8RxvvQKUnsE+pnV+sZ72ZSP+52rRHcsfl t9Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=FSwATMmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a63ba49000000b00478ba6cb230si2901248pgu.131.2023.01.06.15.04.01; Fri, 06 Jan 2023 15:04:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=FSwATMmk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235541AbjAFW2X (ORCPT + 55 others); Fri, 6 Jan 2023 17:28:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbjAFW2U (ORCPT ); Fri, 6 Jan 2023 17:28:20 -0500 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7FC085CA8 for ; Fri, 6 Jan 2023 14:28:19 -0800 (PST) Received: by mail-qt1-x835.google.com with SMTP id h21so3265824qta.12 for ; Fri, 06 Jan 2023 14:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QXQOUJjcoX1hrsbbTN+Z+gwuy5Yx5WlxprMyzhgXuL0=; b=FSwATMmksAKMdpu1wQNSAU4HfcxbtJpqP5jg4jxAia7ZjIAJt4LpHBViEiX5ZkvhWV XA077dHR8grrfxkhZnG7h3W83Y6u9reeX0IgVJqi16hhxZZAnt1gx0ImUTDz0+wZcva6 cB9bwoRmvnDNak/FU5AzQ18NzyvaFmMkZwKoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QXQOUJjcoX1hrsbbTN+Z+gwuy5Yx5WlxprMyzhgXuL0=; b=cNvLH4g20cnf/kUlWYGMzSFtDTcinbHXTGErEBUwmEm3TfvsycwoPTF8EtNR0uMqHw ZefZEfxYKJHkN1cK4SEBfyuOh8TyGHEQWoDXHQ4dNAKy2Odnw+Tg7j7E1W1cIMPIym7Y fKf/Ln2I92EyAONO3ZCCglkmRNhs8LTs89C8kaZXOHrju18QOx/F6erEmmbVxpT0Q/p+ aQCBwbOHk1ff6myurn1IGHORG0qDJgOkADJWEVKMRX+o0qViALGKurQtyiCLl50zUwgB OTWZbhcwlBJ7DmNo0VXapp4LfcC+F6mpmSs/RNiKXBFOX0gKh4SOhIkAByXHTdV1b5lE VD5w== X-Gm-Message-State: AFqh2krAy4qlbh9V41XSSwBXnTB3qKhpOffCO4A1257R5cmkVWrtbsxr CSCSRVRvowcA2fRidMlneCdWgHHggjyt3ZXv X-Received: by 2002:ac8:6f19:0:b0:3a9:84bd:7cc5 with SMTP id bs25-20020ac86f19000000b003a984bd7cc5mr86754918qtb.39.1673044098777; Fri, 06 Jan 2023 14:28:18 -0800 (PST) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com. [209.85.219.53]) by smtp.gmail.com with ESMTPSA id bj3-20020a05620a190300b00705975d0054sm1241199qkb.19.2023.01.06.14.28.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 14:28:17 -0800 (PST) Received: by mail-qv1-f53.google.com with SMTP id i12so1957616qvs.2 for ; Fri, 06 Jan 2023 14:28:16 -0800 (PST) X-Received: by 2002:a0c:df09:0:b0:4f0:656b:c275 with SMTP id g9-20020a0cdf09000000b004f0656bc275mr3791255qvl.129.1673044096460; Fri, 06 Jan 2023 14:28:16 -0800 (PST) MIME-Version: 1.0 References: <20230106030156.3258307-1-Jason@zx2c4.com> In-Reply-To: From: Linus Torvalds Date: Fri, 6 Jan 2023 14:28:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] tpm: Allow system suspend to continue when TPM suspend fails To: Luigi Semenzato Cc: "Jason A. Donenfeld" , Thorsten Leemhuis , James Bottomley , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Jan Dabros , regressions@lists.linux.dev, LKML , linux-integrity@vger.kernel.org, Dominik Brodowski , Herbert Xu , Johannes Altmanninger , stable@vger.kernel.org, Vlastimil Babka , tbroch@chromium.org, dbasehore@chromium.org, Kees Cook Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 6, 2023 at 12:04 PM Luigi Semenzato wrote: > > I think it's fine to go ahead with your change, for multiple reasons. Ok, I've applied the patch (although I did end up editing it to use dev_err() before doing that just to make myself happier about the printout). Linus