Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 15:57:13 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        tsahu@linux.ibm.com, jhubbard@nvidia.com
Subject: Re: [PATCH mm-unstable 3/8] mm/hugetlb: convert
 dequeue_hugetlb_page_node functions to folios
Message-ID: <Y7i1WTtnjEoGM4he@monkey>
References: <20230103191340.116536-1-sidhartha.kumar@oracle.com>
 <20230103191340.116536-4-sidhartha.kumar@oracle.com>
 <Y7SXXF4sGEjR1um5@casper.infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y7SXXF4sGEjR1um5@casper.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4Nohz7l/QlE3RjDonSrGyR+paal+e9Hiht81S0dHU0+yfUn5sk21T9jXg8gf?=
 =?us-ascii?Q?LkRPKYTtMob4v14JYu2QeWO5kgPg1MXYrrTvVc/cSPD9Iy0nfjuhMj8AfdSa?=
 =?us-ascii?Q?OfkZYSkBqNg9opo4JXPciTiJruou4eNuoNZtKYeDMwcxff+r7+Ga3gCWG+EN?=
 =?us-ascii?Q?ireZCVFsGlITqb4rSDZ+CkT17y3JRyBlZrLSQpeVA0cdICaZrFdWGe8QvPX0?=
 =?us-ascii?Q?rKF8Ed4Z//PrDfcFUe3TP3J1xX/Jxhlh6dDoDBfQMWEqj36sEovMTQgGw7Ya?=
 =?us-ascii?Q?hU1Lz+kL0O/AHQeUX6nNGCk30ESjg4UJ401iteROg6nFGgFyOgrEbBTqHRju?=
 =?us-ascii?Q?fCJAhTeB7q0u7Ni2pJvUYf0GxJ63gDzy2O6HHTrCf98kVAVa6xzbjV30LsHX?=
 =?us-ascii?Q?LM2TPFXX3t7DdLO/HEYJt7iJAQ45yLiqqNBZ6aIp/H6OXM6CftkOaJR6UPxV?=
 =?us-ascii?Q?X/xprrzt6Lvl704cOVyMe52DFaT6+AVlYsIrCK6+frC7W9KayL40lYrRZpAE?=
 =?us-ascii?Q?joe7WYAUy/DxEhnX/Lx+Rr/4c8QpjqPQwCyx6134Gq7DhFg8FcHTUb/ybtQh?=
 =?us-ascii?Q?kP7SaCxZ2vV5RxOD33uw9OJSsNP2XfpRoJjyQ6agkmeydjsQI50H4SHDkCD6?=
 =?us-ascii?Q?wxdr8os1qT4v6n/bilzSEztvF84m9DsrsckhwOd732OIK7YESabm7bkyM0XI?=
 =?us-ascii?Q?04zrqIHcVGsCU1T4+2BTiZP9CSBtoX1bDq3SN589mjTbVp+AAWlmXeuGvY4P?=
 =?us-ascii?Q?F54lbmhPfBc3hOBzBx2hVi4fZ4KqwDMCmzyZbOxgmpoMG9mG7qu7XiuTs07/?=
 =?us-ascii?Q?peSX7MyryX7/GZ/FoysMjxXjNCglLeM2lzgrinv2L9i7Fdvd/Cd3z+H/+qPc?=
 =?us-ascii?Q?rdt2vaOU2R0VkgeFl5DA+IT7DVgDnHJS6KzmrJx9JpS3NyCeKAH2DBaGXQKD?=
 =?us-ascii?Q?HJvMD4q/QPTzzGgiulA/+7lj2kCJmNPTBNV1KwtEguRzhjB9veE58aYBAB9G?=
 =?us-ascii?Q?1xtpN9RpF0YBuUctY/7Nppzczs9cMT/Rqrof23ZtEf1pgLbBT1/afsfGyTnI?=
 =?us-ascii?Q?cTzlOqWbGjMz6lb4z0qfoMMYT63F6ZfNhE2yYgmLqzRdbnVI7kM80xkNrkOG?=
 =?us-ascii?Q?uw3aFDP+p++hGH+EQxDyYyrZiG+jPafKarhkrCMC3T0SIHiysdbSrv9P36Tf?=
 =?us-ascii?Q?c407an8//XVEvGgA01Pv2U12mh9FsEDcLcwgNR+DUAa1N+61EW7DUaNgZa94?=
 =?us-ascii?Q?qZqDvGqjDv3uvAkQM4Y6X77nXLceqCqViniFoh6PZzSO141o2EMCjx08ZbSF?=
 =?us-ascii?Q?yi26hwqlY1y/XIJw8y1bTFqgoNVMHvxN//8WU6MaiUzWqDaOd1z8rkdfVWPB?=
 =?us-ascii?Q?jkgrZ6QiWXO7i+69ZLFSXn/6QPj3wkd6q9uTDM0ZHNXLJ8ym/PJvhbOgZ5l5?=
 =?us-ascii?Q?/TwwNIGjus6o4UNqbBK+/4CV0T4+/zT8rwNLjNgNXVb/MXVgN8xa9INOybOK?=
 =?us-ascii?Q?s3Nz6VfhcW9OdaF4nTtMxje8oE4C8fC5uIuC5cw6fhbgVYw/MOFIj+QiJeqi?=
 =?us-ascii?Q?i7eLaXeiSLrew8sGcZjvv9+XAgafJ09OVZjXWQTFNfWyFgV4p4kvDxeBcNiG?=
 =?us-ascii?Q?Ag=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?6gHNdrIUSyOymTkxiJGDNXkj1xtHZpZUT2TroGTHPytC2mGkiwkyzBG0J25i?=
 =?us-ascii?Q?0+4DDNmpbSutFZ2ZlWl2I+GIDJMHKXPmTs2ASPWgc5H/qU2PYlu2wB0Sg5U0?=
 =?us-ascii?Q?095tuviUUuDXslaLQ59VcgX+3kd5cMG0zUkh/KakPJW+E4MVND+9JIGwisLA?=
 =?us-ascii?Q?AccwW37wo6MyM8a4OfiVLpZQhzjfeYKdOdqDFMsNTEfgv/1ptu5rY/AMxZBF?=
 =?us-ascii?Q?MGHFoTyPguu6iIW6JOHoAxJF0SPsK7g1CySdmfospYAAtJ02C7Q9hp7YGU23?=
 =?us-ascii?Q?hRJiGPI1A6fltgMBV0s2W0xTksVh33hdMKXb3V1EZL9Eapu1xSrrsW8s0NIu?=
 =?us-ascii?Q?ckBeUjwzq/a+JUjWDhYrcz53/BC3YjfoVKTi+HDGpfXGa1RWrmQnp5cJKN3u?=
 =?us-ascii?Q?muh+HOaQmtf4hyeUCFl7VcVjSJR84+I94gHxcWnsIC9Jqu4oP2R12ROVs4ZG?=
 =?us-ascii?Q?sd3LsbBj+Fic7MWVW3qWVkgShJNWVOWR5UmB/2LsEG1Qy9aytlBZdcWNvso/?=
 =?us-ascii?Q?C4B35b2s4QUAGZlKaVo0uvsPRLF56GQ+VIFmcS5wunicGA+YTr0aK8uAQ8CO?=
 =?us-ascii?Q?eoLM4wmn8KTKtJjkd/bVeBm6ZnfHAcfd31q3uO2so1NO3Zdu1nsSCO43Kh/A?=
 =?us-ascii?Q?48BOgtkcGyvFmikGBIzqygVW/vyDKJ1ZHTgngGvOY137R6wYSWdI6oXcgViO?=
 =?us-ascii?Q?2fYDgF52htN9ZeoIge5uSG8irl4k98bVtDo9JOcuUSttVkohx8YHvByIwfDS?=
 =?us-ascii?Q?K4MDEuNMUsGX0KqB1gZ5Fm0GogYCrzhCBFZ8SZsmj35JVIPKJsEtCXvtgg6l?=
 =?us-ascii?Q?NzE+Pvwk5rNiAv45EQptPtZHaMlr8FvS+0cSZnlgP9hCrptRjvsqXIK9deyU?=
 =?us-ascii?Q?5K41HeuR7mYokHvo49x0XxkTbkYGVEajsRqXoig9hvwxg8RfALc+hXFmpmpR?=
 =?us-ascii?Q?dpY87yqXPoSMbjIo4wo06MBJmTbOL5XW4u3BxrAcfcE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1f847c-bb1c-4a17-b27f-08daf041bcd5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 23:57:15.9413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /OsGuxu9/ps0Xtv6buuPl0EseDO89HQUZv5SEtxSOJ3WLpB1RO8MBVEUddn03G2Jcih9qNofoXUDOcErfGysCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5817
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-06_14,2023-01-06_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301060187
X-Proofpoint-GUID: OqZHdekXBqd1uh95j_yAMRZA51Ts3fzo
X-Proofpoint-ORIG-GUID: OqZHdekXBqd1uh95j_yAMRZA51Ts3fzo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/03/23 21:00, Matthew Wilcox wrote:
> On Tue, Jan 03, 2023 at 01:13:35PM -0600, Sidhartha Kumar wrote:
> > +static struct folio *dequeue_hugetlb_folio_node_exact(struct hstate *h,
> > +								int nid)
> >  {
> >  	struct page *page;
> > +	struct folio *folio;
> >  	bool pin = !!(current->flags & PF_MEMALLOC_PIN);
> >  
> >  	lockdep_assert_held(&hugetlb_lock);
> >  	list_for_each_entry(page, &h->hugepage_freelists[nid], lru) {
> > -		if (pin && !is_longterm_pinnable_page(page))
> > +		folio = page_folio(page);
> 
> I'd argue that you can pull folios directly off the hugepage_freelists.
> Since they're attached through the 'lru', you know they're not tail
> pages, because lru.prev aliases with compound_head.

Yes, then we can get rid of the local variable *page.

A quick grep shows only the routine __mem_cgroup_uncharge_list() does
this today.
-- 
Mike Kravetz