Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 6 Jan 2023 16:15:36 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, tsahu@linux.ibm.com, jhubbard@nvidia.com
Subject: Re: [PATCH mm-unstable 4/8] mm/hugetlb: convert
 alloc_surplus_huge_page() to folios
Message-ID: <Y7i5qODkPz1mcow/@monkey>
References: <20230103191340.116536-1-sidhartha.kumar@oracle.com>
 <20230103191340.116536-5-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230103191340.116536-5-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M9zNlpy7MVCXY6r3pxTmT6n7typF6vkoh3EVktcJAzW1H451XaRv+quErhFy?=
 =?us-ascii?Q?xiD74vILp/sC0CamRoFbDqPN9O2wAjaTncEHDly0awkQaP0DLdnM7vaFM+lo?=
 =?us-ascii?Q?GnchT7BScLkHLQbpSS3zBjspGEqDs/m9cStmqh2bkBc6U0E52yQBdHz/T/VN?=
 =?us-ascii?Q?Wb87nJ18gULTP6XRWDFljYcR5PPfPXqwZ76UEBQsXLO+o93Vxk6QeM0q59n9?=
 =?us-ascii?Q?THdk7fWT4RwajDrzugCx0EvqT8cmtYOc8bYz6msRXbiiMGV3Me5y/l/G6eQZ?=
 =?us-ascii?Q?mcm14hgWhy+0yl6du9X6pFTKTL6/v4limwHFCZvra8cTLARBTp5XskKHxvIa?=
 =?us-ascii?Q?ZHs5TJE5s4UWp5TGohEKJlEmfynGPm7HSut+VJEZ8GtcLwteIlunp180HCfA?=
 =?us-ascii?Q?BcfPpWeZFSoPbt2LAfTtkUHgo5MA6RqDT7ljnoVB1jf57UV5cVxdsONeWv5f?=
 =?us-ascii?Q?+lKimRkIBQEMsuomIdzt5emxH2aW11x3vhudGN/X5daXoBiD5s8IY//5o2UK?=
 =?us-ascii?Q?AtdKofOgRs96Yq7sOHvL/bvCd3TbkXlW8AuZLjTm064b2bj/qkWV9mAg5mEJ?=
 =?us-ascii?Q?QXv7UyNppuOdLUHWiTsjUyB6+tWKw6pRHfdgM0m9FWABBEJp+TgctmyWV0eH?=
 =?us-ascii?Q?GhOuicNddqfjiNWyiI5fAy0fCMLGd+FjzFpOKtKCKOoWoyzK/Rqi8ybbc7Q0?=
 =?us-ascii?Q?Au7GRBOhtfu/xLDLfH+MTLA3ad5KsWsRpkNQmOGYCL8eiHrGhOeJHPUuiyac?=
 =?us-ascii?Q?+SfB2qTDVCXo1WYZTOGHgg1x7Tj2H9E8iNzqSqHXsGfFEVtT1DcO2dU0IFmc?=
 =?us-ascii?Q?edUEtQLqhqZHjKfQ/JBim3ApAX00ncQtV1H+z+XbKmQPOKMEGoPI6eMFEDKv?=
 =?us-ascii?Q?YE98w3TTboiaqgNRUTh4wIxzMTS7ad6x1MIUvbKoc2kQ2Mh1Pz5W/IpnTZDA?=
 =?us-ascii?Q?1dC8kjN5U8WZThBDLVl+K8oj31Gp7vRtYsNIg0XEgT3JtsyQJQsgetRsroEg?=
 =?us-ascii?Q?xItki0Zm714nVQYL1CAGtvK+aEtEfxk6x+VvAjA8kwe5yweVKFEHYKgLu858?=
 =?us-ascii?Q?CtU+iQ1/8Ev/yuTmXYOYY1euVlsP94ROxrIIUTNiLgL68Hpld6VYyFL1ph4v?=
 =?us-ascii?Q?1FYAigI1RMvlHSibOZh4kdAsYd1dFnErJjblAdG07if7kRa+mYdDZGp8l7HG?=
 =?us-ascii?Q?JbZKTCNN3NF+OxnbkrWXQZt4GOptKAKoxdh4rNSDEq8F6tjWqLxwkn31Q3VV?=
 =?us-ascii?Q?t3avRIfAn/LARksNwyJwKOD2tHsyUDU+ac3jwjUXxmGz+gYwgJgidbmfCqbW?=
 =?us-ascii?Q?Ftj21LHHCOsswDG7w0RJ/11BRJ4IYS34vt9mNAJEPp139RG09pw1OAQE0801?=
 =?us-ascii?Q?bl56bzDR2fHBYJkkiGIxNxK3Wi1hR/nZfurJKjQHnSfdlUJLcBXH+4AXsyo2?=
 =?us-ascii?Q?UmF14jj1pi3x8aZ6kNARcd3E437tbMcBIQVg3Y3ZGr54YzXdJLSDBRi0ddSk?=
 =?us-ascii?Q?bfg5BIoWkqV6VEOa0xdq5fP6SE3rGN8tyMI99oluApcr3KZhOwZHYTOjjy3z?=
 =?us-ascii?Q?aXz9qMOzq0tJIJwljAe7pVwY9lsXTPzAKf5TKWJBO/TuPkhU+n27Mtli/mvq?=
 =?us-ascii?Q?gA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?vUAuFvmMrPA/7X71ZFggRD3BzPh92j9S96b/xUStPUzE9qICFTof+P+gSa+A?=
 =?us-ascii?Q?x27g/1qFA8q3f1c+JtFGo9fjFwsTNa5UXQ81tXwtQJAC7d1hVV2tA3BA5UVE?=
 =?us-ascii?Q?Hzn57JNQuzG8iYmzqdh6rVx/b3ZZdmhZtRnkE+CT7f9W5VSgRZW941Y5N716?=
 =?us-ascii?Q?jehio36buESA0jUDw68FxiKKJ1k2grg7u64avATokkyWrusT6Tz2EIXh4mvX?=
 =?us-ascii?Q?xLfrPZyihSXdm7wS5Ewltdnb/U0R7DTYF0wGLrftHMxgN3IMZ86fqHhyb/oD?=
 =?us-ascii?Q?GWqW9pgnG8oTnlvsJPsS8HgiALLmydHQQ6BM/KLvbD3pOIk93ugZA4SU0tsT?=
 =?us-ascii?Q?kDRih6wWOUWdm3nyrLmFvW2wwjP0sEFmJAxtu+9EIsK2KoJVySIz6girQ/Te?=
 =?us-ascii?Q?WW5EZg4Nhrc/SOOHdTr+yIyQ3w4nergPxFnrcJxSzWOhC58eYZuyrC5bh0Vh?=
 =?us-ascii?Q?cMcr7EDskoxVU0eBTYkH6pua9ltUtd8vyGoWc5eNG1XVuw4G9rpRR/lWswEF?=
 =?us-ascii?Q?vE4CmzebtVPOgn8uwGrVT4+UJwnXCUrRZ+LJjU76mV6pE3c/AlH9l7ySjxiY?=
 =?us-ascii?Q?6EOGx6bUkqaCC1yjhDOYzvinDxYfrHKItTdxOuD0mRokBdUXfON42+Jt1iZA?=
 =?us-ascii?Q?XXHjxhSzKav1yDwPtYOqUynBFNWFtRFmeIlulGFQzkt093d3+N8cRzXGjGnW?=
 =?us-ascii?Q?KkudHu7gXEFaFj9jYV+XC7zj5Cx058vK8GbvSGdAVbWLXJU+KT0aIcxQS6pe?=
 =?us-ascii?Q?/4wqKf7lnxNjwAeNdDNbn75LYPIOPWS2XlUr8p90r0cvEpnc82BRxIYbrRrT?=
 =?us-ascii?Q?u7KUsmy2r3ZhrzdLmSMPiaAPYWJ0X5ciPOUsNN7EB9foSN2D4/v3yzIsVRCd?=
 =?us-ascii?Q?yfP2XzNmkfPZFlqWjOa1CEBQY2WjIS1D7C55WSwPSrLmiSAiRQoXllNVQbkA?=
 =?us-ascii?Q?OvvWLOdArU1sz9VfOUT6/6U98bzbgn4r3EsL65z6Onw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5de9e1b-0c54-4738-cb36-08daf0444e49
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2023 00:15:38.9978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XQ8xO+VFbiyV6Vo0P8v/WBhUcfHFJjyPFES8sBYdMvkOOcqR/jUkVei+dcarGVfGC1ARxSZ2yOhXtI92jWnW5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4263
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-06_14,2023-01-06_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301070000
X-Proofpoint-ORIG-GUID: YiEKvJMAiExP1fXV4XdkgIqt__c5vlI_
X-Proofpoint-GUID: YiEKvJMAiExP1fXV4XdkgIqt__c5vlI_
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/03/23 13:13, Sidhartha Kumar wrote:
> Change alloc_surplus_huge_page() to alloc_surplus_hugetlb_folio() and
> update its callers.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  mm/hugetlb.c | 27 ++++++++++++++-------------
>  1 file changed, 14 insertions(+), 13 deletions(-)

Looks good to me,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz