Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756817AbXHUJgQ (ORCPT ); Tue, 21 Aug 2007 05:36:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757384AbXHUJfF (ORCPT ); Tue, 21 Aug 2007 05:35:05 -0400 Received: from mail.renesas.com ([202.234.163.13]:47444 "EHLO mail03.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757355AbXHUJfA (ORCPT ); Tue, 21 Aug 2007 05:35:00 -0400 Date: Tue, 21 Aug 2007 18:34:45 +0900 From: Hirokazu Takata Subject: Re: [patch 12/23] local_t m32r use architecture specific cmpxchg_local In-reply-to: <20070820201827.341565823@polymtl.ca> To: Mathieu Desnoyers Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, takata@linux-m32r.org, linux-m32r@ml.linux-m32r.org Message-id: MIME-version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-type: text/plain; charset=US-ASCII User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.4 Mule/5.0 (SAKAKI) Renesas-ECN: H07-0010RT References: <20070820201519.512791382@polymtl.ca> <20070820201827.341565823@polymtl.ca> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3090 Lines: 74 Hello, From: Mathieu Desnoyers Subject: [patch 12/23] local_t m32r use architecture specific cmpxchg_local Date: Mon, 20 Aug 2007 16:15:31 -0400 > On m32r, use the new cmpxchg_local as primitive for the local_cmpxchg > operation. > > Signed-off-by: Mathieu Desnoyers > CC: takata@linux-m32r.org > CC: linux-m32r@ml.linux-m32r.org > --- > include/asm-m32r/local.h | 362 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 361 insertions(+), 1 deletion(-) I think this patch looks fine. Acked-by: Hirokazu Takata BTW, I need an additional patch to fix a build error, caused by the above patch. -- Takata [PATCH] m32r: build fix of arch/m32r/kernel/smpboot.c This patch is for Mathieu Desnoyers's include/asm-m32r/local.h. Applying the new include/asm-m32r/local.h, inclusion of linux/sched.h is needed to fix a build error of arch/m32r/kernel/smpboot.c. <-- snip --> ... CC arch/m32r/kernel/smpboot.o /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c: In function 'do_boot_cpu': /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:279: error: implicit declaration of function 'fork_idle' /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:279: warning: assignment makes pointer from integer without a cast /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:283: error: dereferencing pointer to incomplete type /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:289: error: dereferencing pointer to incomplete type /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:290: error: implicit declaration of function 'task_thread_info' /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:290: error: invalid type argument of '->' /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c: In function 'start_secondary': /project/m32r-linux/kernel/work/linux-2.6_dev.git/arch/m32r/kernel/smpboot.c:429: error: implicit declaration of function 'cpu_init' make[2]: *** [arch/m32r/kernel/smpboot.o] Error 1 <-- snip --> Signed-off-by: Hirokazu Takata --- arch/m32r/kernel/smpboot.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/m32r/kernel/smpboot.c b/arch/m32r/kernel/smpboot.c index 9dae410..b41aa78 100644 --- a/arch/m32r/kernel/smpboot.c +++ b/arch/m32r/kernel/smpboot.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include -- 1.5.2.4 -- Hirokazu Takata Linux/M32R Project: http://www.linux-m32r.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/