Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp3458233rwl; Fri, 6 Jan 2023 23:38:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXvuwf8VVRXHQM/zQnuQtj3uaJUbFcOm4hBMYX9soxyLXgFWqE++7JOTI2aJoV1caFITlYnQ X-Received: by 2002:a05:6402:1c8d:b0:498:2213:d201 with SMTP id cy13-20020a0564021c8d00b004982213d201mr882441edb.15.1673077134499; Fri, 06 Jan 2023 23:38:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673077134; cv=none; d=google.com; s=arc-20160816; b=K5dQRrCapaETVkHw9th61RNfupueoRTRzKIF0YwEtebnsTZ90hiT8YUjt9d3jb38Au NTEUVUC9FcZPRSyv2fry3mE9SyFw0tsrsJuoxy7KGQru2CGN/X3g2jugdl1ibhtPKGm0 se5aLTfMQDO+z1OgdY2bpxkyGNNFSo1q+87dCjxfIr24R4zJye5z3y2++q5INzSSA8OD aaY7iW/EJV2TMXTSZvEY5gv51BJ3rxUkKfeEPmhGPEVWhW6QcEw+On0THPp3Je+lpH3V im7He3s0OeS8vt3OWWHDf63ODNFoU1dOZcsTOoKZdU7hBhuXtgI5vQjHn7x5RWOz+hNE dJzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=3/Xs4DOyXBKpscT+9J+nqUgMzxw2RN22hwq0uOO1M3Q=; b=qdVypg3qk7jTV0vj8bwkKzhsZgk3KHPPPVb8ZsoCHIgSL3O+CR3O2lihyRAFiZvkvy Pfj2zV/SBvNQiXyZzfgwjtFqOveFJAikjsgq91+9uZL5b819xswcQ9qSMkTRQttNLeWv mLCILbnIRm35iCD1/L7rr+9fuwTNWCE4yTxZcbg4ZOA2MgjsQ626ENFbKdyeSR9P4xQa udIKjpq3Q5uwqbGe9zYkcej4tQsgIcTmMBNi2If92+YytHC4odiHVZmRzmHKjxbVSKkM /YirzBJevae2QRKcBYpWv1clAeMA16+5bN9iL0hLNtKQ81uwqgjB+5zhXXUqLVPeqn55 Sz8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a05640250d000b0048ef66aa00esi4467910edb.183.2023.01.06.23.38.41; Fri, 06 Jan 2023 23:38:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229898AbjAGHJE (ORCPT + 55 others); Sat, 7 Jan 2023 02:09:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjAGHJC (ORCPT ); Sat, 7 Jan 2023 02:09:02 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B75943DA3 for ; Fri, 6 Jan 2023 23:09:00 -0800 (PST) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NprmH0M1lzqTxR; Sat, 7 Jan 2023 15:04:15 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Sat, 7 Jan 2023 15:08:56 +0800 Subject: Re: [PATCH] mm: remove PageMovable export To: Greg Kroah-Hartman CC: Vitaly Wool , Minchan Kim , Sergey Senozhatsky , , , Andrew Morton References: <20230106135900.3763622-1-gregkh@linuxfoundation.org> From: Miaohe Lin Message-ID: <8a20952d-41d4-4fdf-3a74-34a57f9c6171@huawei.com> Date: Sat, 7 Jan 2023 15:08:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230106135900.3763622-1-gregkh@linuxfoundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/1/6 21:59, Greg Kroah-Hartman wrote: > The only in-kernel users that need PageMovable() to be exported are > z3fold and zsmalloc and they are only using it for dubious debugging > functionality. So remove those usages and the export so that no driver > code accidentally thinks that they are allowed to use this symbol. > > Cc: Andrew Morton > Cc: Vitaly Wool > Cc: Miaohe Lin > Cc: Minchan Kim > Cc: Sergey Senozhatsky > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman LGTM. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin