Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp3535814rwl; Sat, 7 Jan 2023 01:19:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXv1LQJnrz6hTvKn423hwSZuAMoPOy8fWQkZlxJ0p7OeL/KuOMwRhp329IeOCNKAgp2bAYuZ X-Received: by 2002:a17:902:7802:b0:189:9ef4:4b59 with SMTP id p2-20020a170902780200b001899ef44b59mr72643265pll.52.1673083157616; Sat, 07 Jan 2023 01:19:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673083157; cv=none; d=google.com; s=arc-20160816; b=qdYtiKDYD8uPU003yB8Uf63NsvlCU1bQKobiLphMiOjeOAIvre1cFJf31aSvuPfXyV RiStIVYo455GsF10Ye9R+ca/xD+87JrubHSle0e26f0oWsQa63h046aEbuqGWCnPuTyS qWGyvAN1wp7CLlPLJ48wSTEDh4Bu5CynvInayaK21ACDdSrTZwx2jgkqkOBM/k8GrTY9 6bRkarDk8uv7LmGwXThbMchYh0agsQqke3OBGivmE7ol3kBHyBf0mxI7qwStgFDhWEBa KHf7kZQIY8FM5NlEfdfBBzqgmjNnhbCBdASZBs7Yjul3slLWXGgkX+XvXUgczBr3l3xq c6Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=UnbNzXROmjE9XLm9+XS424oQyFTP3DDbPbfF9A+/XWo=; b=YHvYA1aUkhJ6h+ztxLhh+j+DivYneb5zk3wCo1Bu4GnGWikQ6sgxuk0f/1WbfJFraI PKdP+/NhZo/p3BcDKfZ2cQ5OZo3dy4ehHC9WjaZYPwFy/2MU2IYzCY7eFmHtrTxVXkTA uRaD8UpX8IQM/L0U40DhP8WD6oiVqeO59Sk5X/vZXtUJJSdjGaAck3RLqw1SSM1Hd94H Lj0309KaoS4+QNo8fqtHWfeKt7KyH6gzeFnP3ANohOVD0RitYjn0S/99pciuNbXjsEOO diY5TXxcgN7UvgX+LDRpHGjKTL2d7Pf2vqrYR+1TfknDIttIGBYvVXldsjSzXro52Vs0 WFcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppMRysQW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a170902ef4700b0018905bd4a58si3338742plx.169.2023.01.07.01.19.10; Sat, 07 Jan 2023 01:19:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppMRysQW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbjAGJK3 (ORCPT + 55 others); Sat, 7 Jan 2023 04:10:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjAGJK2 (ORCPT ); Sat, 7 Jan 2023 04:10:28 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB19271A7; Sat, 7 Jan 2023 01:10:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AE34609FB; Sat, 7 Jan 2023 09:10:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3D6BC433F0; Sat, 7 Jan 2023 09:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673082626; bh=IBB4vS9uXFcRA5vbIOpEIyUnvisvZwkqPn9Sb1Psd/E=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ppMRysQWQN03Z7wpwi3vlzb66/WBwSqtJiTO7+Uoaa4xEfOJfhWqTqKevE+06AMs/ TyQwRzcX5X3FQ2S+h/s0U8CDyNBpVsPi1BPzA7VJbaufr+Q1gfuZKMts2blyiEE0Ug WwnZ32r1b8IRcfZqPR5S83nMC6jxtD6ToBfj0netvBYB8/Pv+piXsVYHm9YKMBLBqZ lJnZl9GUvleKl9TlA4thg5PrX22UnwpSkQGsZ7CP8J2oQUENp8Stxi3mx5JGTY3+Pg PBPEp8+ZfwDdMRFbjW/Vh1ihT97RYQ3KRi9Y9Al2jUjsGNCpBS0L2bWbhOFYngL5Pf 6L4b4iaxQVHXw== Received: by mail-ot1-f46.google.com with SMTP id r2-20020a9d7cc2000000b006718a7f7fbaso2264088otn.2; Sat, 07 Jan 2023 01:10:26 -0800 (PST) X-Gm-Message-State: AFqh2kozTnXskRRHi96JnMTIvFvZDG2GUwK7uXu+oF+eff/0BfGC7dtK hqR7X464q6F7eTUQE9uUrIxvOTesPftUc8ZoDHA= X-Received: by 2002:a9d:128c:0:b0:66c:794e:f8c6 with SMTP id g12-20020a9d128c000000b0066c794ef8c6mr3619042otg.343.1673082625996; Sat, 07 Jan 2023 01:10:25 -0800 (PST) MIME-Version: 1.0 References: <20221231064203.1623793-1-masahiroy@kernel.org> <20221231064203.1623793-2-masahiroy@kernel.org> In-Reply-To: From: Masahiro Yamada Date: Sat, 7 Jan 2023 18:09:49 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] kbuild: specify output names separately for each emission type from rustc To: Miguel Ojeda Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Miguel Ojeda , Alex Gaynor , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Boqun Feng , Gary Guo , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Tom Rix , Wedson Almeida Filho , llvm@lists.linux.dev, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 4, 2023 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Dec 31, 2022 at 7:42 AM Masahiro Yamada wrote: > > > > $ make -j$(nproc) samples/rust/rust_minimal.o samples/rust/rust_minimal.rsi \ > > samples/rust/rust_minimal.s samples/rust/rust_minimal.ll > > Yeah, we were testing the single targets, but not multiple at once, thanks! > > > + --emit=dep-info=$(depfile) --emit=obj=$@ --emit=metadata=$(dir $@)$(patsubst %.o,lib%.rmeta,$(notdir $@)) \ > > Perhaps a newline here to avoid the lengthy line? OK, I will wrap it in v2. > > > hostc_flags = -Wp,-MMD,$(depfile) $(_hostc_flags) > > hostcxx_flags = -Wp,-MMD,$(depfile) $(_hostcxx_flags) > > -hostrust_flags = $(_hostrust_flags) > > This was originally meant to be consistent with C and C++ indeed, but > if you prefer less variables, I guess it is fine, in which case, > should we update the C/C++ side too (in another series)? Yup, we could do this with less variables. I will send a clean up. > Reviewed-by: Miguel Ojeda > Tested-by: Miguel Ojeda > > Cheers, > Miguel -- Best Regards Masahiro Yamada