Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221228100321.15949-1-linux.amoon@gmail.com> <20221228100321.15949-3-linux.amoon@gmail.com>
 <c5b0e7e3-7e74-308f-a64b-f472acd670eb@linaro.org>
In-Reply-To: <c5b0e7e3-7e74-308f-a64b-f472acd670eb@linaro.org>
From:   Anand Moon <linux.amoon@gmail.com>
Date:   Sat, 7 Jan 2023 20:29:45 +0530
Message-ID: <CANAwSgTiJ9=oA6TWPF+YT2fZd4gDifmG-idW6LfHCh2VGYZoVQ@mail.gmail.com>
Subject: Re: [PATCH v1 02/11] ARM: dts: amlogic: Used onboard usb hub reset to
 enable usb hub
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof,

On Wed, 28 Dec 2022 at 20:39, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 28/12/2022 11:03, Anand Moon wrote:
> > On Odroid c1 previously use gpio-hog to reset the usb hub,
> > switch to used on board usb hub reset to enable the usb hub
> > and enable power to usb hub.
> >
> > Add usb hub regulator as per the schematic.
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  arch/arm/boot/dts/meson8b-odroidc1.dts | 40 +++++++++++++++++---------
> >  1 file changed, 27 insertions(+), 13 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> > index 04356bc639fa..3b29169aac43 100644
> > --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> > +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> > @@ -185,6 +185,33 @@ vdd_rtc: regulator-vdd-rtc {
> >
> >               vin-supply = <&vcc_3v3>;
> >       };
> > +
> > +     usb_otg_pwr: regulator-usb-pwrs {
> > +             compatible = "regulator-fixed";
> > +             regulator-name = "USB_OTG_PWR";
> > +
> > +             regulator-min-microvolt = <5000000>;
> > +             regulator-max-microvolt = <5000000>;
> > +
> > +             /* signal name from schematics: PWREN */
> > +             gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +             vin-supply = <&p5v0>;
> > +     };
> > +
> > +     usb {
> > +             dr_mode = "host";
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             hub@1 {
> > +                     /* Genesys Logic GL852G-OHG usb hub */
> > +                     compatible = "genesys,usb5e3,610";
>
> Wrong compatible. Does not match pattern in usb-device.yaml.
>

ok, will fix this in the next version.

>
> Best regards,
> Krzysztof
>

Thanks


-Anand