Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4170184rwl; Sat, 7 Jan 2023 12:28:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXtZ9Qwik7vl2riNNKeyvzZ5pbPuZpIC835ykHGPUkqWZVvGAtG+TkrWDSe/RgP4xPxo73Kb X-Received: by 2002:a05:6a00:1813:b0:582:a492:f302 with SMTP id y19-20020a056a00181300b00582a492f302mr22578885pfa.16.1673123312254; Sat, 07 Jan 2023 12:28:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673123312; cv=none; d=google.com; s=arc-20160816; b=Mlg+CvRmLoTuyWCmSFHJVm0LUo7tmO8S02cPcKq+ukIXcG4Ixk/CN22FC5CUN+5fWu 2kFifUVKt89wmNEH0JD80UNdpyU/EmSp1e5YCAix/delqLln1GIrdHcEX+LT/D7TTCUE AzLIlgjErS3nGkIoVIf/hPtu1PxKVae0souhKnRpDSZ3sG+EGigSx3q92p02NzqUcquN zcG96dhSIXnluo4+hYq3UdjGym0TC1LwlCeBig/eTfN6Dj62fJ0J2RPOd86jeAqxuJX1 Z4cWpsw0uDm298MInrv4OZmQNmh2YQATMVafBGTkG6Nsca8ND5Spfnpekl8ssp4jkjV+ W/JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HH2eHEZl+y1J6jyFsw9Q2SOJYnKKPuwBJha+gp4jMQ0=; b=HBDO2sLr/9N2W7zsqPTGvF/WhiKFqWIL4FIxwy/5EqeqaaPwNdYEIecFwFRmGIzJGb zQwbBmUgq5creU5MNiv33RyrvOoWCzAwHX6isIUWDvUgAgkrSMFYum8HEwx0w/jl68rz lj58SzjVS4Wt1hE0nAcTsOyTo4iObOHfuHuKhzI6pyPNd5vrBrRjfC9YpMfF/9g0X296 kpgAQgtGXx/kQcZXjxT/vylWkdmez6f12qQjKBgk6A9P7OfRyNxTAIgAS2F8HEhpP1iO JFAjyzr5F4j3KkNK/Bd+b9IYIdE6VMSmtJk5Y9qQ//whWzFKtFh0fWenvzH5l3Xu6nkZ disQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=mVJXLZ0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g68-20020a625247000000b00587be58a022si29136pfb.1.2023.01.07.12.28.25; Sat, 07 Jan 2023 12:28:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=mVJXLZ0l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232417AbjAGUOH (ORCPT + 53 others); Sat, 7 Jan 2023 15:14:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjAGUOC (ORCPT ); Sat, 7 Jan 2023 15:14:02 -0500 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EF9C757; Sat, 7 Jan 2023 12:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673122432; bh=HH2eHEZl+y1J6jyFsw9Q2SOJYnKKPuwBJha+gp4jMQ0=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=mVJXLZ0lmxF42piqDigDJ7sT4KMkjheq7qi2x/2WdCpQ0d/Nn5AZiQgwPnG/ZMsgf 8FX9uVlNjmUgqoW82cDztUYMVM3jCBPdXiN3OlBfcQqh8+Xki10DlsCpGHJK/h1vzM YBk/Js7kcCAx56OWmGW9QQ2jlgE7hQ4mRHW5lmbE= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 7 Jan 2023 21:13:52 +0100 (CET) X-EA-Auth: f8+D3POIM0XIqxl0YFEXEeqrBSqzRYP54X7B2nIiew85XgmFGfAKu6vONn6S+H4kXL3dVGALL9yErZamsD/QHyTYkOMaoWOu Date: Sun, 8 Jan 2023 01:43:43 +0530 From: Deepak R Varma To: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Re: [PATCH] scsi: aic94xx: Use sysfs_emit in show function callsbacks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 11:20:02PM +0530, Deepak R Varma wrote: > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit instead > of sprintf family functions. > Issue identified using the coccinelle device_attr_show.cocci script. > > Signed-off-by: Deepak R Varma > --- Hello, Requesting a review and feedback on this patch proposal. There are a few other similar patches for other scsi drivers that also need your comments. Request to also review those. Thank you, ./drv