Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4178715rwl; Sat, 7 Jan 2023 12:38:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXuavjgApbBK0RqH6coOjDuIP7rwKfvBCnKz2zhA+JN9vNWRSGp+A5DLFn2mhG2cYGINdwUf X-Received: by 2002:a17:902:ab8f:b0:192:ce7c:dc43 with SMTP id f15-20020a170902ab8f00b00192ce7cdc43mr20138395plr.40.1673123905604; Sat, 07 Jan 2023 12:38:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673123905; cv=none; d=google.com; s=arc-20160816; b=KwL+GdUYsTLbymiMk8p4YwHvQRP7BrC6Jne3aw9mXM9RjydvErVcU0M2JEu8wukW69 8JW6LlEBxVeDaRPP7QkmSLmCoHL1KG8ZQFiiAczAc3ElqamQuhNGrv/12Z/REFoW5ESX 3V0riPsLEH83th+f/b82ysACjhnIifCZYjmuXs2IvaxVelKqDbm7ia1ITJSxJAVObnrw af7WqRWFNBxl/l8jW8pp+1AfW89c3METrR+4LZptnxOxuF8IS8lL905T3xYRsZnAP7s+ BUZq8jLs5Yj3pYd1548XaN9xT3ItO3a6LLvMlD/Ikd2A/I0I8pvAd/7yn71H/Rihkpff 2PqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ROZ9pnsepk1j38nhEjI/IvMoppQGZa557ZdPMNDI5Kg=; b=va6NOGHnNsj9u8bUHeyeS1HOgisHIVZ73BMIruZ6H8VzdrA0ZY/RyEqz+tQ3FpKAaD gmfLYKlgQWNTPgqYVwgQfgoj9ji30mK5VXSakoMpMsm7vdXC+n3vD+T1EzzyiEuegVll eK3dCmdLYatn6VDrgsaM24DHONrcH7Ni98BFzt9Eo4D5Cn7KjJASjp00QA8zVxxr2BHp yKaoaYw0dMXrC77TS72mu4b5n00nQMO0HtaULUE82xoNrlJ7ANkXlfynjvkFbG8bcByr NgAFqbyH0YxoJSmduwnF8KJJ4PUZAbSDLQdsCFh3E4WygrLe4SbmbuTVecubLhb8j2rr AH7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Jz9bYQZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a170902e48500b00179ec1d9eb4si4261955ple.112.2023.01.07.12.38.18; Sat, 07 Jan 2023 12:38:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=Jz9bYQZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232634AbjAGU1O (ORCPT + 53 others); Sat, 7 Jan 2023 15:27:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjAGU1M (ORCPT ); Sat, 7 Jan 2023 15:27:12 -0500 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1BC934D62 for ; Sat, 7 Jan 2023 12:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673123224; bh=ROZ9pnsepk1j38nhEjI/IvMoppQGZa557ZdPMNDI5Kg=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Jz9bYQZ4/JxOD9PsSvQ3ifoahe5GQo8NayN2nHwORR5cEDjIGY8t6cVvM1WSG2wLj zanH95YcDOCj85Jl2pbAxXEua2nHFkNUoCR6AJFPHW4ycGs8gSpOaNTtzED0QWa9/m b5EF9YJfaiOPoqXuEMjgZgfNbLuzP8Mg5j4K9PPY= Received: by b-3.in.mailobj.net [192.168.90.13] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 7 Jan 2023 21:27:04 +0100 (CET) X-EA-Auth: ChZckfM5iG3viFbLvzT/xcNn46JA7HWZAA1+SeFdhrWztjEgKvaXU1PHfwuv2tA8HORvuQvHwJqJPJ/eKHCaQxEJw7gzpLKw Date: Sun, 8 Jan 2023 01:56:55 +0530 From: Deepak R Varma To: Ben Skeggs , Karol Herbst , Lyude Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Re: [PATCH] drm/nouveau/hwmon: Use sysfs_emit in show function callsbacks Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 25, 2022 at 02:32:08PM +0530, Deepak R Varma wrote: > According to Documentation/filesystems/sysfs.rst, the show() callback > function of kobject attributes should strictly use sysfs_emit() instead > of sprintf() family functions. So, make this change. > Issue identified using the coccinelle device_attr_show.cocci script. > > Signed-off-by: Deepak R Varma > --- Hello, Requesting a review and feedback on this patch proposal. Thank you, ./drv