Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4234158rwl; Sat, 7 Jan 2023 13:55:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtXBiXT3gv40ZMfB+lRMayKPM+GvC0tPzTqUPKIwz8aFMpWxm+LY6m4SbX1PlcBUvBz7bZx X-Received: by 2002:a05:6402:345a:b0:484:e097:7ac1 with SMTP id l26-20020a056402345a00b00484e0977ac1mr35910679edc.22.1673128530719; Sat, 07 Jan 2023 13:55:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673128530; cv=none; d=google.com; s=arc-20160816; b=agLFmLF3svmTlTwIvfosAaOe3B2q6mpdqbC+4hGVuPQ4m/GBeb0ES42BzDyAw5nOMg P229qKY+dpw9vla3tO2lxHzD47//jY0nnw/JiihP+NHTTVHi8mruefS0SGmrvPr4JJ9B N7OXD/iuVLmR41MaIt8PHY2pL0sOgPD0JdGzWZxNMmg/i9ALcdGokLD2t4QIHcDiL9Da t4teRSt2P+ue6AW0CozVMRtxUGRoboqt9bx+s5uzNl1RS8fo5lrdeX4cxGGLoUXQi/JZ atyIma1ECY4RhdpxufBPbyuTNA0jtaqaHxgzP9ILdBJ04JqC4K3BNCF62+Bq3pkMHiCl 1hEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=RV+O7cB5l+vaR5SO6XJa6RTpRYVy6GA4qJE6OAXy7jM=; b=ujSV1wAVTEMuB2n57d6xHaWfXoID6stKM9Yq3SYtsJDmam3Tx0S+FU+C/fj2Dhuuiz qnu7CaiDiRbuPNjQM+qdC5XfnglovtxKOhA+VjiEFXywREQrqf5Hu6xDCPFV220cwIKJ nCiEEichAXJmiPl3CN3Lk1+WmfuaCx/G9bRqCdVF+J9riLfQU7ZJoFwtXyYnXDfduf99 X+lBx2z2pzk88fs/Nm/psDiGMfhA44gFP4FxXNxnqby78W4UfEb3OZuqWTG6jVUuDE9R FlTViTyhp2fKcV9cDVclmB9QHnzop1LcJknm3D6P4Gzek9WbthgWOSGtrn0bV9FlTBgc jUWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=uqBjqGUZ; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v21-20020aa7d9d5000000b0047aa75ad9a0si4758457eds.484.2023.01.07.13.55.17; Sat, 07 Jan 2023 13:55:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=uqBjqGUZ; dkim=neutral (no key) header.i=@ravnborg.org; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232634AbjAGUxx (ORCPT + 53 others); Sat, 7 Jan 2023 15:53:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjAGUxv (ORCPT ); Sat, 7 Jan 2023 15:53:51 -0500 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:404::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A21194566A for ; Sat, 7 Jan 2023 12:53:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=RV+O7cB5l+vaR5SO6XJa6RTpRYVy6GA4qJE6OAXy7jM=; b=uqBjqGUZaw40K9daezgVaSHVAazfEdhdq+JcI2yeGkxOlNFTZpIFrUFk9XABsNvhmL+1pP+c2lsty Fi/30HkWP0cfz+KFCzbqIr/KGrCdW/29/A9qOOGzewzeaFTff3HpRc47oTq/JDYLJUfS8ZZUXFOmTY azBMO9ivKekwR/UiON6K6kWi1Gj4cbXkrtyGZ9T7dDTTn0DBgbLsLGNS6OYSpriPvzh8GbhHLaUpyB dHvxIRmsvOwDoOIvd4kGkpON115b5GxtLYJB/0xlLJ0U9QY+ALENfS6ycYcvcoAx/L+IU1v7E1TCXg U5p0JjIWM8blmp8UFnPHVXSsbDCeFJA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=RV+O7cB5l+vaR5SO6XJa6RTpRYVy6GA4qJE6OAXy7jM=; b=AadjSAWAhsd9s/NuxYyFEDx/hhJmkRh8x7bTEGYiRhB+J+8BsiLl49CfqGKNFHOtMHHLkdtDsLSml eZo40lsBw== X-HalOne-ID: 602b5661-8ecd-11ed-85e1-7703b0afff57 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id 602b5661-8ecd-11ed-85e1-7703b0afff57; Sat, 07 Jan 2023 20:53:47 +0000 (UTC) Date: Sat, 7 Jan 2023 21:53:46 +0100 From: Sam Ravnborg To: Stephen Kitt Cc: Sam Ravnborg via B4 Submission Endpoint , Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Ludovic Desroches Subject: Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-1-1bd9bafb351f@ravnborg.org> <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <553AE999-CAF1-4E59-9F3F-68591ED192DE@sk2.org> X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen. On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: > >From: Sam Ravnborg > > > >The atmel_lcdfb had code to save/restore power state. > >This is not needed so drop it. > > > >Introduce backlight_is_brightness() to make logic simpler. > > > >Signed-off-by: Sam Ravnborg > >Cc: Nicolas Ferre > >Cc: Alexandre Belloni > >Cc: Ludovic Desroches > >Cc: linux-fbdev@vger.kernel.org > >Cc: linux-arm-kernel@lists.infradead.org > >--- > > drivers/video/fbdev/atmel_lcdfb.c | 24 +++--------------------- > > 1 file changed, 3 insertions(+), 21 deletions(-) ... > > Hi Sam, > > I’d submitted quite a few more of these previously (and you’d reviewed them), see e.g. the thread starting at https://lkml.org/lkml/2022/6/7/4365, and yesterday, https://lkml.org/lkml/2023/1/6/520, https://lkml.org/lkml/2023/1/6/656, https://lkml.org/lkml/2023/1/6/970, https://lkml.org/lkml/2023/1/6/643, and https://lkml.org/lkml/2023/1/6/680. There are a few more, I can find them if it’s any use. The patches from yesterday was what triggered me to resurrect an old branch of mine where I had done something similar. I had lost all memory of reviewing similar patches from you. Helge - could you pick the reviewed patches from: https://lore.kernel.org/all/20220607192335.1137249-1-steve@sk2.org/ [This is the same mail as Stephen refer to above - looked up via lore]. Stephen - I expect Daniel/Lee to take care of the patches from yesterday. If you can look up other pending patches from you please do so, so we can have them applied. Preferably with links to lore - as this makes it easier to apply them. Review of what is unique in this set would be appreciated. Sam