Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4243321rwl; Sat, 7 Jan 2023 14:07:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXucXMSNPFnak9qmYmOazMrHvyOkJTt7MXDT2dF3yoTJxqG0QNNtuW76CYvITPG3peFsJ6ye X-Received: by 2002:aa7:d30d:0:b0:499:1ed2:6459 with SMTP id p13-20020aa7d30d000000b004991ed26459mr974676edq.20.1673129277261; Sat, 07 Jan 2023 14:07:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673129277; cv=none; d=google.com; s=arc-20160816; b=TUOUNx96qiqw3vp310V5t42i4vlZf+vJTKE5YPEmPePmJKTfT8mreUGd3T8U0fsyHD as4hH4sdPq/qjZhcYyoxnJbYYBjUWZCJLkvH+gdWS2QeafBbepYWC65tRx6rgqWgSQdx RbsjhZXdZaxIYDiIKpoYzYabLoiNlrsCvJW5dG33I5dNUbcD1kSNJe0miYbGPqEwCqwT PHh0InFMuvzGBluxoVisQMAF0XSnEqax7Fl7fOwb2yyckpq2iTYr3nZjRMbSYtJZs0VL P8YY++pOM31IH3NJtcju5LSChF6f6xz+kk/KirZlVpyqZzSpsnTI2oRVNipdOsTmaQ+P 8+Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/OfmR0+wzL1Avs3upceycf/E25gjY75tSVQnARrn0Ds=; b=eW0+u40ZAq8OaH0nKNpOHgk4tITuA8tiBSFywemeH0Dlk6WkUeuLtFRh0bS9D6jIyo S842p1FyBu6/nM5Fp/IPmjnZAQ1RlKszz6Uu4ky3DWmxfNErvFyRxKiYraH7z7cUZgaX D+cu4j6PcBG1euFFvpSE1BvjQp7adPOeCoTZtl431chEFbcRBhJqV5F6jFozSeqf8yei YMeRC6q9avVwuTbZD52iKPA1DA3yc8mqaBB52Ks2m680gHSiCo0T9Ss+4R2mm5WHDAg3 LqWLmx/l3zENyw7tjjSmUB4o0DuvizSwyoFgbU/d4qAbuY8qiZjID42ds9qVMRSQ5cC/ mO/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="qVePZD/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f5-20020aa7d845000000b004922b9ba177si4500191eds.112.2023.01.07.14.07.44; Sat, 07 Jan 2023 14:07:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="qVePZD/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232494AbjAGVjf (ORCPT + 53 others); Sat, 7 Jan 2023 16:39:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjAGVjb (ORCPT ); Sat, 7 Jan 2023 16:39:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B967360FC; Sat, 7 Jan 2023 13:39:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5CB05B80816; Sat, 7 Jan 2023 21:39:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68BE7C433D2; Sat, 7 Jan 2023 21:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673127565; bh=X45kMdlDNxaqxDxmSIkrPks0CTIZ+F9IiqElqXlNkEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qVePZD/GGkp09FGcBjE1NDWMv0pNyzK3d0MA4TnFTl85q4MLclJ4aZM6sdpLpayur gbPSXPw55S+HjgSatCXDMKV5ebKPDLW9wC5ZWygjxSFz5wrZKXse0Ayy8b9nFG5zX0 AOEYNKrjKa0Z8m/AmQ5vKLqh5TnAKBQbYk1hf7qOnMjWynNcrQrbU7b9QqtKkmEJd2 v4InyJS8ni0GMmbHUTAEZdCrocK2ROI2APJKdoqPXtoPuFKJrdfCCxKLGTZWY+5gdT 7HIIVQA+FNDmuYbRiUPCvsd9AV0GroQZ0EIrwfJkZLl8Glf278A/JnZeVyDoteNu5p CJp393eQrydbA== Date: Sat, 7 Jan 2023 22:39:22 +0100 From: Frederic Weisbecker To: "Paul E. McKenney" Cc: Zqiang , quic_neeraju@quicinc.com, joel@joelfernandes.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: Fix missing TICK_DEP_MASK_RCU_EXP dependency check Message-ID: References: <20221220141625.3612085-1-qiang1.zhang@intel.com> <20221221201634.GH4001@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221201634.GH4001@paulmck-ThinkPad-P17-Gen-1> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2022 at 12:16:34PM -0800, Paul E. McKenney wrote: > On Tue, Dec 20, 2022 at 10:16:25PM +0800, Zqiang wrote: > > This commit add TICK_DEP_MASK_RCU_EXP dependency check in > > check_tick_dependency(), fix commit df1e849ae4559 ("rcu: Enable > > tick for nohz_full CPUs slow to provide expedited QS"). > > > > Signed-off-by: Zqiang > > Again, good eyes, thank you!!! > > I have queued this for further review and testing, given that it affects > pretty much only RCU. However, if someone else would rather take it: > > Acked-by: Paul E. McKenney Thanks for picking it up! Please also add the following tags: Fixes: df1e849ae455 ("rcu: Enable tick for nohz_full CPUs slow to provide expedited QS") Acked-by: Frederic Weisbecker Thanks!